From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F578C25B10 for ; Fri, 10 May 2024 22:33:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 137136B011F; Fri, 10 May 2024 18:33:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E7236B0129; Fri, 10 May 2024 18:33:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC90E6B0136; Fri, 10 May 2024 18:33:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C9B9E6B011F for ; Fri, 10 May 2024 18:33:44 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 42A0C120269 for ; Fri, 10 May 2024 22:33:44 +0000 (UTC) X-FDA: 82103939568.19.F0B610E Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf09.hostedemail.com (Postfix) with ESMTP id 53189140006 for ; Fri, 10 May 2024 22:33:42 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=BT7uP68R; spf=pass (imf09.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715380422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rx86BKf20oqqJvvyTkwVjgHBFBglkui4kaaauK5EOTw=; b=INqiaiLK6lz9efc/U1ijW1TLdNe8yc+pEN5sYcm05PaRmnwdwVzfAa1FZJuXgm5CMvdIa+ PqxqcHM2SuD2vmI+lOcYFr2qBS2xGVp34ZtmByyNSBke8nZLC0UnTMStstfTZZgIV0kcSI sG8rTVcbfYOXtdqprW7ogIqM7u7nzfE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=BT7uP68R; spf=pass (imf09.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715380422; a=rsa-sha256; cv=none; b=Qun3DggLwQhTDxrOjP+VoxGYtJ+mou+6rzE0mZKw0zloM24wU6NuppQCMYF/0SWFIhQOLM q7huKzKk1BshcxR+pGmRDbx+3XXCaA8Z/61uQ3R1iZZtbruwX7p47R6h5uQPZ6QnvpaP8B SsCHGfDYOti6Soieq2KY+5c3GXL8jns= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1ee42b97b32so21345315ad.2 for ; Fri, 10 May 2024 15:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1715380421; x=1715985221; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Rx86BKf20oqqJvvyTkwVjgHBFBglkui4kaaauK5EOTw=; b=BT7uP68RtkebT9Fg7cn8La4AQBthj1wKEgmSbPSz72GAwJ4zEWJ3GNFORJyl9Cj9vQ bAJQvXQ7vJnfqye5Vu+Z2Y6GH4ANPbFVvYEp+0BPn2GE2DkU+x51mL1yEjhhq45etrGS I1jmDHcw2jcyMGNdgVQjjuIC0YYNROPZ21mk4Qrg7HO41Pc+fitSJT8/Go5LCwShNkeE MdufJcqJMm0qtxLkSmUBZKQfN6ZfS/TbO1AXR/Z8KqlOw4CvV3j4JtUW3LOyQF6Q0s+9 +M8N9q7Atdr+ccq3fKz4GHKD9qvmtHEhP7jLMadQwNjKWecp/i/p1V7tnbo1DixOPjoE 2a5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715380421; x=1715985221; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Rx86BKf20oqqJvvyTkwVjgHBFBglkui4kaaauK5EOTw=; b=n6eEr4IY6rP9i9QqduzxefFw6O7Zyjka839m7gqle7CF7uZQcBDXNBtHI47C3QNmlt 7H4w0Q1pBHAo3ScNiKdzCw3SJhXTEo+lVCSMM6Np2b2N7XzE0tlMitDO2xBxDeL1StcZ P/F9SLyRuTdiObH0wCrmd15iSHdArCMTTyJNiR1MGMSH1dd0uschv2dtgzPw+ejhnFn1 eU/FMD55Xbbgvlfe01H1nPqt1ZdYroxzrv2Lcl1EGBDPDdFD3dKNflx2wwEjLxC88RRY iBhHcnCINUkRu2doJyD0zfZERMnWuhRSAg/mTSpJbw9axUAw53iBMsOK5bUExaq0Wzrg xK/w== X-Forwarded-Encrypted: i=1; AJvYcCV6XzxgPSoRp2ZmJo1EZmZYnaMjxCQkm1iU64yzBMg6KFekyZr28PuFJQlbdJzlZwAS/mbMd8uSnaF3J9DjEyXNWsU= X-Gm-Message-State: AOJu0Yzn4ZgNZ9YYEZ1LGO/v0spXjTxUwWNSkaQKni/HNHx9+1TVFcVK /e1ljh1BEEtrEM/jJkn7d2OPC4PvscsVgOhFzwFTLJQdGf63MquC3t/rIUSQWNc= X-Google-Smtp-Source: AGHT+IHCbIPqYj/CMVX+dpcmx2/ThEVPaXPHBWvK+JEhPYkGjzop6fsJUs8nt4PjI1Rtz6v88FXlIQ== X-Received: by 2002:a17:902:d483:b0:1eb:57cb:4c69 with SMTP id d9443c01a7336-1ef43f4d1ebmr53974765ad.45.1715380420958; Fri, 10 May 2024 15:33:40 -0700 (PDT) Received: from ghost ([2601:647:5700:6860:629e:3f2:f321:6c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0c16093fsm37221825ad.281.2024.05.10.15.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 15:33:40 -0700 (PDT) Date: Fri, 10 May 2024 15:33:36 -0700 From: Charlie Jenkins To: Deepak Gupta Cc: paul.walmsley@sifive.com, rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, alex@ghiti.fr, bjorn@rivosinc.com, alexghiti@rivosinc.com, samuel.holland@sifive.com, conor@kernel.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, corbet@lwn.net, palmer@dabbelt.com, aou@eecs.berkeley.edu, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, Liam.Howlett@oracle.com, vbabka@suse.cz, lstoakes@gmail.com, shuah@kernel.org, brauner@kernel.org, andy.chiu@sifive.com, jerry.shih@sifive.com, hankuan.chen@sifive.com, greentime.hu@sifive.com, evan@rivosinc.com, xiao.w.wang@intel.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, dbarboza@ventanamicro.com, sameo@rivosinc.com, shikemeng@huaweicloud.com, willy@infradead.org, vincent.chen@sifive.com, guoren@kernel.org, samitolvanen@google.com, songshuaishuai@tinylab.org, gerg@kernel.org, heiko@sntech.de, bhe@redhat.com, jeeheng.sia@starfivetech.com, cyy@cyyself.name, maskray@google.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bgray@linux.ibm.com, mpe@ellerman.id.au, baruch@tkos.co.il, alx@kernel.org, david@redhat.com, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, shr@devkernel.io, deller@gmx.de, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com Subject: Re: [PATCH v3 02/29] riscv: define default value for envcfg for task Message-ID: References: <20240403234054.2020347-1-debug@rivosinc.com> <20240403234054.2020347-3-debug@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403234054.2020347-3-debug@rivosinc.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 53189140006 X-Stat-Signature: wm3othac8fz4rtsc4iwn9x8qwe7xconw X-HE-Tag: 1715380422-716855 X-HE-Meta: U2FsdGVkX1/9KrrnYRoN6fBCuUZ0PgStP0mGIxRfrapBITNFHAbgXob6XIQtJQck+xZ/UWsmEYmbZ25j80ik1PhhDn6nMyYhhs5ZruM4FsdPzGvnbIBIdj6LNCS84ipBmqIYEqpP/O2hESKI/cYo0BB8mkbrYQSPKTDKbsmYR0O1FkMSjdZP9z5jg0JeHhoV0Dt2rXdcm5duFHyL5SIInLWIpmlNoRcGSZRrgCgmgo0ldnJlWH1OZ1Nr39w9bp08gDGc7eYfrfZazoFBDOFt5r/YKjPjVfhzNDSNalHy//aibB7uuNVHQOsyVZmrDkAZzHcZdfYR5+6nxCvGJal57uua9kaqipQlz/YcwAsmrlPvH50awboJOE+5JPpspwxzIhbrv0jC8aGXLMKJeGlRiKeCNrG1KCIr4h70iL72B3fh1HRa/WwWy5jaZsWgivzoRJdhipA67+/xvI1wGZlSFYeZgimE3LE8KNZXPToyaj8ixtVSoGzEsIY3kVBB7c0EoLM5SklkoNR0WFdYy0+0qopchFmUGbLszMwvkJB8YHHLQpYaQPFb0jp57L4SQ7UG97ahXP9+rnqlob2KNCM4A/j8NAjrwoWH//yQDDlSqUrVTcSuOtzQkz7JwFehDw7m5c81vSO+M7LJJnvyI4uzW1gnxwU7I/Yhq73Ww6x632UxsfISIZ8rRYtrGUsLOpHQIJCgd9cXafzVkEFiVBE1MiWEeX0urDTb9BcLtmjVi/RXygARKEsJaeWf7Fn/92xRQo9qH7AR9vS3xA+zqMkn2vPUqUSRHrEHPtB3O7pFKx7PzV0gfV+PoJBkT+mQrJm5DOKomV9E5USTkMY/e9s7WAO3OIyKirEO+omjmYJCRZcd5Xh5QSO0TsvGNqTAHlw1OIgyf7sjIcRzbK8o+DevO7663A4LE5+e3K6jnK0sS/UJdm3kcbD1rSB12HkOyBtAwJmH4A5rvd6YPK40PJC mJ0w/SjC Pgt/lQrcDilWIQtZVNYssEg0FuMvc9uPay6XqutfKKFa98V02JsGSWqb8/hwwFqRB0geiUcvM0jb5sc5ITTIf1WQEG6R1xHEQuV2gP5OSSmDL2PlhV1VK6pnCC3EgR53MoGzHWDswm/wyu7Q1UdvLLFlYiMWB9a2y1E8ojsIUkpvdbHH7CwMSrmaZgyQkO5tZ6/S4dHXHH4ih4kL1bZgJgddW5JN2p0opLJa8yHdsz4mMO0N2Obqh8JJ+cJGeSByx72iK+z+Lj9fUfSIbgzUqIivdTfp1cqlnFtmMA1zt4+fMPSvKI9UQgnXe3ZoI2oiUfpA0z3rC+TlUKacj2olBAoVbrAHMOkE51abdzsGr/LMh1HD2yF+UqphVJHGWeASPLLVPuAnmyQWtTlqb98919oNYYeuIWspiLgHAOeMRT/kVstnHXEO/UH5W0hAfldB66bTVB3Xd+uS7XTzKh6TspxjOGdfV3pf/diDJ9UpRQxM3HvwDkZUOJTzx2yyjsb/mPBtM3FcOUBFWoJnwAf5kD1ye/L0dxvioJnw/NcB36+53FiOQyUHClA08FnEThUUDtRlF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 03, 2024 at 04:34:50PM -0700, Deepak Gupta wrote: > Defines a base default value for envcfg per task. By default all tasks > should have cache zeroing capability. Any future base capabilities that > apply to all tasks can be turned on same way. > > Signed-off-by: Deepak Gupta > --- > arch/riscv/include/asm/csr.h | 2 ++ > arch/riscv/kernel/process.c | 6 ++++++ > 2 files changed, 8 insertions(+) > > diff --git a/arch/riscv/include/asm/csr.h b/arch/riscv/include/asm/csr.h > index 2468c55933cd..bbd2207adb39 100644 > --- a/arch/riscv/include/asm/csr.h > +++ b/arch/riscv/include/asm/csr.h > @@ -202,6 +202,8 @@ > #define ENVCFG_CBIE_FLUSH _AC(0x1, UL) > #define ENVCFG_CBIE_INV _AC(0x3, UL) > #define ENVCFG_FIOM _AC(0x1, UL) > +/* by default all threads should be able to zero cache */ > +#define ENVCFG_BASE ENVCFG_CBZE > > /* Smstateen bits */ > #define SMSTATEEN0_AIA_IMSIC_SHIFT 58 > diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c > index 92922dbd5b5c..d3109557f951 100644 > --- a/arch/riscv/kernel/process.c > +++ b/arch/riscv/kernel/process.c > @@ -152,6 +152,12 @@ void start_thread(struct pt_regs *regs, unsigned long pc, > else > regs->status |= SR_UXL_64; > #endif > + /* > + * read current envcfg settings, AND it with base settings applicable > + * for all the tasks. Base settings should've been set up during CPU > + * bring up. > + */ > + current->thread_info.envcfg = csr_read(CSR_ENVCFG) & ENVCFG_BASE; This needs to be gated on xlinuxenvcfg. - Charlie > } > > void flush_thread(void) > -- > 2.43.2 >