From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB109C25B74 for ; Fri, 10 May 2024 11:57:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 173A66B00D8; Fri, 10 May 2024 07:57:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FD5B6B00D9; Fri, 10 May 2024 07:57:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE03C6B00DA; Fri, 10 May 2024 07:57:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CF3546B00D8 for ; Fri, 10 May 2024 07:57:45 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6A25AC17C3 for ; Fri, 10 May 2024 11:57:45 +0000 (UTC) X-FDA: 82102336890.22.1D073F8 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf13.hostedemail.com (Postfix) with ESMTP id 46D1E20015 for ; Fri, 10 May 2024 11:57:42 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=bQAriabN; dkim=pass header.d=suse.com header.s=susede1 header.b=bQAriabN; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715342262; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fxWM34KiqX62IKR1RnVV3lWHklyyFYPYe1Bmn9kILe8=; b=sMKqXxhgdR4fSaewaSLprb5nyQNETxvFan4wuRytTeK2y3s6vFbHeJOiA0m8yQHrN1o1bY lLr/GesbckXz+BhHkV5BHTBaUlrh1laqTj5Fj1O9g2AINkQYQJkb6jexf5mRc8xN8jQVKV 4o9UrTjuQc2JJHkit6nFaic/SijDvWA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=bQAriabN; dkim=pass header.d=suse.com header.s=susede1 header.b=bQAriabN; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715342262; a=rsa-sha256; cv=none; b=28IpyvprSWbOT9cn6W7vKGE7925XjgZQ03pl5K+CxiY4h4Ya85JdTXm/y7S6+JRUOUkP0X ZeB5+Ivx+fbbLhv7ZnfKjskCMtF51GPoyso7HCQvNgfmgUlzafX8Lq67Ezk8zE9XFkECve XKsgL/pmgzY/WzIIYMnTQR+mkO9HjSU= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8B3493EC9C; Fri, 10 May 2024 11:57:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1715342260; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fxWM34KiqX62IKR1RnVV3lWHklyyFYPYe1Bmn9kILe8=; b=bQAriabNcwdwS00TgF7K7dc5ui7142wcn0+HDLCrs9cQMYCddKkZ0DnU38PKLhHvzcLB5n ccjcNw7Q9m8Nh6nRGyzJgGpbxpRfKrz4YJf9M8rZV4+zg+uJPxQePftqeWeDIdiHk20Hw1 i6JGmXwPN4kbNKEpWQHFIVBpHczvJtc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1715342260; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fxWM34KiqX62IKR1RnVV3lWHklyyFYPYe1Bmn9kILe8=; b=bQAriabNcwdwS00TgF7K7dc5ui7142wcn0+HDLCrs9cQMYCddKkZ0DnU38PKLhHvzcLB5n ccjcNw7Q9m8Nh6nRGyzJgGpbxpRfKrz4YJf9M8rZV4+zg+uJPxQePftqeWeDIdiHk20Hw1 i6JGmXwPN4kbNKEpWQHFIVBpHczvJtc= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6D2DF139AA; Fri, 10 May 2024 11:57:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id MTCrF7QLPma7ZgAAD6G6ig (envelope-from ); Fri, 10 May 2024 11:57:40 +0000 Date: Fri, 10 May 2024 13:57:39 +0200 From: Michal Hocko To: Xiu Jianfeng Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -next] memcg, oom: cleanup unused memcg_oom_gfp_mask and memcg_oom_order Message-ID: References: <20240509032628.1217652-1-xiujianfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240509032628.1217652-1-xiujianfeng@huawei.com> X-Rspamd-Server: rspam01 X-Stat-Signature: m67h9c6q8ss1dc1f679pnet6s9jr9x7d X-Rspam-User: X-Rspamd-Queue-Id: 46D1E20015 X-HE-Tag: 1715342262-981149 X-HE-Meta: U2FsdGVkX1/riDpIgUEIc4tyFy3Ec0CbW1hTCxNcJfATvKr1U+YKldURiB/6o+lsKBfNq8BBHHLWs/g8KMi1IeyxPCmP09o2abqY8iewvxfSrvIDrYbCtzMY0jmHsz411bq5xthoCJhoVdNI+2vZTOU4iZfV7CXfuaXT32ZSj6BfbfXSXhFWfnGFRgAMe0S0WEos3f4vF+DEKK5ININujnuThEVPExr9RRHQZ+rLkP5lypeH1AaPwsBLijJMf/czDnn3Hy3Um9ntcEjDWio8AumfXa1EogSMocw2u1C6fyLyvXVLDINqeg29JkorAFJq7w68KdupvPGyt5VFdT+70jVW2AXLUo1f70dcj8cWHV0J74VTQU5Disx+WU9GrmSi4EeoaJ8ixOqzjfoEr9ceVXKr+KirDbGZPtiSSAZKopbLjF6iZIwt7KODEDzY5x+NsnS5vvdqn76AJsp2bZC/+9MVl0oGML27jv4ZFjgMW5wvVUThYDEEOCCVv99LyMJPPKZwX/1scgFvK621HXwNOpbXZYlBgWpJIy47+oHE8H/aswvBB09pT8RvFT2Jp0SOdOVfnXXcg7N+/AFsczgtj/RQ69T6DPps6149suRWaGYkfKkP4TBnMInzZwauwiDH3EQJeGnJLH1Pe/n8SGyacXIiaani0UDEqgBrqAXpTTOvz+84cMWFIOPPZfflm26LtuOaiiFfOQLb8yiSmUWN8s+SdlOWr24ymgzgJH9YTuaP3bwIlTOCWn6kOANSU0A60iFy11GGWgVyuRCBcbN0Rw5EujPAjleDAPSAyn7PTvkKRcqi+WHwPVQ5jO4vbcx+W1IwsjMYlGX+QIfshMGUHa8w2p1Ea9JB1084dvozM0VPpHJ+rL44y+TNQeGoOLkiOTEj830P3jBHLFippbIU9gZ4XG4Ldhhr7uF6Fo1icFfj/ZRVT1dqjyZz++gzKYHP7awmndGILZdsJBKroNu xfFEND3V YcDzMHOa+lSdndJcOvgxPKPYp3NlyGxrLKEiNibBbLSG+5sqjGzm5cE79CtI8VD1MHF3WRD5nS13qRBed+odint3uNXlkiFrVSpqz9N2EmMeOG+UBDDSQxkN5NFC1UlrjEikne6tnitmPUcO9Cp7cqmVNJuBKR2ykLufuuo5ms1qsnNNhJVbblUu3ZDKtD4FA8yfQ/BIBvFahmIm31iMUWjwXXIgR09gR+wNsu628cu1GRgsvc5mISQ2OvJwVP/lqxbPaaT+nTWDYUD2bsDTWowmDuT0vYwQ6sufT78kWyEcTV83W1y9sXY6cxWMNnpreYmJeKUdF0ylrCLnt0YTzVpAJES22Ak8oabQp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 09-05-24 03:26:28, Xiu Jianfeng wrote: > Since commit 857f21397f71 ("memcg, oom: remove unnecessary check in > mem_cgroup_oom_synchronize()"), memcg_oom_gfp_mask and memcg_oom_order > are no longer used any more. > > Signed-off-by: Xiu Jianfeng Acked-by: Michal Hocko Thanks! > --- > include/linux/sched.h | 2 -- > mm/memcontrol.c | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/include/linux/sched.h b/include/linux/sched.h > index 8d1cf672ac4c..61591ac6eab6 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -1449,8 +1449,6 @@ struct task_struct { > > #ifdef CONFIG_MEMCG > struct mem_cgroup *memcg_in_oom; > - gfp_t memcg_oom_gfp_mask; > - int memcg_oom_order; > > /* Number of pages to reclaim on returning to userland: */ > unsigned int memcg_nr_pages_over_high; > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 5d4da23264fa..d127c9c5fabf 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2192,8 +2192,6 @@ static bool mem_cgroup_oom(struct mem_cgroup *memcg, gfp_t mask, int order) > if (current->in_user_fault) { > css_get(&memcg->css); > current->memcg_in_oom = memcg; > - current->memcg_oom_gfp_mask = mask; > - current->memcg_oom_order = order; > } > return false; > } > -- > 2.34.1 -- Michal Hocko SUSE Labs