From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C623DC25B10 for ; Fri, 10 May 2024 11:04:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BFB26B00A9; Fri, 10 May 2024 07:04:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 548996B00B5; Fri, 10 May 2024 07:04:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EB626B00B6; Fri, 10 May 2024 07:04:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 19AAF6B00A9 for ; Fri, 10 May 2024 07:04:57 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AAA6F1617E1 for ; Fri, 10 May 2024 11:04:56 +0000 (UTC) X-FDA: 82102203792.07.632DD74 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf02.hostedemail.com (Postfix) with ESMTP id B616080007 for ; Fri, 10 May 2024 11:04:53 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HvhMPVr3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715339093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4a6MqAXgOYgO/zeSg4OXSoaN8MW/2yPAiLOJV3hKyn4=; b=fo/DwgCFAaMe43nPKPN8nc2UAErew4kT/NAwfo2Y029tdP0rgtbGacv29a/SmF7dza5yN3 v2+4oN3cbBaZG4MZZRU3odbh6dmmCxAqgDeBCIdFEQtma3nCpJXD9YQ8OQn0CiZl0oBKhV KxmdLUZ3QCId542kQ8zoQhLwD8YS2io= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HvhMPVr3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715339093; a=rsa-sha256; cv=none; b=tlN7czS27KbSg0NvEIkUi+6W3Blx1XjV83HJmNWdQq2CDTbmvkDsOHc/JuRK9F6P0kRnxi +TP4L8qCIEotxTDmjfUaE+kJwk30wxvgUB+B79lfzBfXkGc2vnS/mcfAYV12ROwQAT3lM1 8pW7ucwnvIdCfbdnlF+3eZT1gTBP5sw= Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2e0933d3b5fso26382861fa.2 for ; Fri, 10 May 2024 04:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715339092; x=1715943892; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=4a6MqAXgOYgO/zeSg4OXSoaN8MW/2yPAiLOJV3hKyn4=; b=HvhMPVr3V2rcLf7GoxEd9qgr/HMr79NvkVRHE2vo2rxPABVqloH8nJnLKi0cwgOuoG dmswlO7JDh5Y4S5BvrfMxrMj5rsVAZ7ywDgw/b4hLaqqKDamr080SKNGefWrEN5bK9i2 iWafP3Wi6QNbJ20qtYk43Nq+W4+9JnzHCMIhr9zgiShHiENfD4vea2/fI3wY/1DMYS2Y MggB62EGl7FH7jGioOnlVavP5XAqgJlwhd0dQUFQxYb2X31kIQWuScWTql0ei2EjKWlS A5nbulccYMLjaT2HfkapSVCeo5GMN4/VHNAEZnvArJ+jdxk1QCUeREzKCTITaHrAAZVg tuXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715339092; x=1715943892; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4a6MqAXgOYgO/zeSg4OXSoaN8MW/2yPAiLOJV3hKyn4=; b=nZSUCZIHd6FN+AipQDX52MmT8HkDenAiHU9XCEdkZFvOYZWcYhW9biI3lXBDD4AYwE NL7trmuPFeBkW/2/sUSfWaXPh3zAm2dHuwtC0FXevkRP/3+TD+/khoA/lmSNa757Vd1x tEm/IKofq2KXJ53kY5uJUY3V1jQHkvSBJRQphNxIheVW8nK6AS1IaboEj+gllE3zdRUP PhxeOCG7mH2CeRqEHQEKQZLnqEc51K3zA+r16KvOEKYoNMkpRVM8EC/KlxMlw00U571c SEESmGOWf0+QHX7obrNyGjo4PLqB5BWAZ0SL0tsD/dGF8HOJx3yoa1tpGaw/tvgVWbUX Ps1Q== X-Forwarded-Encrypted: i=1; AJvYcCVK35EiWiJPN9sln4ZY4trxmd8wkxWTWMXnFMNmgvk9Afdl5b+uvQJhtSVEnUOcnqUmOW8fWNGwKAFrNZddctEH/kc= X-Gm-Message-State: AOJu0YyrdklkqAjj8tyt+EycH11VPzYg+zgTyVe4hk5wZ+nlaAsGf6fj 9Z/O5NOsypaGA1WJay03Ydi24HbfrnoxHZTqqYNS65ZVbwP4DUWm X-Google-Smtp-Source: AGHT+IHNdtEdIiwJ0odNu9WSq6dAR5BKpqr2GOix0my+cZM7OnDExinCASQ62/8BSIIHVZjIhdalGw== X-Received: by 2002:a2e:8449:0:b0:2e0:3132:94d4 with SMTP id 38308e7fff4ca-2e51fe53f21mr14120001fa.16.1715339091512; Fri, 10 May 2024 04:04:51 -0700 (PDT) Received: from pc636 (host-90-235-3-187.mobileonline.telia.com. [90.235.3.187]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2e4d0ef17absm4761551fa.62.2024.05.10.04.04.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 04:04:51 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 10 May 2024 13:04:47 +0200 To: hailong.liu@oppo.com Cc: akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, 21cnbao@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xiang@kernel.org, chao@kernel.org, mhocko@suse.com, stable@vger.kernel.org, Oven Subject: Re: [PATCH v2] mm/vmalloc: fix vmalloc which may return null if called with __GFP_NOFAIL Message-ID: References: <20240510100131.1865-1-hailong.liu@oppo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240510100131.1865-1-hailong.liu@oppo.com> X-Rspamd-Server: rspam01 X-Stat-Signature: tu5xf14tykps988gczp6ooxd8o8now9p X-Rspam-User: X-Rspamd-Queue-Id: B616080007 X-HE-Tag: 1715339093-73063 X-HE-Meta: U2FsdGVkX1/BmlVUY+fcfXYKfTDaUlGphI77BA1SyX9wUUyNek4rTot7AWMMS4V1CbEEaP3b7DGRn0ZdDMmmAI6Q+mHtrIe1bO/trGRUwspPiXWqqxcc26ujIUkyAq/gfQu8aVg/1uirfrjWZMEMqBpAkxzfkjVUHghV+B9jXm2Hy84z/XxFFBdkEydy17oNfaGOHy2sksqzADGIAfPHam5Q4DPtznGWsik/KRFwOQi25q8iiXvoeEsEzmViub/B6uuU6fk4XdD3zTmBMzVkevOnhKKUr2K2hynxllaG3LOw4zYp32UXsSSBDI7CAVQvY2LYhNd/gfAaCJ7IJK3ufHa1kjjmzIK+gZgjKL+mH3tiCr4nsBySukmjeArxfFOg/5nUk6KcOA+IPKFjqKuXaolEMxf6r6dd6yc1pZzt0wxZkFEYjRZq9653qAgiPxttHFfFJZQ2UI02NytDa75vIKLkEB81gnx45u4JnpLpJwgC0W5PvoaIw1GY9HyjrPmCRje+wdqJRgtVD5plBjdxV0F65yQJTOaTbPzZbQFGG1ktmRQWLyuz4EP3uIpGhXxQifE0zPCxK0m5xDCOQlBDkjafR1detZHCvoTrpu8GrdDgfmu5Qi03stzAk3FZmzcjzA96TgnSFsk8mxOHDk/L/i/Y/SZsWVAgo3zWzBm7EA+V4jyGo9CnkK1rr2lPxtx44ChBWaP5VUopb/lIPQrjRunh9naKsfB5d/bhzOliiE2jrHEcQisdEopB/tjmMWnlteSGxZUu1mt6nM4YU+D8tBZ0ZBBOBykNT1bbihjJqP8S8KT0QUtPw9QP0NBL1y5ym9lHJJB5LI/2dJNbMjFYZWqJ2GrV+krmmqHTMFu3BN8Ig5KIBaGqa6nPq7RUbaQcdd+tTCsxyF7urxjq13GeCMwRJQxIVrH9ttg6ds0LFp3824USZU2DxK8OtDmq3a0HXBlG2LHSxedmouMd+C5 Zh54sHtQ Hp+fnIzNX14yzwD6ksVTXyityzcpLy6Xd3UafaGMBpthBukiIOi+6Hq13yluUnjwDQ9HMLwsNQNLWxg4/NPNdv/9ElAH7sKFnDSum1lY6RVxrgSzse9UibImb0UhYfjn6wbkydftktsgPpEcIUHLgSiuBj7w45+5vd/lRKsw291ErLAagkQcr+QZfMs5X86vxaAbsOCqTsHXXNdk6yM/rnX5OV5f28gzJNZJ/g/lzdFD9dZSdBc4xjOAUR/XU0XoHSDvW3LKnWVS7pY50nIHEySJ1AXaFic3s1ckzFPm+hOPaAGzLvC40rybMnnWO1aJg5gUiHQd1gPrsL4rhx32+qmZCIgo/BuZTM19RDDfY1wyzlYZV3FhD0bApzySTxtvYKC5g8U2/JMLpTf0HycF/3YBYjSIs4ZKgOmocU3CV2eNdUZck/GeeCYNSLIEJg+mha1uk2hjGXCwMVhXdBx2HR/ST6OThoE/vR+TywpO8Rp0a4o86e6DmB/tTMgo7aRy5Jyp0LElDH/6lck93znfSzQBMLZ8i6rYhvG9z72tHshz+LI7DY8DmQuOUqDCw3ai6BJ+g/iuj86aSzd137T/dE6EHNZu9Hm3yIjKB89eH4A5owLDbtN1PuR4qXB2+wwm4Bbxzk3y3KVXMhDkKkBqq5ZwSCKrVKeFwIuHn16A5gq2aUNU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 10, 2024 at 06:01:31PM +0800, hailong.liu@oppo.com wrote: > From: "Hailong.Liu" > > commit a421ef303008 ("mm: allow !GFP_KERNEL allocations for kvmalloc") > includes support for __GFP_NOFAIL, but it presents a conflict with > commit dd544141b9eb ("vmalloc: back off when the current task is > OOM-killed"). A possible scenario is as follows: > > process-a > __vmalloc_node_range(GFP_KERNEL | __GFP_NOFAIL) > __vmalloc_area_node() > vm_area_alloc_pages() > --> oom-killer send SIGKILL to process-a > if (fatal_signal_pending(current)) break; > --> return NULL; > > To fix this, do not check fatal_signal_pending() in vm_area_alloc_pages() > if __GFP_NOFAIL set. > > Fixes: 9376130c390a ("mm/vmalloc: add support for __GFP_NOFAIL") > Cc: > Acked-by: Michal Hocko > Suggested-by: Barry Song <21cnbao@gmail.com> > Reported-by: Oven > Signed-off-by: Hailong.Liu > --- > mm/vmalloc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 125427cbdb87..109272b8ee2e 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3492,7 +3492,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > { > unsigned int nr_allocated = 0; > gfp_t alloc_gfp = gfp; > - bool nofail = false; > + bool nofail = gfp & __GFP_NOFAIL; > struct page *page; > int i; > > @@ -3549,12 +3549,11 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > * and compaction etc. > */ > alloc_gfp &= ~__GFP_NOFAIL; > - nofail = true; > } > > /* High-order pages or fallback path if "bulk" fails. */ > while (nr_allocated < nr_pages) { > - if (fatal_signal_pending(current)) > + if (!nofail && fatal_signal_pending(current)) > break; > > if (nid == NUMA_NO_NODE) > --- > Changes since RFC v1 [1]: > - Remove RFC tag > - Add fixes, per Michal > - Use nofail instead of gfp & __GFP_NOFAIL, per Barry & Michal > - Modify commit log, per Barry > > [1] https://lore.kernel.org/all/20240508125808.28882-1-hailong.liu@oppo.com/ > > This issue occurred during OPLUS KASAN TEST. Below is part of the log > -> oom-killer sends signal to process > [65731.222840] [ T1308] oom-kill:constraint=CONSTRAINT_NONE,nodemask=(null),cpuset=/,mems_allowed=0,global_oom,task_memcg=/apps/uid_10198,task=gs.intelligence,pid=32454,uid=10198 > > [65731.259685] [T32454] Call trace: > [65731.259698] [T32454] dump_backtrace+0xf4/0x118 > [65731.259734] [T32454] show_stack+0x18/0x24 > [65731.259756] [T32454] dump_stack_lvl+0x60/0x7c > [65731.259781] [T32454] dump_stack+0x18/0x38 > [65731.259800] [T32454] mrdump_common_die+0x250/0x39c [mrdump] > [65731.259936] [T32454] ipanic_die+0x20/0x34 [mrdump] > [65731.260019] [T32454] atomic_notifier_call_chain+0xb4/0xfc > [65731.260047] [T32454] notify_die+0x114/0x198 > [65731.260073] [T32454] die+0xf4/0x5b4 > [65731.260098] [T32454] die_kernel_fault+0x80/0x98 > [65731.260124] [T32454] __do_kernel_fault+0x160/0x2a8 > [65731.260146] [T32454] do_bad_area+0x68/0x148 > [65731.260174] [T32454] do_mem_abort+0x151c/0x1b34 > [65731.260204] [T32454] el1_abort+0x3c/0x5c > [65731.260227] [T32454] el1h_64_sync_handler+0x54/0x90 > [65731.260248] [T32454] el1h_64_sync+0x68/0x6c > > [65731.260269] [T32454] z_erofs_decompress_queue+0x7f0/0x2258 > --> be->decompressed_pages = kvcalloc(be->nr_pages, sizeof(struct page *), GFP_KERNEL | __GFP_NOFAIL); > kernel panic by NULL pointer dereference. > erofs assume kvmalloc with __GFP_NOFAIL never return NULL. > [65731.260293] [T32454] z_erofs_runqueue+0xf30/0x104c > [65731.260314] [T32454] z_erofs_readahead+0x4f0/0x968 > [65731.260339] [T32454] read_pages+0x170/0xadc > [65731.260364] [T32454] page_cache_ra_unbounded+0x874/0xf30 > [65731.260388] [T32454] page_cache_ra_order+0x24c/0x714 > [65731.260411] [T32454] filemap_fault+0xbf0/0x1a74 > [65731.260437] [T32454] __do_fault+0xd0/0x33c > [65731.260462] [T32454] handle_mm_fault+0xf74/0x3fe0 > [65731.260486] [T32454] do_mem_abort+0x54c/0x1b34 > [65731.260509] [T32454] el0_da+0x44/0x94 > [65731.260531] [T32454] el0t_64_sync_handler+0x98/0xb4 > [65731.260553] [T32454] el0t_64_sync+0x198/0x19c > -- > 2.34.1 > Makes sense to me: Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki