From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2502DC25B10 for ; Fri, 10 May 2024 05:54:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 599096B0083; Fri, 10 May 2024 01:54:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 548F26B0087; Fri, 10 May 2024 01:54:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E9436B0088; Fri, 10 May 2024 01:54:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1A6386B0083 for ; Fri, 10 May 2024 01:54:02 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 82E5C1A1686 for ; Fri, 10 May 2024 05:54:01 +0000 (UTC) X-FDA: 82101420282.25.FA083B6 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by imf28.hostedemail.com (Postfix) with ESMTP id 57C61C0004 for ; Fri, 10 May 2024 05:53:59 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=canonical.com header.s=20210705 header.b=fYKmEbmi; dmarc=pass (policy=none) header.from=canonical.com; spf=pass (imf28.hostedemail.com: domain of andrea.righi@canonical.com designates 185.125.188.123 as permitted sender) smtp.mailfrom=andrea.righi@canonical.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715320439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pb53mmGBdA39Om/S6gifWUIT/OZjQtmNrFO1eNmJ+LA=; b=a87flHAAOsk3Y071NY/zCIhgkMHGiJv4Obx1SCmzbbEQR0NsknNNmpGZH0qC1po4a/V0lL v9368jMOQSoO3LNDss0DDhbHmeo6ABC5w/3Rm0DOwqqJoLCiJWN4JUKSYb1gQJldEV4oet 90lDsNXT/lDlwyf4qODKh8A/NiBHxVM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=canonical.com header.s=20210705 header.b=fYKmEbmi; dmarc=pass (policy=none) header.from=canonical.com; spf=pass (imf28.hostedemail.com: domain of andrea.righi@canonical.com designates 185.125.188.123 as permitted sender) smtp.mailfrom=andrea.righi@canonical.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715320439; a=rsa-sha256; cv=none; b=0ffLY3ThJZ2undJv2BuW8htEN55eDXJAxADA9Vdf/MiMTR/rYqViGs9n3Jbbchisrb+Mam PkSKI3T8M4MUXnBJgVl6k9evuF5mfnqbJuUDcBSVvd6ETCKPNLLHMk+C1ruZ7GlSBpMhVv Exrv1q5sxoUP0XW6XFMpERC4jnbDASA= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 0E0BC3FB6E for ; Fri, 10 May 2024 05:53:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1715320436; bh=pb53mmGBdA39Om/S6gifWUIT/OZjQtmNrFO1eNmJ+LA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=fYKmEbmiIl/QYEl2LM6D8CTePtubMer22wic+ML1cb3nKdSWAAPSsqTcegQxzs2Cb 23Or3R2bYzOvyfIIq4Kyq8jNyJMW2RQ4yy9GVSTE8p1rHCxhwUS/cSbwcQ/qT2+LmM 6Rsn78P17JPKF95jbyYJdTI0NhUQyQJ9tY1dY/+K5k4xbL6IjfBUCQNjR6nXuleSw9 z+f5ZIT/P73b7n2H9mOtfd1thgNM5C7uFqEzhxdT/JkdI1LEGF872CYytRMk2FEUGT NR8uBfplYwGarW2xCPREWbp5/E8jgehgbEkI7fDocz1GVywFYIz/I7gUmP3lvoxsbr kjyx21GoyOYQw== Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-572ef3eb368so635638a12.1 for ; Thu, 09 May 2024 22:53:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715320435; x=1715925235; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pb53mmGBdA39Om/S6gifWUIT/OZjQtmNrFO1eNmJ+LA=; b=vZ5fOJ7BnpJ0sl66WOX9S4WsIoRxJNqax7cglcx1i+kz5Cy9u2mUTYSNd6TpEGMoAd 33W58FgQEmMRxbWRzCplWsjv1dMQQjojOMUB8UmMZfApKsxjI8AmIqbCp6OUmzeLY0dJ IpGFgxmrRBkqCWvIb/BdEofibF7YPWiRLEDOSGTPgZX16/bolGZc0dY9EeELJwpR5WVT h/dbkiIWAYKXojMDO+/ZVWPQbPuUX53HNuDC/ULGPrscvgSIr2VKpxpH3P/xuDZZ/Ri7 EpdTYA2S/vokv9vn2o2IDlqZ+QATQWgQDvkugJp6f5wYUdC+6yljOyIX7eKd8bjeX7/0 0wSQ== X-Forwarded-Encrypted: i=1; AJvYcCUNnDG2+qRkBARi8WDixToMFoNlax0ZqqcO7I/GXQ4siY6r+isQho8Y9scZx0t55HF3hQQWKXdlObszTPK1ZAbsfYY= X-Gm-Message-State: AOJu0Yzn+wDMic203tz9eKWz0pgAfsbbTRJhfz/NMmAh8bgZbo22Es7m 3uIlm5wveFugoi+reMOBiLXRWu6TqzsZ1FH1F2nSSqE1BkrN5U//Swl4EaV7NTPb2o77cUBUtJ3 T8RSYX9VM9IOLYEiigHHQtP8yYilFot8CqiLcX+aKahdZYqJa30ZrJBphi1X7Dl3G X-Received: by 2002:a50:bb05:0:b0:572:5f28:1f25 with SMTP id 4fb4d7f45d1cf-5734d5c1692mr1161726a12.7.1715320435058; Thu, 09 May 2024 22:53:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEUERLBxoc5gVqjALyHDp2f85+2hPeKHWBMU3eKKrua9AkiVLI6CvgwDj1X1kdppOmcHMa0VA== X-Received: by 2002:a50:bb05:0:b0:572:5f28:1f25 with SMTP id 4fb4d7f45d1cf-5734d5c1692mr1161698a12.7.1715320434315; Thu, 09 May 2024 22:53:54 -0700 (PDT) Received: from localhost (host-82-49-69-7.retail.telecomitalia.it. [82.49.69.7]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5733c3229b5sm1436042a12.79.2024.05.09.22.53.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 22:53:53 -0700 (PDT) Date: Fri, 10 May 2024 07:53:52 +0200 From: Andrea Righi To: David Howells Cc: Jeff Layton , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Eric Van Hensbergen , Ilya Dryomov , Christian Brauner , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Latchesar Ionkov , Christian Schoenebeck Subject: Re: [PATCH v5 40/40] 9p: Use netfslib read/write_iter Message-ID: References: <20231221132400.1601991-1-dhowells@redhat.com> <20231221132400.1601991-41-dhowells@redhat.com> <1567252.1715290417@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1567252.1715290417@warthog.procyon.org.uk> X-Rspamd-Server: rspam01 X-Stat-Signature: tefqb1ged4zhigrx4qnmh1eqxh8jkdpp X-Rspam-User: X-Rspamd-Queue-Id: 57C61C0004 X-HE-Tag: 1715320439-58718 X-HE-Meta: U2FsdGVkX1/ftxTLYBUshqBfN4uUPvnTTBm5qT9LyP20N5YFnjM5agauD0zaJyeRPeFxw2YhIXA/65/7WZ9AQbRw7y2foFOx4RpOXZ36r9Fw8mSdQkWekZbh3faqlnAeWNMFyZEJxRDXVlT17xCVSL+DZ2WGCpoDWWL6dbVmfRj5Yn5r6OXCM3Ja0FP2cAvqUmX6l8SWdszrDh23Zg7RO0FBuIgMHNyzGueTDCuGkzj9VjmES21HL4lCfPCtDi821wnA/UOK9HdSFapbGNKJrIs4VNLcnamDPdKIFGOnD3FXR00HYww52sUDjZ420+hLelkzfxv9sn+AA/iIa9MVU6tvkfRinAhaQaWXaU9Cea82RQ3aXA/QFJ4RvrB2xEtpFwZdi1fGhTUCTt5Ur/9qLK2T/o+y6eJj1KUhBjpw3hqEFHmIFy6RDcmHugduMFf+8+mpxPyUBVRDH5YvrpmhhnIbxVDgxFArX3O8nfcHJgqO07bqfTNIWDWTHu3LCbkHSaOnhfpLh5MVnmgKDFVzIjEnUHq2tkyXw1M5oXPHrFgSXaMtVcdr8VWJN4LjZzjyW5vKm1VWFY2se/Aj4pVZzS2oMRfCSFmagzesZTZNK6ppN1VXaARuiAyyTFDivOmizGw9ccshr5QNjvVzYdZq9ti7i25qSy4SHkHEBcvgQRWjKfzd3aan8lOWEEmOIVIz+W3W3E/ThXOQvkiCfmGvXyQyrhcrxXrHlvNlHf7GcPB9GiBq91RRR9kc8YO9OrPB4+8Sb6OPZCJB21G12gg4KQxcFiFnfgF0Ybxo5HHaZbD1Ed77/o5hFN7dttfOnxOsC1Pg5ioZcJuALr+m1jc634Lq1xF9kSyNjH++RQqBSbu9vV5KSqWAAUxckck3Sam7FBsgUdSofSz/22gXh7oWKmQ9xROTlWVW1pudpan3fbHxCU50FrdU5E5pttVHH4+P5q5DK84T/7imfPOIRkC wOciGxWU aazUDpbmdjLSK/hYkVIkm4cD9TiJcIlOiODT9o/9D+2jhnhX5YeLAERTfwjWBgzitthwlEgZWK52XskAsXz/PV1JkW2WTJanvlOELDWywqnyUgQVDHddtsIHDh0UJBdx0PEcUT8YH2Y7lwQewkVIGIfq9NO1qhoepSCWDFdpWMkD1TkeE/xYNNQ5j4Fg5ck3UQ0ATgrgLTjU4ygr+8cBvlAa1euJC7WQdLCUKxera3Px29UbWGTNVf/PQNmvzht1XfObO5OxiEDMMzBBtZ+cR1vM0lVjidH4EHw3dmuPftSqXOew+dMNT7gcStMbMCrhB2//vSzTuz/sAO6KBqnkXrDor0xjG1RVkOx7Vw421Izzrn/AnuLNLpEibD7JKGnr20zsA9l/zJHGP+LUWrw7i5sNDP8AEDuHt/FxXf4Yyq4Ek29inWSB2MH+3Z4GGZND+XAP2jqfItmRDXu7Gs2MQPNXmspHH57zOoD6ej/8r9bBc4545psGo5wV3QuGhELLX0Mid4pqEGDt+QfodNLBPCuXKvw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 09, 2024 at 10:33:37PM +0100, David Howells wrote: > Andrea Righi wrote: > > > On Thu, Dec 21, 2023 at 01:23:35PM +0000, David Howells wrote: > > > Use netfslib's read and write iteration helpers, allowing netfslib to take > > > over the management of the page cache for 9p files and to manage local disk > > > caching. In particular, this eliminates write_begin, write_end, writepage > > > and all mentions of struct page and struct folio from 9p. > > > > > > Note that netfslib now offers the possibility of write-through caching if > > > that is desirable for 9p: just set the NETFS_ICTX_WRITETHROUGH flag in > > > v9inode->netfs.flags in v9fs_set_netfs_context(). > > > > > > Note also this is untested as I can't get ganesha.nfsd to correctly parse > > > the config to turn on 9p support. > > > > It looks like this patch has introduced a regression with autopkgtest, > > see: https://bugs.launchpad.net/bugs/2056461 > > > > I haven't looked at the details yet, I just did some bisecting and > > apparently reverting this one seems to fix the problem. > > > > Let me know if you want me to test something in particular or if you > > already have a potential fix. Otherwise I'll take a look. > > Do you have a reproducer? > > I'll be at LSF next week, so if I can't fix it tomorrow, I won't be able to > poke at it until after that. > > David The only reproducer that I have at the moment is the autopkgtest command mentioned in the bug, that is a bit convoluted, I'll try to see if I can better isolate the problem and find a simpler reproducer, but I'll also be travelling next week to a Canonical event. At the moment I'll temporarily revert the commit (that seems to prevent the issue from happening) and I'll keep you posted if I find something. Thanks, -Andrea