From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A6C3C10F1A for ; Thu, 9 May 2024 17:15:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CFBA6B007B; Thu, 9 May 2024 13:15:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0803F6B0082; Thu, 9 May 2024 13:15:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E620B6B0083; Thu, 9 May 2024 13:15:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C7D9A6B007B for ; Thu, 9 May 2024 13:15:56 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 313AC1C0106 for ; Thu, 9 May 2024 17:15:56 +0000 (UTC) X-FDA: 82099509912.28.AD8E4E1 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by imf30.hostedemail.com (Postfix) with ESMTP id CE47C8001E for ; Thu, 9 May 2024 17:15:53 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=canonical.com header.s=20210705 header.b=YVtR6Iqe; spf=pass (imf30.hostedemail.com: domain of andrea.righi@canonical.com designates 185.125.188.123 as permitted sender) smtp.mailfrom=andrea.righi@canonical.com; dmarc=pass (policy=none) header.from=canonical.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715274954; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R13CNUyH1MbzjMY2CalRPAAS/uvh6wjQHgeABBOaJzE=; b=M4vOd04PW5Cv65vGr2UEMJTwizve+wGtYviigxDa4KR3YSf7q5aSn4Rm9VY5fYiE/vvVw0 itf1FbtXa2Um3lrQ7Uf/qqOW9rSf/IioU5aLAQrEZXAkHPWlyIFGHerAhh8UPrJgwuu5EQ 6k/+PQhXWwFo0TifcMcufApv4Hxkl+o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715274954; a=rsa-sha256; cv=none; b=LPdjj/wjQPB26upDK58mMefOMNNJHyLuifMV9wZ5AywwPQOe3sTd+bwqJasHl7OF2yw94f hfrXF2sZsLsmg3xQ/MgAfkG3N6a441hkE3vgMq84Jyi0tZGa3SR+5yFpmSrPEIVj9qrioB 1AJj+QWOeo8I+n4faDQlzwhOUwCf2lU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=canonical.com header.s=20210705 header.b=YVtR6Iqe; spf=pass (imf30.hostedemail.com: domain of andrea.righi@canonical.com designates 185.125.188.123 as permitted sender) smtp.mailfrom=andrea.righi@canonical.com; dmarc=pass (policy=none) header.from=canonical.com Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 009A83F363 for ; Thu, 9 May 2024 17:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1715274952; bh=R13CNUyH1MbzjMY2CalRPAAS/uvh6wjQHgeABBOaJzE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=YVtR6IqeLoPH0zBHnx2///dvDkhEGcLUo1C2bNGDQni0fO79q/HiD4ThJpPJ88o9x iupORWv97jiImLrS9Ek2iUPsKQHJV9VZ9GFxJEDVPuWJhNW0iYMFR0r6JjfIUK+Eoc oascsOHuZf7I4bSkf7iGaed4mGJAz0Jnj6ddFRc34gCxgSGU5oCoFbpTcAn/1yN8Wh hSGMZI/2eGCrhtAh6gaiqe4gX+mVpP0hBiQi7Ql8vXWdtcdgUFHzJcpGtBl+waKkNF WLif5Yh171ijMJmKERRCkslfNIOOH8EoOaSVS7fQlqqBxm3TqHSjYGZlU0abofAeNw BDgaKxa5UaFwA== Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-34d7a7585d7so589454f8f.2 for ; Thu, 09 May 2024 10:15:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715274951; x=1715879751; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R13CNUyH1MbzjMY2CalRPAAS/uvh6wjQHgeABBOaJzE=; b=KdGMZ9OZWJQ9sE0mU1vL6WpEzjF2vrN6QeMYnaDZU17QUC7RriGBMV3STKUN7lxO17 vjLvxlFUWs3gfG0zfnq4zChns/vt73q9p7BYBB+Q2p/7HOtihlLtXgFeVMqvD3suGt1m tVd9fv46De1eTPQ9vcb5VEEQ22IRfZ1Xausi/Se3Tp3JZWg15ixix4mw5LtuVvUmIHIT 3HwDqDaL1idcP6iSL376FaYgmrdt2Uk0igo47xf2QLa93i1qtFdGA+N7h2v7CP9kbfR7 9ZU+mWLHyYAXVTOr1sNicfqnB1eLxpB4xww/XNccm605bk4kBIx5dTHR3fxAgLMF6uDw wJYQ== X-Forwarded-Encrypted: i=1; AJvYcCXNsjke/Ll7mVPciY5kqrqRCP6wfrhjKkRhSjmBfkgrQ31ciWFF081RyOo+hywgrrB6Q1slfWVJ9B2q2PYi5FP0NOA= X-Gm-Message-State: AOJu0YxXZstTh5DKK+5BIuH6YopFpyVMHjFT+QF1Tph8eFMBQlVmwGwj SM6IlTMarwGgxL5fAacJds8hbnkykt4Ma7HB77fYo9NS0NImNGbGruXFfY2lY4Jxf9mqgpEOoFV rAFj4mU28uGDTdSpGDJrfABP4ghU0xKTaXw/L9WMY12X6Dw7gDUyP8Ihyw0JXRywC X-Received: by 2002:a17:906:3849:b0:a59:b02a:90dc with SMTP id a640c23a62f3a-a5a2d66ac03mr15003566b.54.1715274930673; Thu, 09 May 2024 10:15:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHRId3ZK7jZnEUqxnKrbYMBDrOXsoSZ6C8TgHiChCG3zHZRXUk/mhnLLXZdmjv+NVtyVoseaw== X-Received: by 2002:a17:906:3849:b0:a59:b02a:90dc with SMTP id a640c23a62f3a-a5a2d66ac03mr15001366b.54.1715274929765; Thu, 09 May 2024 10:15:29 -0700 (PDT) Received: from localhost (host-82-49-69-7.retail.telecomitalia.it. [82.49.69.7]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a179c81bfsm93194566b.129.2024.05.09.10.15.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 10:15:29 -0700 (PDT) Date: Thu, 9 May 2024 19:15:27 +0200 From: Andrea Righi To: David Howells Cc: Jeff Layton , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Eric Van Hensbergen , Ilya Dryomov , Christian Brauner , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Latchesar Ionkov , Christian Schoenebeck Subject: Re: [PATCH v5 40/40] 9p: Use netfslib read/write_iter Message-ID: References: <20231221132400.1601991-1-dhowells@redhat.com> <20231221132400.1601991-41-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231221132400.1601991-41-dhowells@redhat.com> X-Rspam-User: X-Stat-Signature: s5tacbtjqxxo1y1sb1ym7gnm66m5zgef X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: CE47C8001E X-HE-Tag: 1715274953-725513 X-HE-Meta: U2FsdGVkX197SynTG+YQdf4sVT0EIu1AHYq7JB6G2dKj39AP4TGHdK8S84eHkzeW+4Rj68MR3QYRL/mruWEmaw/s9G0trMQSPSjAO/r15F52Y26NmR9mecK2B91P+6wvvBpPaDQzRmPTJDIa/XcneGeaUChXUnp61ofej254ZQeltLQ2bgKhFaEPMHdW9F5K44PJNKazEb6IMqq117siDj05kyPn9OVBBFBShy8DNwGq3Nm7hLzLicRWiIGV7PvcLuRZd4etAOujtiuKpMVC7MaQk1Puw3qDPpRiDAoOvs7O66IL1fbjPiEmtzgmgpkkE7WK9QaJhcd4XOH5mrFhBgMfoeYBFOlLg7e19iabkXIjeFWuLaTZIp/xKs2o+lDmZ38/HmkipoOtiG2MJ3oTe9dsOp1U4WcMBxGdjBjvZomy3cHp8HJqbdfpJkVRtinfsv00ImwzrpgaRN+MZZZ3MVayb5m9po/s/ZKc/LgWk/w7ZSZ7K+/DuCajM0js6zS7XdNDUAzDdnheevRe0K40IQmgVC7S6eguayCzl5jKYYnJkKXWCTrljiGLpVWFZG3VmqTKmeAzhe9jWkj+AL5G5I5MPIjLd7sWlPZHUrSCxI966lNWvgzYaJujPx45OWfnL8jjG14x58+IAx8hoY47+qCDRNCE6HsFZ/iM3HR81OeylcD4gIucdbXk3k+/jYiSFwtm7RS7O0cTHlbGjLrf5uUwxe+UWNGNnhIT2NNhzDRnPzWVyvKLWuOApryL5uEPSdF3gHrDK5xN6o9fBxndCbevwG+9uhl6fFtzQC3mEafBgRPTATd8YkOaoBRlqTmkTdndzuJJ6Nfo+61CdGPu875gJOMM8k7VSFhrk7q745kj6lOdOlsrUhmf3Y8ZaScdSELFsf4xkXft+WqccFckCi0b0kXY0K12wfO/ZAZmGDoibzdvF8GPxu/B7FAbnO19PEE/HqoBM0o1Ykb7m5c AupLWmdz nBvGuRRRB4g8I6bwIxGeLYqa8Ndz5P0XN+mz3UE86wNlaeuos9iWbR1f57rmYzAVSZznSyrrJ25nRmDhu7UanCJ28D6ffIbnmzw4hdfuqJQlr9AzkmaVrqqiidbPyL1dTcgeGBi6CYp+9OnNd705xHbV9qI12ccosHPCcKvazoXbcO9jQwnWxUqBPnznkiksoGy83Yl+170KDT/W/oyRSE7Z0ZgtMxatI2CYDxMW4RFCXxNvD4VRsL9b3aaWbCD6tncaLh6B60G1EqiyGauxD+l4gz1+RccyHnch/9/HvPMssi6CDns61p3RAMY9gzCY0RbUPP40YHm7Q1S1DXcE8nzl5zDLF2mOs0FB+A2/Zl2vFNMZnUXshW6RaihZ+aGzK+Wb3KBPmVLTeafPOsqHAvw/svy2ahMTnYRMgDDESlGpsLN28Y2JVVghjjlI4ENhllouJH/391OoxW95PH8lVlUq+tA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 21, 2023 at 01:23:35PM +0000, David Howells wrote: > Use netfslib's read and write iteration helpers, allowing netfslib to take > over the management of the page cache for 9p files and to manage local disk > caching. In particular, this eliminates write_begin, write_end, writepage > and all mentions of struct page and struct folio from 9p. > > Note that netfslib now offers the possibility of write-through caching if > that is desirable for 9p: just set the NETFS_ICTX_WRITETHROUGH flag in > v9inode->netfs.flags in v9fs_set_netfs_context(). > > Note also this is untested as I can't get ganesha.nfsd to correctly parse > the config to turn on 9p support. It looks like this patch has introduced a regression with autopkgtest, see: https://bugs.launchpad.net/bugs/2056461 I haven't looked at the details yet, I just did some bisecting and apparently reverting this one seems to fix the problem. Let me know if you want me to test something in particular or if you already have a potential fix. Otherwise I'll take a look. Thanks, -Andrea