From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FEE8C04FFE for ; Sat, 11 May 2024 16:05:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1C276B0178; Sat, 11 May 2024 12:05:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CC8E6B0179; Sat, 11 May 2024 12:05:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BA886B017A; Sat, 11 May 2024 12:05:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6DCF36B0178 for ; Sat, 11 May 2024 12:05:22 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EB5544096E for ; Sat, 11 May 2024 16:05:21 +0000 (UTC) X-FDA: 82106589642.13.08A3653 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id EAEC240012 for ; Sat, 11 May 2024 16:05:18 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mAPpiOoT; dmarc=none; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715443520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UP0RQCFejEFweF1A8DNne68f64ZB2q8cOhlPulA5RN4=; b=GiwVr0cBmrztg7CgPVY0E+LqopP+VR0czJs0n655K0tGoH6WLnjEqFHzwxlcnrS7V5pq18 0HqyWhFgi4Jk3uqpEzBm6DRIESCWHOWTZYQyDxql6QGQqI7uK2wseTSn4BAxXQjNhEBQ1E pr1jtp6xxAapq+GCWMf5v2NHuRUcEDQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mAPpiOoT; dmarc=none; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715443520; a=rsa-sha256; cv=none; b=IULbiRLVW55i3wY93JKO7v5c52H7Uic4s86vXiqh90p7iXbKWpN+JX6Z2htxcoeTY8C94+ JVZ4jL9dmt5m5JHV5y7C2IAvBdb6SRxZUVxWX3YJe10+hVsRxuUTOaATPtMp39uy5d8HnP 2BZ1/xEbQ3zNfq5IX2b4N6x+xNFxI4U= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UP0RQCFejEFweF1A8DNne68f64ZB2q8cOhlPulA5RN4=; b=mAPpiOoTjjpni+zN7AOmjP1ID0 hZ7k4zVHEQiKs451Wv7kbbp7AKgp9dg3hHWuoaUkrb6Vdu4tB5sE2XMXdO5nPjo6T1sWiGqOLAH76 RP9GUC59c09FAIz8z5/5KuM+ySXT0YZUBG7C94I8xNIoyjqqlt/pjI2sX3QH5mdx1py8voMQitv+G kMPx7rLzN7grWGrr5DRm66uNZTmUDOl/iFoF1bWArS60GDBF2hlT0NBFg2y7Sp8Y/1ZGJvsckFgQ+ 6cHDbAoVQfbJZCD95Z5GJYe1qxeszJEmtfrgR01Nid3Wuh0F583xKVP/loZSL8rg+mhuoW8UKC2EB +DZEKMmQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5pDm-00000005cvF-0DFn; Sat, 11 May 2024 16:05:14 +0000 Date: Sat, 11 May 2024 17:05:13 +0100 From: Matthew Wilcox To: xu.xin16@zte.com.cn Cc: akpm@linux-foundation.org, david@redhat.com, shy828301@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: =?iso-8859-1?Q?=A0=5BPATCH_linux-next?= =?iso-8859-1?Q?=5D_mm=2Fhuge=5Fmemory=3A_remove_redundant_locking_when_pa?= =?iso-8859-1?Q?rsing=A0THP?= sysfs input Message-ID: References: <20240511144048767fdB7EqYoMHEw6A5b6FrXM@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240511144048767fdB7EqYoMHEw6A5b6FrXM@zte.com.cn> X-Rspamd-Queue-Id: EAEC240012 X-Stat-Signature: q9zxg6z1iu3153t4r1ubkhw95f3aekyq X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1715443518-137570 X-HE-Meta: U2FsdGVkX1/JvEm5dn4c+HQXhCwGpmNYyRS498kdR9FnNt3nV/wxMYg4I+6puft2DfRLDxUmvBtMFez6nBzovTqYFUZmuiOnN06Z7pqc2ucf45riJEsRc9gySq4+heAMeNx8nYS9PpdS69asfScdS5KmHugVJxQYcljJxpsSJP0zTgH8sqASxrXqWGRSQu7TgBeFDsUXd8jVzaMi6+thVopa2PkQMj6YsuawUjHIB6Rcy9qvuXEcyg06tfG5vqeSF00vsJGGUkjsyd5JOeCCAleCX7HP9MX8W6isF4AeNDa8SdiTKXkZ3sjDYKwo3Eh99SR5j8cgNwV9dp+hKLQnsG0xFiQ85bKMjgKe8vVrMup8HloLFZj8RlBFdTKCrwc1DjnDZGZvX5DVZNVbO8MgDAA+EkojOj/8+h0LRV2ef4X04AyVX5F5X2sCJNaf2NZ29ftWMAscFwUviLwuvIEq+RCMX+nHUQngQpvTAjzld+JYfPyXfUIuwq/3bnHZScCnfuzuIv9uh0wFlDeOCPjbLe4eJE6Tfuq9zOjMZFY5W593irNl00EPgbkBHRzR/7yNF59wQUrrvXd6Dm0Mmigwm3hLJOXM3pkhx5fGlZUgTq5Ekns6NFJrR0QRNejs7MmXKY/4VeWoqwsrCAyJnr14hVzKug98ZToe4eMNiCZakilouUEiyCWHjiTIZKJz30/uzkfiblYV7aK4oKIvggfj+ID2RDGf6OvjwS7yB18o+7/1EqwpUXW6dtBeauevITfW0zQ9eQFGKwpAYk6nmvg9FTAFadUX+XEz0zhSmW66BFIp/f8g0Z6sicP/H/nacoSLef4M9wrwRrNjwqzGjs+uS0wfmQaXnvkDaQiTsWp1dQITt4CNZAw568Q3KoTriccK3FgHeUjIgG5cPYIybfDJ+ZSWVxhjdnANaS0Rpe/f8BYjqVx4trkTi71wyk4ORKFZEm6IO1swRLZxc5a+z+f /Mtep5aL Wd7J53vlPrrqAGmIf/UcqbyXWuf9EhJsBrGGLbHYCXymzwXdDNAM+69MuLsKT5oTPTVtUkHl3bsChda6EPC6JFZxEP/TqiQVrNjvBkuNgSUb7/eAjMdAvZKNgKIvvnlz7wnoVQ6hiRSJW13DOErwCwklRLZLxe6FDihPAZQm/R7rOkBcgq8KTXYB//fnl2VXB0+2EVdEglg3f+kr5hpY0QF3RszDAekT2Xb51YadlG5vZIj9plsX6C9WmHzNsZYzKBPN76TIeZWhDltM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, May 11, 2024 at 02:40:48PM +0800, xu.xin16@zte.com.cn wrote: > From: Ran Xiaokai > > Since sysfs_streq() only performs a simple memory comparison operation > and will not introduce any sleepable operation, So there is no > need to drop the lock when parsing input. Remove redundant lock > and unlock operations to make code cleaner. i disagree that it makes the code cleaner.