From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5383C4345F for ; Sat, 27 Apr 2024 03:45:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E73B76B0083; Fri, 26 Apr 2024 23:45:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E249E6B0085; Fri, 26 Apr 2024 23:45:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEB046B0087; Fri, 26 Apr 2024 23:45:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AF2A66B0083 for ; Fri, 26 Apr 2024 23:45:28 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 52964A0744 for ; Sat, 27 Apr 2024 03:45:28 +0000 (UTC) X-FDA: 82053921936.11.ABD0A7E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id BAD3D4000D for ; Sat, 27 Apr 2024 03:45:26 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=S+XZK6UA; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714189526; a=rsa-sha256; cv=none; b=i11zfIn3zbi4EBY5QR72DymFJQjsbpzgdXBgnpp/jep+RXwXoiP9kH6pq56nb0XVMLRpBv z7opGv2sTfhdXT7ghB6JMRprzizc+2S8SgYVqph6vzhW1zBQ/ireytYqmogaTa+3z9hEnY MMRcYMvxznx8+VQPpEZZB2ewRhm2mCk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=S+XZK6UA; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714189526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xytt09ehZkVciiGTF51V/MgHViGTA0VrPIBz8JEclm8=; b=7f07toOtamRnbh98OXgaxLYsIyf0Guh6wF72C3LRzCG9MS6v5938LTYhL3mqtOJTOh8+uz 3HZ9xjYNX8bKsT6zU7jG23ZV/4h5d7dUslu1+5DejSYL/kdXF/CZxi+GM/1ZAFp6WSniVb L0T9chfmUqMLZhWGkHC2kTMJqewvv/g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Xytt09ehZkVciiGTF51V/MgHViGTA0VrPIBz8JEclm8=; b=S+XZK6UAd2DenRn1uXK/SBBYE+ J9aqmLhm0sg8M1NB+httPNKe0bQCwWzRve0VvWJUq4prBMtdPZoRSuc8s8c4qpmS+RFQ4c94CFEVc apuZKnDExQumM0PF6XBBtVP93P3BtjPEff2AD89XlvKxboBujcgQ+TtpQKxSR8+TeKr1Aaar3JfBQ XfAdDaRAE5HuPj58FFnvo/CdiQLB86wov9bOUW/c/5cyyrz3/XlvOQQVutjS9dMYHTHvbsh1QFZFW e0GXkQVJClbUCKlMDFSXorlLPc06jpugY0MIHh8CZ55buHeRVxwrd3xcy0oljC8Jae8uNwcqaP0DJ lvm2Be1w==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0Z02-00000006cHM-1SC7; Sat, 27 Apr 2024 03:45:18 +0000 Date: Sat, 27 Apr 2024 04:45:18 +0100 From: Matthew Wilcox To: Andrew Morton Cc: Kefeng Wang , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, zhangyi Subject: Re: [PATCH] mm: use memalloc_nofs_save() in page_cache_ra_order() Message-ID: References: <20240426112938.124740-1-wangkefeng.wang@huawei.com> <20240426114905.216e3d41b97f9a59be26999e@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240426114905.216e3d41b97f9a59be26999e@linux-foundation.org> X-Stat-Signature: n3wdxh995jswcp5eyyxf373rnjco4eua X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BAD3D4000D X-HE-Tag: 1714189526-985453 X-HE-Meta: U2FsdGVkX19ezhjfJZVqOR6ELVix9oo03Jithg7adwOrOpYBSsvJzZN0WsR7BA1RnFSkU+79AVEK1Ftu707SQsALJZDWouklEfgW4o4dGqXWDLxzY0MRdhDdpO2C+kP3dLi6mc43zRUKTCVcYhlpPgSaSaSOQamXRMZABmRruUwobzurtnec8XTB+s2DmpeE9waKk/9Dsf3zHBzLe6C5lgJmwFoeXCQSYVrDXxrEoDK8oNaigO38OoBp/Ymc3EGrrxCy+t6Ta2wA7xr8hAbre9UcZPn7jp0J8I6HJ2T95ykQe9kRVyfiCBiru8Pl/tOzXQHmeZO37jnlDSiCVSEUvAMFp04V23Y4RlPIt0eM/GCQpJ3vNDlF7s+ZGUSLDJxdvMvpu1cgfdGABFyg0Ic0hdSZFYPyxwFoZ03BRSxd++GbM8n2+v3ewm9j8jjnUA0mW0oag4lwiajVIVASBQYUEqT8OKR2Abq7LhV10ZdU6vk2ztoBGS+mHnmenbLSOm55L8uknTFlwhHFs8Jbwqx2u5+Yqum3QZSKvvX+uhk6IAucoCzLBUxf6JVKlzUqynfM7px8b7HL/nuBDvRVe4qTe5k/ASND7XFFnaZ4bdF1bQ0Gw1kOkn9p+T1OdgDN5W4ANkIHtCCElUIymV586uUBLlYy+NzPNnW3oSGgEP3J43e2IdW/oDYfzZgnyKZ/hYnmjWIw+38z0OYbzZpPU/YmWDis+Pmli0A3MtDIuxSnuaLrEFxu/YoJVciVWBwP4TcqBiHUgw2BFm6Ipu/JoeMUkeCIDcSf5rrIVikbFMPaSiVSCSMy74HwNu5M0cJaUD9h7gTWbvWVPEAgmlJwb6qu6Bpmd1pzeWkzgnxV/rGzyOR0m2ppezOWWNLUCJS9VJHkqWR1O8gvnRtGBx14bMK3RcMR2csdkZNHQP5iG0prJ6BrlGydKXVvyC6RkStOzUCNjcYdz9ad65IEUyIuym9 XB1sAWVb dgv9VG4ZoYweO9/4RB4PJxEaUImuRTvxOKzzfnT52zQSvarghq/GopDH0nev5HDoBnXYFJMcAnj81n7KUmaAu0k1a17zOXM4/hRBXMADkXtbOn2YbfFp4N9aSYkzvd+Zo1NY5Y0X4xSKV2F8UlslkeSzZ/U0fcqfieHrKzhI6KCfx1d7QXgxcwJ3A7evAsxKM1pSvCcV1fcNOVu8KPIj+RxZpdw0vHVbF1IwM02VU/Q8tZOj+6CmGn7Y+xOgp2QCgntSs3vzIVaZmad+7o3VX+yx4YdZwlXw8Zslq0puP7lcECf6KMTEDmy1kHP3SWIu0NsUb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 26, 2024 at 11:49:05AM -0700, Andrew Morton wrote: > On Fri, 26 Apr 2024 19:29:38 +0800 Kefeng Wang wrote: > > io_schedule+0x24/0xa0 > > __folio_lock+0x130/0x300 > > migrate_pages_batch+0x378/0x918 > > migrate_pages+0x350/0x700 > > compact_zone+0x63c/0xb38 > > compact_zone_order+0xc0/0x118 > > try_to_compact_pages+0xb0/0x280 > > __alloc_pages_direct_compact+0x98/0x248 > > __alloc_pages+0x510/0x1110 > > alloc_pages+0x9c/0x130 > > folio_alloc+0x20/0x78 > > filemap_alloc_folio+0x8c/0x1b0 > > page_cache_ra_order+0x174/0x308 > > ondemand_readahead+0x1c8/0x2b8 > > I'm thinking > > Fixes: 793917d997df ("mm/readahead: Add large folio readahead") > Cc: stable I think it goes back earlier than that. https://lore.kernel.org/linux-mm/20200128060304.GA6615@bombadil.infradead.org/ details how it can happen with the old readpages code. It's just easier to hit now.