From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B105C4345F for ; Fri, 26 Apr 2024 14:52:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 951606B0098; Fri, 26 Apr 2024 10:52:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FEE56B0096; Fri, 26 Apr 2024 10:52:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EDE16B0098; Fri, 26 Apr 2024 10:52:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 609056B0088 for ; Fri, 26 Apr 2024 10:52:33 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 06BC8141425 for ; Fri, 26 Apr 2024 14:52:33 +0000 (UTC) X-FDA: 82051974186.14.A491299 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 5923DC0015 for ; Fri, 26 Apr 2024 14:52:31 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714143151; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hynjTkENm2DySgIcF9ajnI9XKLg30GKuurwRdYjoM9Q=; b=bLwSTNLRqofhd7FmXDCtaHcp+htCzNkA2uQ/aPnCqEp4VRaZiSXDnQylxZ48nhgIoIUKJM R1p+9nunUzAndGmOZAjLlm2IkuguVYFRHBa3JXU7sR43bqdDaGqPTAcn4wNlDrT1eFrW2i 1qXVRIE3NeWA5I7Ad4ZqASayH9ua9XM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714143151; a=rsa-sha256; cv=none; b=bh+CBil/HQjp/4ykvqXyI/ZSzsgDLb9Cj0Yl8jlFrH+4Rws+LjtTUWgCM2BrfuFB7y5Cm+ 6TLs66EQ1LaYhqsVdtqonvgRd7zbJbXY61JobtbEvSNRicH/qbWlGl9/9taUFUBBEdsS96 n+oP4nZ/aWuzSaxfst8yB0suX4JL7b0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 72BD062087; Fri, 26 Apr 2024 14:52:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1989DC113CD; Fri, 26 Apr 2024 14:52:26 +0000 (UTC) Date: Fri, 26 Apr 2024 15:52:24 +0100 From: Catalin Marinas To: Kees Cook Cc: Suren Baghdasaryan , Kent Overstreet , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] mm/slub: Avoid recursive loop with kmemleak Message-ID: References: <20240425205516.work.220-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240425205516.work.220-kees@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5923DC0015 X-Stat-Signature: izf5wcw3qbucnk8xyngwiztciys1co8u X-HE-Tag: 1714143151-44187 X-HE-Meta: U2FsdGVkX1+540CWBDr3e9pkXKLNzjcZXvrhRwPXQ4DK5XRy0mFWOFj/tU9d+x6OS9S86cRgNfXtEe7twLOxC5MroV6eXKcdWpbyEwH39QdXPQiFbuy8/TcsldKYiSPY0wRvdaS49fTj46I/Gv9uaqb06haDacrccEKulu/RAnXci4yAsjvhrwM7uHQH70qJZIZK8elXSfooHvaNnHzVIhmsTqTe59XWgUJOCNJF9/chheCRzh5cYoRdOqpMJIkJBDU5D5FIWr/V7gDImonaD3RJVaajU0ra82/Ly4ex2rmvK8QA2wZ2f9qWX9LfDZHwm5UMdwFnK5e+EyYRsDM6kRhLwD6oXbFmUqwKO/VjNMyMmyUwpsC4BRD44Zav1x+1BgbYiRTw+HgKdf6YJexTSMt+ikDeuAuDb2LS5vPt1DQnJwx9Y807rdWchtGfDqrHqVdIY5gJMKn1094u+3jgsM7jy2mAZXf0pFYPVIHjMF639ifP0srBbLv49S1V1+0E0OjScSXnnKzdOdnpPMXHaIA8NR9+Eo+KgSjg+Mux2hfcfnw0lsKMvRb8uBtO5rZpQ9GNHP8/SY5/F7eqzpbHcCSo3dadZ5vwTXl9qUBWT5tHVQH87+mMzMrnMHVl5iYfki//kOOHACQKTBWfuQSt478KH5/deOMLutQux1Uf7bB4eDwemhGi9E6afxKctL+R3XfuU+mugAvSK/wKr2in/pZyQlG40CiujP5k6ZeTRJ0ef48x5B40M+L3drzHt1fLp9h7XtVlI1nQFXZ1RpncTS/QBe1WwcHUV6nPxnuec12p9TjP9zC54JWMLSmB+PUUQE9FHIOmN9VZd3DXhcRoRYUARmTPNv2Cm2iSdr2meKG2g+GG1eowWT3/E7H/Q6RU4WBIbF6VjdjHcyQG7/LtFXD7merkfFbtK9gIuETiNla9tXBKaSzVw4NHqxj3yUqaJ3WJWSFN+hiQu7ruhf2 iVFp/ygw f4pE6h/ywLLLIaM8FfUNHNOkWAoT65mZfEhh46fFwknNh8bzblHX8D06IEbUR6/gnfTLgouBVwVAn+lECdQ11KGT8Icwx02N4SEBfkUoRWZux+j42ZoBIWcwc4PDUM5fMBjW830Hm0O2mTO0XV12XknjpTSHYzgQ8Cmkfgg7X++SlpjlWEBB5L0NTY682wvud43ODPJHqwiwjByTmfgsDmWiwrAFOk/t6YAS81YE8oYBKJiBnhOYuBBespThhYNvwGrE1Go/T4tosZPxmc89AZFrYI34Q3pDOwSlbjhA954oTLK/d/5sQj082B5XRuBxuFXkchOt1A65W4R6eveJJEzuwvy0WZ5tJPondJvFDeGIHeMYaPRTHxQygIsUBg+t/pYQTxzSqTe9Fb3i21TK2OuOONwCRL61IeTQqdZ/lBiLcJxPf/ZpmvGHmepJ/QrZB4MPjgbslCXYFQ1cbPj3/4/YNid2TMXI/JFf63EHOkQgZmmLI+QvqpqhjRjTUrwJ6r7m7IEgDXFaQKHIA8pBsUIniaw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 01:55:23PM -0700, Kees Cook wrote: > The system will immediate fill up stack and crash when both > CONFIG_DEBUG_KMEMLEAK and CONFIG_MEM_ALLOC_PROFILING are enabled. > Avoid allocation tagging of kmemleak caches, otherwise recursive > allocation tracking occurs. > > Fixes: 279bb991b4d9 ("mm/slab: add allocation accounting into slab allocation and free paths") > Signed-off-by: Kees Cook For the kmemleak bits: Acked-by: Catalin Marinas