From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0E22C4345F for ; Thu, 25 Apr 2024 20:52:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D1036B0089; Thu, 25 Apr 2024 16:52:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 280C06B008A; Thu, 25 Apr 2024 16:52:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 170156B008C; Thu, 25 Apr 2024 16:52:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F3F216B0089 for ; Thu, 25 Apr 2024 16:52:02 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8175A81246 for ; Thu, 25 Apr 2024 20:52:02 +0000 (UTC) X-FDA: 82049251284.24.8017F97 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 99F5540020 for ; Thu, 25 Apr 2024 20:52:00 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bo9q4Ldl; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714078321; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hJnGKlFsEdNJjEDM4XvaGQLENUcY5zQAR7r5FdpupwQ=; b=jkvS2y23Lkwcw+YtTHEr3ExaKrnUf489ekj7nLF29FaEB3K/oAEXNFJm2iSOjCnz9kM1LZ wO8LCJhn2hXgU5jVbCjorVT8Ta2RtvcWPz82hPqJj2WDwdaFwGkZABAod6IwHaRN3Btvi5 SbySa6Yx4lCZbeXE0RIWUpAHHz/HcCk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bo9q4Ldl; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714078321; a=rsa-sha256; cv=none; b=uF/3qbdIpmetwkmpJ6LTgnQ/7VtIHIv2VTCOXVP4m0KoGpMj90f4ehzSlN59Ogj+1SvaEM O6AzHOMwc+O5RFthsCTUDXF2v0LG0WbzlVPcEXLatJE1BGbosdK9B0xHMzD6Ke1O7eBArt BjuPttf32sq+fmj/FhCcIrIekOmM8aA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hJnGKlFsEdNJjEDM4XvaGQLENUcY5zQAR7r5FdpupwQ=; b=bo9q4LdlCZLTTK/4zwHgn4i/vy 9RXgMPtRYqp2esiVVhqS/MCI4NYp7dVSgNn+uDvu6h5imZjgBh7pv9k2U0GpJu9pH7rh960TsMToE gNwAye2hN90NsgGPxN/p9AiiVjtZMZ0h3hhpbDQ8CR9TRtKQMj+3+pQTe5BNgqPgvTr19LyRNr9i7 JFVymDZ/7tEk9V5ErQGkkUjjdIFTC7zFgiC4IKqy6FPu9BaIBnEkxYt3bZDKqQ8k33qj8l0fU8mEi JDQ9hOMTmNHG5QY5brxdSzvQQWbdYMwh5StdPAiOGLBx0gNFDO7Ont9NVBcjAqZJ8f2rmoeTGrZ67 7JIJSbgA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s064S-00000003mfl-3Cuq; Thu, 25 Apr 2024 20:51:56 +0000 Date: Thu, 25 Apr 2024 21:51:56 +0100 From: Matthew Wilcox To: Kent Overstreet Cc: Kees Cook , Suren Baghdasaryan , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] alloc_tag: Tighten file permissions on /proc/allocinfo Message-ID: References: <20240425200844.work.184-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 99F5540020 X-Rspam-User: X-Stat-Signature: dnfr87z4pf4w17tcwexbdinss6r6qw7j X-HE-Tag: 1714078320-482095 X-HE-Meta: U2FsdGVkX182gkLgAQT9uZ7ARfaytK3ZNRmUPX5+mYPxgdhwtLAYGL4DaNA0Uvr5okRTzxWCKwWrplZhfz53EXQgEsah9THI6k+qKk1hQLpADpGKXoaQF/asY+OEsfXzg1DPkKcnapjjArW9ELJ7GdpjtjWBJ/xitpy8sz3ECBJGwjj/R3HmBBW/vhIxW7cb2dlVRJSjU4WDUflC3u3A/d8tQkrH/Oeq9/HLGwj6BupPBfcUfLora33LhaHG7z21wkRVmMacxUbZU+qOeYTMXDu3tC4b6Gre8lYxieT3rdxw2XfwfRm+IvyE9TFj7jYUz+frR1BGuWh5iWA/2dIYMVpYZM8nmQBHbrnVkqkCmDayRgcs2vhzv86PulDLWdgo0p5YaXHZ/YvWS5I7VNKEoLDa/+jMkECJ43tvxS5cGHZ13Tw35zbAZO3aPsG9bTJyV/rcX72XPFTJLBhZqIGAEcTe1n6YxdWAFDYK588FBxMqHCvg4f2bEtS0R1rWIeOdrXi5rU0uzkkbMbg7TvoR9SAczO3DRdrNBn4Yb2lWg4wxFMvWcgHFsFeph5j1I4Bf16ve2AIA5eU/oacz7DKavq/rVZaSp2Fu0oPK1k14IUACWPYIQriIY9BVAVVMSbTgw9kDrf8AUhJBFT6tg6CRvXHcP0INEwz9p3phRvR8GovS0cKdDTlizbt7k4h5cAQoVAiMIct4cRCDsYhZRmLZmE3QFiV7q0EIkka5pi+NiJYWfZtJMdTo1hnxI5yhwRW96u95FT8PsVEai4mQZXcbQvgQypI2Y1iH/HxEsDcONIoyqwM/dISSH/KcIkgm0B1XKp++ZALoAanrFRLfjFk6Kbgy85JF3QA/wqwcStNy04Ros0qzP0Sl+16WWC4uIsmS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 04:45:51PM -0400, Kent Overstreet wrote: > On Thu, Apr 25, 2024 at 01:08:50PM -0700, Kees Cook wrote: > > The /proc/allocinfo file exposes a tremendous about of information about > > kernel build details, memory allocations (obviously), and potentially > > even image layout (due to ordering). As this is intended to be consumed > > by system owners (like /proc/slabinfo), use the same file permissions as > > there: 0400. > > Err... > > The side effect of locking down more and more reporting interfaces is > that programs that consume those interfaces now have to run as root. sudo cat /proc/allocinfo | analyse-that-fie