From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE4CBC4345F for ; Thu, 25 Apr 2024 09:45:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 478786B009C; Thu, 25 Apr 2024 05:45:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 428236B009E; Thu, 25 Apr 2024 05:45:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F0116B00A0; Thu, 25 Apr 2024 05:45:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 11B2F6B009C for ; Thu, 25 Apr 2024 05:45:57 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 90C8016124C for ; Thu, 25 Apr 2024 09:45:56 +0000 (UTC) X-FDA: 82047572712.16.D9C7189 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by imf03.hostedemail.com (Postfix) with ESMTP id EB4A820007 for ; Thu, 25 Apr 2024 09:45:53 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="Gfkk/3Ke"; spf=none (imf03.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 198.175.65.12) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714038354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YJIX79srn5zLNS4QpoAmgAKa2gF9TBSrtBUb3SA1ahc=; b=x1R5/rGCjErgxFx9Hwn237pCjiKlLoFxfFs+3oltakbnCavyuXykPhNqdOhv+PIM6o7n4g n9asSEHs98OcAxIsYwamk4boPsvirCYGNyViltclMnVSe7igJ7TW8x2P6Iqc+XwbibY7uK yvQhaHV0Q/oU9WSO/kp8Xto9fgbdeSU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714038354; a=rsa-sha256; cv=none; b=6FbgojguQPY2t94IK47MQfFVHCEZguA+9+d6G25SgEKVKDO1t9v15pftOZCKy4WAAPyArA 3DY97Jeph+Ah2CsNtO5MG0ijClHpjQPddg4O6/ZZrMHAgGjPaSC9+tYiVO71lZZu0H2hxw 0jZm+zNOkfQNJV3uMdaTmAC2nuJKccY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="Gfkk/3Ke"; spf=none (imf03.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 198.175.65.12) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714038354; x=1745574354; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/oVl3AjiJEOEaBDGsZSThW66CADV4XIvv9sn85hqQlc=; b=Gfkk/3KeDcabc2Xo7H0zMbQ5NE0Pi/8P6HbPUcXlfac5Uh8f9muFaYWC /db2/fOm3rDl/JYKdu1i3XWxwpKvTmvK+jokSw3KitKIpzmaHuewBhc44 mGkJo30JxC3hL1Qjo3mB+M7+ctF4SgPqM7KvKFPknTgmHmK1/SRlmjKf8 2U+OvLHg9S3ezK9YFrTgbSJKEbDxRbzuqCtTllzpE+Bg2+3aXw485+MDH 42Q35HKcMpNF8AL3Q511fM+detbCszcAerLW6SNFyb2SVEG6H2AEGvBUC 0Ia7CCZin9r1ZvUZzMHORhpNfR6cULi1lTlLE2m/GkzCqWAdtOkCEgRqn g==; X-CSE-ConnectionGUID: sDVHoTIbTe6WYaQdvGWUWw== X-CSE-MsgGUID: 4/5TlQe0S6CHnrsfDKOL6A== X-IronPort-AV: E=McAfee;i="6600,9927,11054"; a="21133191" X-IronPort-AV: E=Sophos;i="6.07,228,1708416000"; d="scan'208";a="21133191" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2024 02:45:52 -0700 X-CSE-ConnectionGUID: BXcjopMXRPWnKL65Zhc1WQ== X-CSE-MsgGUID: PiSM1DAURgeDBvLyq5Vh+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,228,1708416000"; d="scan'208";a="25005287" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa009.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2024 02:45:51 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rzvfa-00000000x43-2PlG; Thu, 25 Apr 2024 12:45:34 +0300 Date: Thu, 25 Apr 2024 12:45:34 +0300 From: Andy Shevchenko To: Miaohe Lin Cc: Rasmus Villemoes , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function Message-ID: References: <20240423161506.2637177-1-andriy.shevchenko@linux.intel.com> <68489f85-5579-5cff-eed1-55ae585916f3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: EB4A820007 X-Rspam-User: X-Stat-Signature: ipdcyybm8ffckc9cts1759ipcnkjy71k X-HE-Tag: 1714038353-936439 X-HE-Meta: U2FsdGVkX19zZLNKYPd8zJrrVu5fHoPdUeLLm9AP/Z709BE4bMZZCHRJIvQ6sJ4ej824xui0fcge+gKZN/GLlCHugA1xS+4EKSjW6VgWQdnOOoIvkxj+wYcXRyjBlYyrVXOwfVoCsPZMq91pNzfULasSwcquNMJS+k164DKgB4tjEvk5VKIT8Xs8UmO/eXfLcPhQsPTrg0lVIMS+uSkdYp4mCu/X6jGlj7elVJ1QryMW0ymLsUDlzKrQq93FQmgAMeGcFb6RstxrQ/rznQqdwc2a5falT3/T9cfKbKO+bd8shcyO+Z6p4Y3a/bohcgNkXko9faVIzA7Hq+yeLmyxiO7HSbJnSsMnmz4KovJAf8Sw/LoTfl0lLvLlX0+l0vfAQKrLv2K5d7fnKVZoU8JYacMsI4DIXtq8k+3RzPs9dvav2iRJs7E+mOjbdVWrzhyKbVKJ2gPEETTeYsp1gFCMXEcRP+S0OKPnXPfHD0RV3MZtWtgS84JiYl3MjeYVIB1fH689y6u5zSYhYgM4pLjCDqNigk01voGfMPrcBppI+4LONm9MNF5JbaG19PPdQI41ICnGhPkxU041yOYhZKzXY4zGlU7owy5lI9hEu0mRTCM0lhAiyLAlAa3w6LaFh0zFvyJskOAqR6sxrx2LbyULy/PzPiE8aD2Z8pezQXUsFRduQyhKymFdk1cClq7s+74UoMmZQAnSNM6p7AI6VHsEUS/41HC41cblfOXtsASeqHKApClEUclcnxsmL7wK3t7fNJw6npptFToLzZ+k5hrVIEEiq51v5bIv1umUckS6gHut6VXggB+tWcZQZ64eNY0LN2AVOmcMG0HzFA6ZHFa+49OQ+Ef1a+NxAKAyT7wVdUDFbZ65Ebi111LfeirhJNN9vqzJ32ok4zEUhVFlgtM5ujfPpyT+f71rE/pe1AS3aU4yjV5qlDFQLUb3VYBKnp5oxqnljugviRVFtYQAyeY UMzQ6XWW GbEix1qvAm8AIBr2Hh25cQuZBfhoLK4ZMgBvJI7GfhjxC9TGDr3G94oxWkIoOO60JcBY/gt+rQTroieQv90XwY+uTPH6Daa38foQCMdyKmU7fQ5TkUywfBHhIBG3mcvkI1I6yzyu19WD8ew09rBM6geMQob9mcMGDBnBW8VLpRI4Daii8c/H6uuc+L9gEtDyyGRET8weNg6fjaOyvN8oftD0WIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000347, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 12:15:32PM +0300, Andy Shevchenko wrote: > On Thu, Apr 25, 2024 at 02:25:24PM +0800, Miaohe Lin wrote: > > On 2024/4/24 0:14, Andy Shevchenko wrote: ... > > > In some configurations I got > > > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function] > > > Becuase the only user is guarged with a certain ifdeffery, > > > > guarged? > > A typo, thanks! FWIW, Andrew fixed this along with "Because". Thank you, Andrew! > > ifdeffery? > > Yes, this is established term. > > > > do the same for add_to_free_list(). -- With Best Regards, Andy Shevchenko