From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E25B5C4345F for ; Thu, 25 Apr 2024 09:15:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77A1F6B0096; Thu, 25 Apr 2024 05:15:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 759AD6B0098; Thu, 25 Apr 2024 05:15:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63D7C6B0099; Thu, 25 Apr 2024 05:15:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4CAD86B0096 for ; Thu, 25 Apr 2024 05:15:41 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DCF781404BC for ; Thu, 25 Apr 2024 09:15:40 +0000 (UTC) X-FDA: 82047496440.22.1E5C9A2 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by imf10.hostedemail.com (Postfix) with ESMTP id 4C1B3C0019 for ; Thu, 25 Apr 2024 09:15:38 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FqSNEswX; spf=none (imf10.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.18) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714036538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KPShzm8vrFoUy++4YYd3+Og2K97AkLwu5DRZ2BdMAe4=; b=oPKgYQEmo/mvOiamy2j2TE03RfTwSpnpTGlsM60ryAwTRKIpinS8/6q9Uk6HFfhSOv6oqH ZD1P0VJ+DXVFlnBBwEK4+/VC5WouiLV5zzsPWQVlkyPt437DidHwTP5DOGrJMOfGyxeQmm tC6jUUSQU7sxELkFL5Ldd1S0yq9HMn0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714036538; a=rsa-sha256; cv=none; b=GE2X2mGqYJYgmJjhgRVCfq0vvuFc+Qku2kHJIVf9kX3g5HFgquKvQaGpF7qjCmoaQf1ROC I7csX9CbkcB6hJw3ZlOZseAsRpcov18cI/CkxfalJYW+1ZbwEZ/al/Zqgj2rHsI1sTjJjx W7AMSDyp7Y1sKuizqTNW4HQjtHUqiZQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FqSNEswX; spf=none (imf10.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.18) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714036538; x=1745572538; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7I2F8yY16MhzKfcFcggrHF6aynsqbAHUvh7eIBlE41o=; b=FqSNEswXL1duRuC3A0ZuXnUZiZZgyEsIHJ31sKm/9qgb89g0/tA6HVF1 fKfiLBcPN1rJw1fZ1vMICMAzU8N0ssAxel+SgQe16OBfSXip2FIstq//J gXW+9WfXsbmvD/qK5cGn6dZwhiSIZkrAbFGoZJNWe771CXhSTgStznHqQ gnZkk03QZPF4xhRaW95SbIpzB2tNOYJ4xtRVkL1Gflgv+97GQ1146HalQ fOrGU4O6O9mfrEsthm+FQSNmMMdPZLZ137xVcNAqMY7jghAga9UqxJubY Wc9Z2DN3BVN7Ezs197X09O/dvgjghG3CgoRzZXCPIBN6bq7xcdjYwcOQj g==; X-CSE-ConnectionGUID: V7s4sVeESYyZbeLjRhs4Bg== X-CSE-MsgGUID: ArfChbgTSWCxZ4caUla6ww== X-IronPort-AV: E=McAfee;i="6600,9927,11054"; a="9556967" X-IronPort-AV: E=Sophos;i="6.07,228,1708416000"; d="scan'208";a="9556967" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2024 02:15:36 -0700 X-CSE-ConnectionGUID: TBBtHCntTm6m8fXAxqh4aA== X-CSE-MsgGUID: o7sJpbVgQtu/FRi/UGeqSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,228,1708416000"; d="scan'208";a="24999908" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa009.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2024 02:15:35 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rzvCW-00000000wJK-2Jz8; Thu, 25 Apr 2024 12:15:32 +0300 Date: Thu, 25 Apr 2024 12:15:32 +0300 From: Andy Shevchenko To: Miaohe Lin Cc: Rasmus Villemoes , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function Message-ID: References: <20240423161506.2637177-1-andriy.shevchenko@linux.intel.com> <68489f85-5579-5cff-eed1-55ae585916f3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <68489f85-5579-5cff-eed1-55ae585916f3@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4C1B3C0019 X-Stat-Signature: 8tdt6h4kye7tx4xifwaxxrn6mmud1p9m X-Rspam-User: X-HE-Tag: 1714036538-471309 X-HE-Meta: U2FsdGVkX19sxuDoqDNAI1oa1tI/tjuIYKCikFRXIZppX5fWdiBTuy70RlC3uNlbsx/oLRrvkdV/lrdk1qeoDMxfQVxXsI/QVyfT/sJtPF2DIWpzOyfKLMDkqtcv1qYUYkbxX77bVRq5g0P3WZ6gp5qBSyf/wkeERQ8fjQGJgC40VSQaoInBB2gpjjfOfKaOl3QaGiw6yO+WqOqP7iDIsJHjU1+mrqzo2V4Ab/8hS+0LmRJeEQ62Y8riyb5i3a1/LTrkrY9H9JFJoJmzHRKsU9HuVjEtQ6sgAXHb+qKvX4qYL308V35oqOaJpM9j4vQ7tNbDYTn0TtzAG6SD35zoXr3afZZmorS0oCzpx7JFcvWmz1qmaP6fJTMkp1Ty0CcMfhicJtzQ2lknb2aGzlNgu6qBOp7H5Wi/bjxsq2GFYrOvNBXBbmdjL3IEdarekdkGm7yrGrL2PuT6LLp1CkSmwoptz8nAk5waX3QaDVm1aEZ+/xNg2scwEzU6IZiz8bAlyimv0JSMvOvv70YgWSUnzUwY7ubme4YfiPNMYfIm0UISur6qNZqlN5EVwaZ5pzWsGR3tAaQ2NCkQVe82/bgFcSb2WF4VnjBcnt0/GyPxNyy0IUz/M4E2HgUo5MoHNR2uCQNXi0T4poD3ceuZ6+7JH1fwonSQkdOO27zYmj766tEtCRpOnYOw18y0/fIOwop9hjD4nqNH3s2b3Zt7RKudT1hWJ44Tm0cpaKRyOkP60NeMjJtSXyLXuqKWhggXoio5HJ++JVZrOKzq1UzuVEh7xFvRTmjbZJckv/uYuSfz1p6Zb0bigJ8KPGyZvhASIZ/Ik4hzH38MM+ivo5xujs8wVoEEg6at4/NVMPFVUHH6UlWqlwMlA0yTodSx+K/mEKhSvHJ6DGto+9vSksb0xYSWVNK52qPD2CmqgEN7EFBKqmya6FZpyLjcnsTbGmYqUujCoxaXLmVXhqLVgSvmeXi oy9UXVNs vkovwW1YOxUzwW6eZntEPwC0IxnXvMIKNnDZHaBbuY7fhgII27BefpjKtGycoLM2bsomm8H6MSpcFzw1SPD//1H0e0+AX4opCzb6/rMcqntdsaNOe82LKsxEDCUhlRQC4D+OdlAtMAFFwJC1VF2fmRrhALVACVbmrY1U8M0Rs3IKe9QIQGJQ2cb7wU7PTrBG7Dqc9GHBwoOVpA77I5yynhynXV/6FcGVMzPXG5mear3U9cJFQsYiXiqw+LcfOAsapS5pO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 02:25:24PM +0800, Miaohe Lin wrote: > On 2024/4/24 0:14, Andy Shevchenko wrote: > > In some configurations I got > > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function] > > Becuase the only user is guarged with a certain ifdeffery, > > guarged? A typo, thanks! > ifdeffery? Yes, this is established term. > > do the same for add_to_free_list(). > > A Fixes tag might be needed. First of all, it's not really critical issue to fix. Also see below. > > Signed-off-by: Andy Shevchenko > > Anyway, this patch looks good to me. Thanks. > > Reviewed-by: Miaohe Lin Thank you, I believe it will be squashed to the original one as Andrew already accepted it. But at the same time his workflow allows to update the commit message in case it's going to be a separate change. -- With Best Regards, Andy Shevchenko