From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function
Date: Thu, 25 Apr 2024 12:15:32 +0300 [thread overview]
Message-ID: <ZiofNBBRAKTUsh9Q@smile.fi.intel.com> (raw)
In-Reply-To: <68489f85-5579-5cff-eed1-55ae585916f3@huawei.com>
On Thu, Apr 25, 2024 at 02:25:24PM +0800, Miaohe Lin wrote:
> On 2024/4/24 0:14, Andy Shevchenko wrote:
> > In some configurations I got
> > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function]
> > Becuase the only user is guarged with a certain ifdeffery,
>
> guarged?
A typo, thanks!
> ifdeffery?
Yes, this is established term.
> > do the same for add_to_free_list().
>
> A Fixes tag might be needed.
First of all, it's not really critical issue to fix. Also see below.
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Anyway, this patch looks good to me. Thanks.
>
> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Thank you, I believe it will be squashed to the original one as Andrew already
accepted it. But at the same time his workflow allows to update the commit
message in case it's going to be a separate change.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-25 9:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 16:14 Andy Shevchenko
2024-04-23 18:10 ` Andrew Morton
2024-04-23 18:27 ` Andy Shevchenko
2024-04-23 20:30 ` Johannes Weiner
2024-04-23 20:45 ` Andy Shevchenko
2024-04-25 6:25 ` Miaohe Lin
2024-04-25 9:15 ` Andy Shevchenko [this message]
2024-04-25 9:45 ` Andy Shevchenko
2024-04-25 11:23 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiofNBBRAKTUsh9Q@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox