From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF3BC4345F for ; Wed, 24 Apr 2024 23:59:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33ECB6B0096; Wed, 24 Apr 2024 19:59:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EEA16B0098; Wed, 24 Apr 2024 19:59:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B6706B0099; Wed, 24 Apr 2024 19:59:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F28EB6B0096 for ; Wed, 24 Apr 2024 19:59:09 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 75206A0263 for ; Wed, 24 Apr 2024 23:59:09 +0000 (UTC) X-FDA: 82046094018.19.055BF6A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 44F431C000D for ; Wed, 24 Apr 2024 23:59:07 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=igcTIqHM; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714003148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vNG9QqElHBsq1h44jED4ysNt8/35kOzYfpgTExkMc2E=; b=fl1a98mDyC2M6/MyUaQQczJwLdaJza6PHRPQ2XWlfjuV+/5KFWot3SXOPk27x4IL+3AQ96 uaVBgarpXv0/LnQL0Sefwnu3yTFHdO8EkqVQ9RQWAx3Ji/5CvGmpdWFK50pUwoWd/Dzrk1 xThSznCI0UZmqYIEOoemIAQp9xFW8z0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=igcTIqHM; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714003148; a=rsa-sha256; cv=none; b=HP5eptKvbD+5dSULK4qkLGueh3LtzsqlOetfha5bzvj1dvSGXwo0ZoS75fDYQIHB9UeVmG pxk49DQGMJchu0J3e6/QeGrGlg1YkfEwNAiQ6q6rIwUSyOwn6x/VDS6wWV5GbzWaWQpfRh XGWGrFDSxATS2EMyhJLYpFj9CW7vNps= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vNG9QqElHBsq1h44jED4ysNt8/35kOzYfpgTExkMc2E=; b=igcTIqHM0RfUK1MeyaDix1TNP0 ZwowTxoD2j9tUNWIzPpqEVnl0G0D8+fvjPtAQC8fzyCq1Pv1/maLu8N4Safh1O9uOrq1zcuQBGKmX qYCETvKlaZI+4P5NYWghu05eTa/CAO+ol1z2xNzWYc5Yg03deYfxaLzB7xQpU+DIPecm9S5Xj/lvJ zsPSyLcgVJ2SdZ/S4gA69JKH/dVLPaKvuf5Dnweg3281KfEc3BbXBLDUwAIAoiQ3vXnF1WfpMmCiN lRJqCz8/9lC2FTBiBDf+VWYofEBq7JK2luLR8SxZh3UpR+tEDhXVYXxW7mKm4/IHYvuTM+z6JcU0F UAjQCT0g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzmVz-00000001wNo-0OuB; Wed, 24 Apr 2024 23:59:04 +0000 Date: Thu, 25 Apr 2024 00:59:02 +0100 From: Matthew Wilcox To: Andrew Morton Cc: David Hildenbrand , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH 6/6] mm: Remove page_mapping() Message-ID: References: <20240423225552.4113447-1-willy@infradead.org> <20240423225552.4113447-7-willy@infradead.org> <7c52ae2a-8f72-4c3c-b4b3-24b50bdb5486@redhat.com> <20240424163423.ad6e23a984deb731e2de497c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240424163423.ad6e23a984deb731e2de497c@linux-foundation.org> X-Stat-Signature: us5m6kfgde7ucjwefdzcko1pga3c8fur X-Rspamd-Queue-Id: 44F431C000D X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714003147-161508 X-HE-Meta: U2FsdGVkX1+g0iBvJLFrh3am1XU6dvpp4xGAF7Chd5zODzxbh3pc38xmFMHny1xVluhQbh+7ectvubx91bXKRlf5gh6ccoDqpVFmesexfbL5+6uJmwTyHABnXw/+BzOsNzzQfoBvyTBzd0E37vAEmwENKyIdRhbhlaIVo9S1QKy+7+kfIBcNryIkZ1/elIyotvedhxCuGg+rzu+AqO8zb5uU1DcFMnsQJxbdQTuZTvK5VNYeFrKviZiky0k8yOzmgRYDVMGWPa/OYeAP1P3BsIA7QPYyQ37dNpEXKaxzIjfjoKhwlISaTLO+pdIil09JmI33AeBrrldFzod6ow0hg7QqDc/L5MHi/R/R7DACkxzber0SZcZ1GEds0I+DAW3yNx78dwVB5f/MHTdSYJyXS2Zi2ZRpA6RAv3q7sLpbl3W1s3fya7hktbOXvuubwVl0RPz7XQgRhHRrzMbRv4MHXfCJzFd7OCL1TvvadNtXyzZYwhmPUcTsCe2nbA04/l99zinx+LRknPGEtb1zXcK4c1GgdGerq9pUhrxww6wJZvx57oPUNLsaxq+jqr7oOLsAYeObtBt0WF/7XGOB+SRXDgWe/knWN00URWKdfpv3+1wgoTxjt2GIfMGFJaCSo43e7Hf1I83u3iK7jgOlNSUDofFl81Cg863dLuPUvWnJ6RJWyIjSaIcllVfaWfyadM7aJoVWY0q8bYkD2SbX3AdgCA6Tg5Z6hCnZoXPAIyMkTBxrNDT+FKTMhlOpl7aRNwbQazOEjodldIMv66w/B4n15hHvmJTb4Fq0FQXAwH1h02BsIrLP/3E93lNGlHmScUXKQ7cPhmhBVYXtY/ea7HWQdJYkZc5+7BOgF/nUAG7WGTHwW938OQVNhBd1EjMS1TYq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 24, 2024 at 04:34:23PM -0700, Andrew Morton wrote: > For some reason, > > mm/hugetlb.c: In function 'hugetlb_page_mapping_lock_write': > mm/hugetlb.c:2164:41: error: implicit declaration of function 'page_mapping'; did you mean 'page_mapped'? [-Werror=implicit-function-declaration] > 2164 | struct address_space *mapping = page_mapping(hpage); > | ^~~~~~~~~~~~ > | page_mapped > mm/hugetlb.c:2164:41: error: initialization of 'struct address_space *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] > > > I'll disable "mm: Remove page_mapping()" pending review of the below, > please. Looks pretty similar to https://lore.kernel.org/linux-mm/20240412193510.2356957-7-willy@infradead.org/ Sorry, I thought you'd picked up that series; I think it's fully reviewed by now?