From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A4CFC4345F for ; Wed, 24 Apr 2024 23:27:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DA466B008A; Wed, 24 Apr 2024 19:27:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 962606B008C; Wed, 24 Apr 2024 19:27:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DB6B6B0092; Wed, 24 Apr 2024 19:27:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5CB436B008A for ; Wed, 24 Apr 2024 19:27:01 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 03A3A12038A for ; Wed, 24 Apr 2024 23:27:00 +0000 (UTC) X-FDA: 82046013042.26.9F8965A Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf23.hostedemail.com (Postfix) with ESMTP id 44FC414001D for ; Wed, 24 Apr 2024 23:26:59 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dsOgqaGH; spf=pass (imf23.hostedemail.com: domain of 3QpUpZgYKCEs5rn0wpt11tyr.p1zyv07A-zzx8npx.14t@flex--seanjc.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3QpUpZgYKCEs5rn0wpt11tyr.p1zyv07A-zzx8npx.14t@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714001219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9CmG+3iHB+1BxNgRQoZJ+SwJOKBGJtBG8Ri4d9VDnrA=; b=rUWvC8cIKNeqEhONcTH0aIL2PRjSM0EtD8R538+Dhq/v2nD0rFSt/k0gvW20tz+FPkwDhP lx7C/51MUGMEI8j21FBX3Wievl3l3ElzxcA5oDXLzkuRmLVetnl7TeFAp8cYdL3pqYa06X tIvVk0Ils3zgbgq4kKCA4gCe7Qjd7No= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=dsOgqaGH; spf=pass (imf23.hostedemail.com: domain of 3QpUpZgYKCEs5rn0wpt11tyr.p1zyv07A-zzx8npx.14t@flex--seanjc.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3QpUpZgYKCEs5rn0wpt11tyr.p1zyv07A-zzx8npx.14t@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714001219; a=rsa-sha256; cv=none; b=4xUpHAS8//uQYAVgVL2QFn6mIaHNY5wk4ycJIBf0h+S/gC+yR4o10+CHt/ilfoX+loJESJ yx4vXXIJCIdVSdbkJwSdYM6bieGyczvscWT5AF/L4zu/K0dkBH2lf+5cgfiX+FJeldvEeW vX60v4VRBoq/WStGmOAcyk1FBjgc+Vo= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-6150e36ca0dso7122357b3.1 for ; Wed, 24 Apr 2024 16:26:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714001218; x=1714606018; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=9CmG+3iHB+1BxNgRQoZJ+SwJOKBGJtBG8Ri4d9VDnrA=; b=dsOgqaGH6GvPnZMHbCX4OcCxjKsqB9pAg38GNPFfus5i5DOBYLjDyCcgc+PJE4l0QX CFVRflHYA0ulDkZJJlLbdiD6Ow+lG8m5l4T3KfBd7HpHxOCDW6jXrKq6K5RQ/A2jr//v lALXVWU2VQ0SAd+OQthkR8PvPeYyna0DajVJRW4GUxHR672wfyDUEWHSHB5IX+Mhmgg9 BrAGNYXVIJDskt4Pfj5/OaALgTAui66U3l0UEW9MaTdP6mqc+vjuokK61x6VpdeKYeoO S4jT1ihLg2SPLOe2u1VYboCxkXePHRFshOniO88bVx0NGf8NWFNZoGyHNaH0nhRo2TZu m4+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714001218; x=1714606018; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9CmG+3iHB+1BxNgRQoZJ+SwJOKBGJtBG8Ri4d9VDnrA=; b=aUTHeV6qI4ICufvdL28SikmL+1sXWy4jzx8MNKD7g92dACwvbVWXTD2oE/xeFPPJd6 /yTV+Rv3qY6VXO1C3HF8L+r7PfkMOtsUpsPqHri+wGoVGuA9aQtFVImZCLgfda9E4TIO OJ6n6V3lFqb6EJxFEBeaKKlOVdvN7yQSk4J1SBYbfGLZBl6HlFsFtwZzwgrqixSLuN8J 8cxCMtvShem+c86EQMYbDo2JvEv6xRrhRypk6kD8CLbJ21jE5Q8hzO4j9QIjwZXyLL6v cHuG6UErC7+C69pIFi5SxwV44xcUAsR+PwfYCYVZuoUWPcSzDUptCVORegCkOXr8Et3Q 1YLQ== X-Forwarded-Encrypted: i=1; AJvYcCUYnxyjvuGRE09yUJQwdaBkROSsxvPfImyJeyB1xbEYCymbLu1D994eG6o2SmT8vt6/qWAXeu0tPAxjLuFcc/k4P5E= X-Gm-Message-State: AOJu0YxT8P2Uw8X6ch27Sh6kqV3/YJJNJgr7BGIzZn6KTD25UvYOKD6L pejhgsWVV9yV/WeXRw0DuUaLl0nsI2XzDTm/77Mt23E2gn76CSv+8Ks2xe29heieJUcGGRgNRzA WXg== X-Google-Smtp-Source: AGHT+IG9AFP7hY+ukqMVBTl39cuNC0vrXBttEQiu5m8xciLOlctXbTTnNj1cEOBjn+Fu9BaNN6kY8VHwld4= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a0d:e288:0:b0:61b:649:ac90 with SMTP id l130-20020a0de288000000b0061b0649ac90mr769275ywe.9.1714001218264; Wed, 24 Apr 2024 16:26:58 -0700 (PDT) Date: Wed, 24 Apr 2024 16:26:56 -0700 In-Reply-To: <20240421180122.1650812-6-michael.roth@amd.com> Mime-Version: 1.0 References: <20240421180122.1650812-1-michael.roth@amd.com> <20240421180122.1650812-6-michael.roth@amd.com> Message-ID: Subject: Re: [PATCH v14 05/22] KVM: SEV: Add KVM_SEV_SNP_LAUNCH_START command From: Sean Christopherson To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, Brijesh Singh Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 44FC414001D X-Stat-Signature: ksy5xtgu61exdgq66acbp9acy8wfn4w1 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1714001219-309016 X-HE-Meta: U2FsdGVkX1921/XREZejRpZAZfZzIalPCVF2fahpOpcB4KRmeBmuKvuUrYTG/DfG2OxKSlpbZ5Ar67yvQnQui4dMctYZYfdo/ewfM0k22bjFYb+LW+pG7KDKuRHiVuiPOW5NPhbdCvtVjcRlKw6q0NTdR6VRQeiggI2BFr1ts+4V6xoJjCGCWfpePXCgnZdArDrWZLM5ifr+0T8kJerwj9nsHDrvaJ/KOWeQEuVG9N5KgW4L04R6962TQWnYCKh/SHy+CyRfsihZG26u67X0R7vIgpK/QGibNW3JmPKKe5r+kfotKrCZSx3Ca3CwZQDM1P0BZy4KBV87NKITHPLnHym3NhXKJm8fbVG7gCeBob+fxOTRDk6I0ZhRYNBJLju5IAPVrIjqEv581hhkXhX0ZLqqm8YXls24cLDFXnNvetFuusdfZVOVTFnwm+kZNSRf5gPGRV0+kJip4QbEzoNgm9nCr3T0eXfT1PzbULB6vtbuZ9kovUl+ShLEM7od/7BWVlrW0KlhBX6VjRtb0xw/5DjGZ2qWUyU8P5BseAcxDsZi0shmAWsq9pdO9IwO+oLdozAfbUDV+F7lhbBVXIlcSjRd5WepcRjJEMc6ZuAPt85sJUh+I/+a86TbmbVeughWmI1IOvfFS+I+1Uu5mOH0KZLMsJuNL/jrpUy8Hql1qBgEgdkKl4CvZLNiBtvHGQhPU/jJFMBn7iGulO+yuvALy/K8zaB2wtEL6oRQTrCvcHfAKKXNBAf37YEXDs3Qvry3hsJvtt4n8thf+IT3G9/isitPoBRdgACl9aNHZAEVTCU8FIbSAd8ScpmDxz+j9b6IoWG3/kuX4QvbbfBFSxHMvr6y3tawMZ4LF9cv28z/UvCz4XaKZOKzp6rxfgVuUwezr5/sfFDlDvKGnOXSkE04AzqtTS/jdDarxnkSLRX5NzbfmqpJTaeiQoLW98BuhvNEdrInc4KQvD9aECE+j0P MY5XS0Eu LaG5QcDApEBmVfQM/s5LWiRzc+68Vv+GB/++T69bpY70a/4JZsMKedvUxKGrCAgFkqA7uDuOSXay7dZlcyXsVUeHK++g7iYF6zJCDOZ/nHWPJmxHKH7TvAzOq8/01Kz7wsnsIagR1SyJmm20akpWra1jM2ECDgfreCwH7XSOwNyyVH16o/1jE1bedAT42GHmdCNFOfA+EVLf5HwwAg1cgwalMuLbuuFSHUMwjoM81jdCuna3ITXGF7zjjSrh+x78LjL/5Suy5OxSAfp7HIU8UC9j1HlCTII4Ub5KfIebeXiKJ17Uv+vZvJoHpQSiAiLE22/OeGW1d+oeLrfOnzDmvHT2Dotkr8n6ZEbTqual6g3KT0BGuG6UAU5BuKEewv1eFhIfs+95Wgp0sEu/2+llmsqjsGq2FQ/ik9wj7/GpVDO9pu0dDKZElzz/6HNFXsOchfcQtyUKReUtdgWtE/rFwEMgJXFDgsRYxlxSuoU3q9p5vMBR59EfVWhpLc+XixpYrYXzxNCT5yNNQ+meYsU14ynuLp1YUIBxqsuTAP8RGfkKNltrzdzzhGRpldV90i1uJ8IP22tgovIh4byCu6BWw9IrwzJeYEeGoiKiEM4/0T0kLebFn77ABaI6IMAscTWWH0XDeeHO7j2VkcFdhqvKm8fdXoBQeJG//3Iwc9pLR7UhlQy6ztcaDiJIzCEnjG3NLNcoCjIrnvKWQ9flZg7QNuaCC2QGrmZUgbEkJv+PZyyeT4MI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Apr 21, 2024, Michael Roth wrote: > From: Brijesh Singh > > KVM_SEV_SNP_LAUNCH_START begins the launch process for an SEV-SNP guest. > The command initializes a cryptographic digest context used to construct > the measurement of the guest. Other commands can then at that point be > used to load/encrypt data into the guest's initial launch image. > > For more information see the SEV-SNP specification. > > Signed-off-by: Brijesh Singh > Co-developed-by: Michael Roth > Signed-off-by: Michael Roth > Signed-off-by: Ashish Kalra > --- I somehow ended up in the v13 series and gave feedback on that version, but AFAICT all of the feedback still applies to v14. https://lore.kernel.org/all/Zil8MnPXkCbqw3Ka@google.com