From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBEF3C4345F for ; Wed, 24 Apr 2024 20:21:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDFEC8D0028; Wed, 24 Apr 2024 16:21:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8FD26B02F0; Wed, 24 Apr 2024 16:21:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C57868D0028; Wed, 24 Apr 2024 16:21:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A8DA06B02EF for ; Wed, 24 Apr 2024 16:21:54 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 19725A035A for ; Wed, 24 Apr 2024 20:21:54 +0000 (UTC) X-FDA: 82045546548.19.2EDEECB Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf22.hostedemail.com (Postfix) with ESMTP id 3CDF1C000D for ; Wed, 24 Apr 2024 20:21:52 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Au6loLaZ; spf=pass (imf22.hostedemail.com: domain of 332kpZgYKCJACyu73w08805y.w86527EH-664Fuw4.8B0@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=332kpZgYKCJACyu73w08805y.w86527EH-664Fuw4.8B0@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713990112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kJKivmW0J/DCohVbY4PLH/Gsm5HkrpKk4PumvPQkGTk=; b=Jv/oJ+w3rka0Ao3osdZUHQdEAhiWbiBYxOHw63NYbk05ivU+2prO64KS8Vb70Q0KJ2pavd 7X/ZYloGeF/tvpSFSzQXXW5mNMD/4Moyw1uvKJC0VJQu37Mw1z7PAQ9mU2jyZZ85b/CIW5 +iSCty23wT3HGjSqGD2Do176T883uVE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713990112; a=rsa-sha256; cv=none; b=GJF8Npj+lY1jVrT2F5GYngHF3otZd5WqecHPZI+EOQthy35dJF6XdatS8l4VJqbNiWa0HK D70mFO3PjxfHvFBC0Vjqs9AVNnRU+dBlRqnLZ5lNwDjkJ6IAQzfwDZYIGZ+Q+DbhXO1Fqv 3J+Kk+dl+Zv0kYXCIVLz0o5vnLmIcu8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Au6loLaZ; spf=pass (imf22.hostedemail.com: domain of 332kpZgYKCJACyu73w08805y.w86527EH-664Fuw4.8B0@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=332kpZgYKCJACyu73w08805y.w86527EH-664Fuw4.8B0@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dc6b269686aso519794276.1 for ; Wed, 24 Apr 2024 13:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713990111; x=1714594911; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=kJKivmW0J/DCohVbY4PLH/Gsm5HkrpKk4PumvPQkGTk=; b=Au6loLaZmSPzNCGRLwdUgjrbZlXXsFQI2OTqSuOsCg8rhpc1Z5l+8kbvHtUqUGlUMU vRFd34KnNk09A/z2UtRF3TS86osr3hGYYgDdry3pp9rRjWa79NYNpWN2lRojDzM8rXiL gyXwGr+dIyaChRBMra1cPBML/cMALAkmEjubwvZ6rdzvHFYt87D9imLkPUAOw1yNu0c/ NGeqnqHFZepBcdZKKYGC3tnZIwO2otsWwmW7xg2h30dkthJObj3rjazVzVyQmk1tniXx W6zorYYg0de9pFvFJrv039lZm8ot2XaFBCcrK6LNSmlHtB2sQoPNEivUnPk6URg5uLS0 ocjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713990111; x=1714594911; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kJKivmW0J/DCohVbY4PLH/Gsm5HkrpKk4PumvPQkGTk=; b=aGxlxa5EjTcaAHHri7neVWIINzOryBX3rdtbkI6pqS7ABCQDY1FCgK5ubZPo2DP+FD U6jafoGKhgiP/xmUOX2SgRt8SgawKBcAh2DW7naF/SuIJh556rQ+ra5ZzgVl61hm2T+f KH29RWy/gcvzGJxLic3616Ylbal4ixbmUzQklgpEqfCn/PFM5QlnEKECRqcB/bNUK+5M 8sooucfueHc2MsONxmIvkUSATUI/4hzKBU2gMzKXFOPD4gTgH1Ioa+5A5rwgoJVEUZ1Z 8fsvoQDWBwrc+aIEkl2MMsQqONv+CIsvNC6KYzdU22/9fTLiSw4vOJx+PCJDIMfoLP1o Or0A== X-Forwarded-Encrypted: i=1; AJvYcCWeo4A1bEEvaQV5pm32tbsvj/LYMBsQTvTf/k5RMzYwKk9KjzmJhmkIHHOU8ZdqlOQ1w/OarBsTRcFyU6fahIvZo3M= X-Gm-Message-State: AOJu0Yxjfkzm+eTLVknwa1gEfvdnVHfW5ifDDiSo86JH+2tBFLm9j9FW Sd13D0PeyjXk193NXzEn8P4FBXk4vne9C2J+9U2yhNoXKAOO0jJUAeAx3xh898/tDXTqMOwteVc rsg== X-Google-Smtp-Source: AGHT+IET29Be+TqLLxR1el2WX7B1TltJHuVLHw4XBc2UEobX1IG760KHrKW5Mr9mGqY0ZbBfjntc+5CKv7o= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:c54c:0:b0:de1:d49:7ff6 with SMTP id v73-20020a25c54c000000b00de10d497ff6mr385878ybe.7.1713990111258; Wed, 24 Apr 2024 13:21:51 -0700 (PDT) Date: Wed, 24 Apr 2024 13:21:49 -0700 In-Reply-To: <20240421180122.1650812-4-michael.roth@amd.com> Mime-Version: 1.0 References: <20240421180122.1650812-1-michael.roth@amd.com> <20240421180122.1650812-4-michael.roth@amd.com> Message-ID: Subject: Re: [PATCH v14 03/22] KVM: SEV: Add GHCB handling for Hypervisor Feature Support requests From: Sean Christopherson To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, Brijesh Singh Content-Type: text/plain; charset="us-ascii" X-Stat-Signature: akkpt6wnwjranerjufr19zn369ijwmyy X-Rspamd-Queue-Id: 3CDF1C000D X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1713990112-86297 X-HE-Meta: U2FsdGVkX19CQ5XicgDfDqY/Bp7CTl+vUzYyGVdnHg7AOOT+6LBmEJTHNysVgFjbkS8yjWhurFz5WcLERAJS6L205onxR0zVouQFy18KrwZuGoXU/dNyLZE1Pp28WX2O2q9x+0Q0IFhVufXnaiUFCGEgGbs/teWuSVY9rIAmJhiWKUd9ZKWonepM40iGu6lOQOjpHyznkoSBBr5iTLA9gYKLCcOyNn4W2yph0UQl9o+myW4tE8QfEgwPl3NxbmCASv5Lk9T+Nn/OS1ktkV/aBsSOTD87U3NXtlmP2zki51PtMmBAch/UOuCtR37B5oemfdor2kqC/goEgqPiwZ91xNAPT2lP6KTqm1iGNhNcpL07MxFiFmqGvHWxxP5w6S/cNOGNdMHjLj+h3UJYbJeELBXdC+XosGTouWGcI3KCQ1TkNRx4E6r7yQMrABBM9it13oOMsiNaWgkRcTa15zaaQVHX2pJhYNku850gzP+NAL9yqdExIv2b17lVCn6ea0Hd4U7ctjhDqGJI9vPjDdu7x4kwELD0aiVn7tJ9qfrus4ZerKGCVPjnAZWqE7Qhe2FZX4+cUDjmvBeUREUdsUngfl5Rh9CD9GwouXxv/eVY1flD9wmINEJs9xxCaFsV0PWvryr0WuOo33yyFnSaCbqo229JD+UTzIj3eemvZuTcID3WeWkOJCB1NiUR8d9R041Wf3QEIRyMoilhEEy8xwqWe+XiK/IOi/+cSVjS1VCYr8OoYZV0qrK/8i6R2VsWyLrEtNRLqrt14gqtVAKmcD73v3Vyu6l75z10j2wJ/IEwTFSPQusanfhHdK/MkO02QXBQnPl9/dXqET7b0fcSiw6Lrs5y2kzh7Em9ii7yQxM3X47b1VgIuu78Lkj7HUCbZ2LfLgpmfhI2Lvc+5R/ZTxY/NoNLtk8IBLuJUXs7hJt1Pvcu+kET2jeQe7UEBtw9meFNWXfWW7MrQL5G1q4dkHh HmxRzKoE xUrganaDg76X+db9r+d9gXBoQ+y77KGficjYuJqKCS9N/RxelHUprQBMpPtH38oexme7/yutHiTJOQP5158OgxT580jWC24zbQJPwXuV+nrGoVvbXEQM5UYOSmQG5Hgccm6Bdrxy+dQ/EESZeTgKI2CY7QrAqYpPjp9EPy1S3aJJJZ8RxURE3nOrymRwR8rdLEyXzbgcWhcpfcxb3iiJjVbVM/YurNOcoW7PFvbP7uVqw2aUxugssoUvcIDdJnmy7mJ0xjUPj31PioZSDRkYnvSkW3aDmfEWkLXbU9a2IH3K+WDSMYCP8+eGtAKhFYNdZA83iGrp4tlSJgKxM3FQz7ZNqFlp8xnL0ww+t8+5iO910Dpeo3CAlW8Bf+oCy2KiaP3NLQ8+X6+OQS9bxNLvUXFP/8wlu3roxTv+wCiSD+LbHRCUimBOBv59JFRkdbdMadcVNX5ash/LLv90Iw1jeJq2YA6aeQwyQCSxs5viqBrxP4Yk3FLFw4YUKleL5peWl1uXJ1XYHL/MprEmslWd056HyBaw9IedfDzvMGNXuxQ7BMJc2geQAbzAHoyt2Drp54T71Yr/kspksIWia9D6Cfi/5Qw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Apr 21, 2024, Michael Roth wrote: > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > index 6e31cb408dd8..1d2264e93afe 100644 > --- a/arch/x86/kvm/svm/sev.c > +++ b/arch/x86/kvm/svm/sev.c > @@ -33,9 +33,11 @@ > #include "cpuid.h" > #include "trace.h" > > -#define GHCB_VERSION_MAX 1ULL > +#define GHCB_VERSION_MAX 2ULL > #define GHCB_VERSION_MIN 1ULL This needs a userspace control. Being unable to limit the GHCB version advertised to the guest is going to break live migration of SEV-ES VMs, e.g. if a pool of hosts has some kernels running this flavor of KVM, and some hosts running an older KVM that doesn't support v2.