From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01E9FC4345F for ; Wed, 24 Apr 2024 12:50:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F0066B027F; Wed, 24 Apr 2024 08:50:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A0176B0280; Wed, 24 Apr 2024 08:50:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31A206B0281; Wed, 24 Apr 2024 08:50:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0CC946B027F for ; Wed, 24 Apr 2024 08:50:58 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BBC17141064 for ; Wed, 24 Apr 2024 12:50:57 +0000 (UTC) X-FDA: 82044410154.27.EDFC7B9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf21.hostedemail.com (Postfix) with ESMTP id 981071C0010 for ; Wed, 24 Apr 2024 12:50:55 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WDYLaaVr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=GwLeC0wL; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=p99q5IYe; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0hCiIXIx; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713963055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CXtNZw8CKU8Xn6cglX2Jt4nhiH7S3y2VuCDIBRk3nX8=; b=MrHS82cb0Dc2HZ/SwYi7eQXsC1q2FYL93ceJa4LghjqQR4tpW4Bm3ArkkLYE5jVroC18lE 26SmorX611Und4M1klVvIa+OyNeK1EkaKFONDc+C2VFwxR1KqgFeBtT7RtrdLNuRl4GBSo Wm/VJiEh+eEALjQ65wTzDa7Is1mlJlU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WDYLaaVr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=GwLeC0wL; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=p99q5IYe; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0hCiIXIx; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713963055; a=rsa-sha256; cv=none; b=beMs31CXBSBnJ0qrPzbJs1bm9GYPkAidmMcAD+j6qrFulU1JWe1BwWg1/0XJ7jZTW5vdWO lzsCU1BolbyN4fFpaDPc2NwvBfZhjZu+Nj3Ep1AmEEaVjH5ipYUTKBwBMtnU+t1ng7iff0 SDguJypNC42A1/PD6QkCh4CnkOeM+tU= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D57C366D87; Wed, 24 Apr 2024 12:50:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713963054; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CXtNZw8CKU8Xn6cglX2Jt4nhiH7S3y2VuCDIBRk3nX8=; b=WDYLaaVrMXMk7idZIY4DIYVp30+cWDuIUc/31xfBq7mjE0ZkJjf2TwI1fS4avoMrL7L7bD TJy8uxK+BFLVfYTNys76wN9XWBHxTh9fMasXA4fcaaL2dvyaGUgvGh3w3bJhw1dxYdiFNH LQOwOKJ6Qrj8euYKm8AYbickbFjONU4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713963054; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CXtNZw8CKU8Xn6cglX2Jt4nhiH7S3y2VuCDIBRk3nX8=; b=GwLeC0wLJ0uVE8fbv9KVNsW2h6xAGRXfIn5Bnz+5JRh5hzIkcJunPDbiKji/R99K6oNCex ojhz48eMxOowTsBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713963053; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CXtNZw8CKU8Xn6cglX2Jt4nhiH7S3y2VuCDIBRk3nX8=; b=p99q5IYeUiZHiIYatIXThbeVmmkiAkP1mAIH5tXbR3SQNI0rTfyUx4+qtio1kw6Tw/JHeP r37VJ4Y8Bx2WQ14Y8AsO9Ywg92CpbdeQoGvw/4vJ6LOGCadc7Wt+i4RIRmwTIlEm2VU8D1 Sq4ySFXPwq+QJQSVbEJHTv7cbe/L2Oo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713963053; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CXtNZw8CKU8Xn6cglX2Jt4nhiH7S3y2VuCDIBRk3nX8=; b=0hCiIXIxQ/CmOXsoppYZR4Vm/LCrLzKubwQWyDtob2OVthv2C5Q/eHuntOAmONYV7KfQiX ObLTVtNP1319kaCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AEBD51393C; Wed, 24 Apr 2024 12:50:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eVfqKS0AKWaddQAAD6G6ig (envelope-from ); Wed, 24 Apr 2024 12:50:53 +0000 Date: Wed, 24 Apr 2024 14:50:52 +0200 From: Oscar Salvador To: Hariom Panthi Cc: akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, r.thapliyal@samsung.com, Maninder Singh Subject: Re: [PATCH 1/2] mm: page_owner: fixing wrong information in dump_page_owner Message-ID: References: <20240424111838.3782931-1-hariom1.p@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240424111838.3782931-1-hariom1.p@samsung.com> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 981071C0010 X-Stat-Signature: 8gm4odqtjui9ox5j8i7kmc5twjy36wbq X-HE-Tag: 1713963055-472758 X-HE-Meta: U2FsdGVkX19JZ2WxIUyhSgjNV6MF6FK0+rNMAR49mlMrIIoi2DDwEafbl8O2KhNRDdLuaiNBA20YxPRHa2914T25cTKCNdvAv+MRc99xNpaeIhPyazs7hDaxfKTgJvF3D1C6YWU/cIy1nwMSGNZOvgndcIhroxi2HhQ3X7NR84kME1M8/c8kSJFAdfqFZkZE+CUhLyjcR75H+vEpm3uTglh6wLhVjYv5pWHv0rrHQFHkjlTV80G4l3WJcQaRl4CoclAeEoUJ7dsNA7IQg7sYlxWa5PwzNLQu/qLn16qWl5ElmHFuQwNLUgRqYMKuXYBYbt5al9eklh2GiYB3H7PZ0DcA94vG1u6RidNWfxOue6eN/N15kvcuZxIan7v1DnBddphm9za6tZ3z24iHJgVZHjrfgbJ746q+EBchSs1V8H0rrzZkJ/4kitJZE35w0uzupoodW5yJwFUHGEr5EV04SO83/119Qkt60Dh+GEISoA5hGlau9/1PQe0O5qa/VHVZCHUqdt3ZlpLqpmsiYwkRh+ZKds6qWMXuRQZ3XOZfJZ/Ja15sPDA3f+pPt9ey/LUkud59gnob5CxPzlw3elD8J9rJNYhsvUUI3uoIvnrUA63juLSpdqX9O/m+2FKm+ZHVaedycaY+HUWZ/JnJUIqLTLgv8M20Eyj24E+gY/SqPmBR3td+mTToAaD1AEMWcOpNIIn/aICXF/LDoBr0+0Y2mv5C9X0R6MRDZD0ZzQIe6U/i60TNOcGJBJE7BTkUYJkgw2gYvwAmM8yGfAiDEmNgelsEp0R2+MBKzhmehTeCWK3EZ7+rTDUpuBepVPEMczRHmWwaUSVaI6lrVWFYjMqwqWf930md28HQlqYg5uvZbYa2yANnfkCnSAMTGlnm9gHnMRojWBtyzbw2WCxmzn4zhQiauKujRa3F3mKq8q5a0+OkyOsLPrkXMnjeMO0p/adSu4sBDT08vx4WGxEaVJo +H74KvJ6 MfHFJrTruGIUGU5kv/SWR4zCQGncBIpU06fDPjsqANiuRCd6dM/nLustXIFkwSDWSrqtl69j67yKNmQEhv25Nt1mkAOIvNl+N0P7SsjzRhU9SU+FUOQ/L8cSGqf/nDtVJVvqwhemf6cLzYmjXxJ9SW+lJJBWcNj5BtOY7oxrTED+L8Tn4SoRoQQIayrKBmmTwu2f1GSGKWdYI47msjXilCBmFSb7Oyhmy4tYVj0Hk2QL1uI6sCRySzZTDBQ37+GvtPC822ot/9plx0XMUnEtrWKJTNblxJ2uzCfCMNtvqCX0HKUmb6h9ZpRIgvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 24, 2024 at 04:48:37PM +0530, Hariom Panthi wrote: > From: Maninder Singh > > with commit ea4b5b33bf8a ("mm,page_owner: update metadata for tail pages"), > new API __update_page_owner_handle was introduced and arguemnt was passed > in wrong order from __set_page_owner and thus page_owner is giving > wrong data. > > [ 15.982420] page last allocated via order 0, migratetype Unmovable, gfp_mask 0xcc0(GFP_KERNEL), pid 80, tgid -1210279584 (insmod), ts 80, free_ts 0 > > Fixing the same. > Correct output: > [ 14.556482] page last allocated via order 0, migratetype Unmovable, gfp_mask 0xcc0(GFP_KERNEL), pid 80, tgid 80 (insmod), ts 14552004992, free_ts 0 > > Fixes: ea4b5b33bf8a ("mm,page_owner: update metadata for tail pages") > Signed-off-by: Maninder Singh > Signed-off-by: Hariom Panthi Acked-by: Oscar Salvador Thanks! -- Oscar Salvador SUSE Labs