linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Oscar Salvador <osalvador@suse.de>
To: Hariom Panthi <hariom1.p@samsung.com>
Cc: akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org,
	lstoakes@gmail.com, vbabka@suse.cz, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, r.thapliyal@samsung.com,
	Maninder Singh <maninder1.s@samsung.com>
Subject: Re: [PATCH 1/2] mm: page_owner: fixing wrong information in dump_page_owner
Date: Wed, 24 Apr 2024 14:50:52 +0200	[thread overview]
Message-ID: <ZikALBw17JePpWVh@localhost.localdomain> (raw)
In-Reply-To: <20240424111838.3782931-1-hariom1.p@samsung.com>

On Wed, Apr 24, 2024 at 04:48:37PM +0530, Hariom Panthi wrote:
> From: Maninder Singh <maninder1.s@samsung.com>
> 
> with commit ea4b5b33bf8a ("mm,page_owner: update metadata for tail pages"),
> new API __update_page_owner_handle was introduced and arguemnt was passed
> in wrong order from __set_page_owner and thus page_owner is giving
> wrong data.
> 
> [   15.982420] page last allocated via order 0, migratetype Unmovable, gfp_mask 0xcc0(GFP_KERNEL), pid 80, tgid -1210279584 (insmod), ts 80, free_ts 0
> 
> Fixing the same.
> Correct output:
> [   14.556482] page last allocated via order 0, migratetype Unmovable, gfp_mask 0xcc0(GFP_KERNEL), pid 80, tgid 80 (insmod), ts 14552004992, free_ts 0
> 
> Fixes: ea4b5b33bf8a ("mm,page_owner: update metadata for tail pages")
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Signed-off-by: Hariom Panthi <hariom1.p@samsung.com>

Acked-by: Oscar Salvador <osalvador@suse.de>

Thanks!

 

-- 
Oscar Salvador
SUSE Labs


      parent reply	other threads:[~2024-04-24 12:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240424112123epcas5p46e76f51b8913661a6b740dcbbec83621@epcas5p4.samsung.com>
2024-04-24 11:18 ` Hariom Panthi
     [not found]   ` <CGME20240424112131epcas5p100ad84d676c861db5a0d84439fe5f718@epcas5p1.samsung.com>
2024-04-24 11:18     ` [PATCH 2/2] mm: vmalloc: dump page owner info if page is already mapped Hariom Panthi
2024-04-24 12:50   ` Oscar Salvador [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZikALBw17JePpWVh@localhost.localdomain \
    --to=osalvador@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=hariom1.p@samsung.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lstoakes@gmail.com \
    --cc=maninder1.s@samsung.com \
    --cc=r.thapliyal@samsung.com \
    --cc=urezki@gmail.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox