From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74C5EC4345F for ; Tue, 23 Apr 2024 20:45:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E73196B0182; Tue, 23 Apr 2024 16:45:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFCB46B0183; Tue, 23 Apr 2024 16:45:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9CE16B0184; Tue, 23 Apr 2024 16:45:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AB56A6B0182 for ; Tue, 23 Apr 2024 16:45:51 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 386FC40EF2 for ; Tue, 23 Apr 2024 20:45:51 +0000 (UTC) X-FDA: 82041978102.18.2178CBF Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by imf15.hostedemail.com (Postfix) with ESMTP id 97E8EA0003 for ; Tue, 23 Apr 2024 20:45:48 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="CCq4/UnZ"; spf=none (imf15.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 198.175.65.15) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713905149; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=trdgj5wTkqyrtafxCS8E7Jqj+yvW2vaTurK/q58qDcQ=; b=BeH1EcEDXtZi5kdLEWcZwJY3ueUzDsL4z4tGlMBA+rUG3CHVEagxELXuDNHMW1lhsr1geO dt7Z/32UNx7cgW5qEx+xF6RUv0CJX6LAHD3TchFvFFUxJ14SxCwdurWed1+VmVPQqHtDTk KXo519NHq1m8CIm30Z186CMtoGCpeDw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713905149; a=rsa-sha256; cv=none; b=Wp5fy4KVxDo9vb7pR48wDtkrudH1z4cE3b7vIrPU4JcTS88MGfak05QVrmcZYL4q2gW7f8 i+pKEbXEIIwSgQadmVCcahHArI+ihnxhX4vrxgwhlXyaMyUmD/3jMGIDI3ls0CImdezSpR YNCUfP9vK8JeyuhQidzQEXqE4kJchHE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="CCq4/UnZ"; spf=none (imf15.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 198.175.65.15) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713905149; x=1745441149; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=db/jYTmQgIcatu4krOyw8W95WHarmYXRnUjtGzfjh94=; b=CCq4/UnZvcRo9hV8sAw55H90aUS50O/EyZ9fCvYDbb4xwal6cSWZtsb2 pHZFbLVw86QlBnIwIMHbE09vx/crq9DhhQfqUQWTbu9/0TeYQBHqTJNJY /hZ3xtLJLR6S2ft4PBqYJl97TF07UHCDryEtbbxyGC8tdMVUjA6NDlgUk oWk+1+1eqH0rUZhXykoBHCLjxgcrGm+O6Vznn0kR3YtOIZA7xFdoA7Sbu FZ5oIHmiKvugJzYgAJ64WBiK8D/1SWa/LBBkQW1+zNrz1WbS6K7Lt/wrh lO1MGw+qxkh/K06ZBq9dJkL16P7Euh1/z57jLodnGJ+SdUR6qsq1yZtdL A==; X-CSE-ConnectionGUID: MDtblxE0RvOV+u7QSGsm0g== X-CSE-MsgGUID: qCWn/KvDQp6y1da7WjBcMw== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="13300343" X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="13300343" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 13:45:47 -0700 X-CSE-ConnectionGUID: NBYlrgBOQnyVFlWFwK0ryA== X-CSE-MsgGUID: ykouW7uTR8CeUKKtMsy/dw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="61939027" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 13:45:45 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rzN1K-00000000TFX-1yu0; Tue, 23 Apr 2024 23:45:42 +0300 Date: Tue, 23 Apr 2024 23:45:42 +0300 From: Andy Shevchenko To: Johannes Weiner Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Rasmus Villemoes Subject: Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function Message-ID: References: <20240423161506.2637177-1-andriy.shevchenko@linux.intel.com> <20240423111000.aaf74252a07d7e7fd56d7e12@linux-foundation.org> <20240423203020.GB318022@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240423203020.GB318022@cmpxchg.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 97E8EA0003 X-Stat-Signature: gq661mfoyuowqz1g36ua9g7syrtk1ek3 X-HE-Tag: 1713905148-766493 X-HE-Meta: U2FsdGVkX18fVlFuIfC7O7E3uA/ofpiV7PSdZ+6IQDGJ/ZnqTwscDs0VaEPNYUwiXCyUaIA9VVFac7OVQfrBI+TFwq5T+/E6paoIO0XHxbTt+7PuJ0k7MEefltl/NhTIBdMucK3tBZwhOYAq2oUNSobD3KDrft7Mfrhq5G677csR5Hj4AY2reLyTkLI4XLLKRFfdEkE2tzvdbmqVOGHGnZRdnAAWU+w1Ii3DnTueRmKeyP06GGEVBKhuP/vDftrly4X0342hdOyWSVmIeLu310QgFwkZ+CnNsKzdjDNauZtNVm5dPh+krX4Lfgg5AOdmL1ynU6XAmQOqDO8gtokvntMqs5ZdErULIqfdmfjVN7z0YairZ5CfIPkuG+wfPscdCEIH07n0XcW0LYBXFGKAIMuWct0I7a2DmezDZdLAKvd/wQ4GdWqgB60RTbOGWHorDyP5SDhNbbQ36RBZZi58n1lH+NJATMsqRvMdm7SMb9oIZ8YY9kf4yDq+zjbi7DhZVazxRmpFIim8xGvKpbqKiOljstrs1RaEl9us3DUaecbuDoj1zbhjbM7/sL0vNXL2jNaof3xwEMNYIVQam8NhSiZUr3N9IDPyvu1KlU6G2kCr9rwc8o8WjwA5SgATT7VQqrtmsii8mXpxM6DR0cwqoVDD9A8kLABPF8nM9fXl863N8FylU6CkelilCwrRjdvOfGzm0gDkALp5MnLguuhL4uYHGpreXOKiMgzzoOUcupx/1/DVQPKgIlWolkFADlR8BD8WBqLY028vxiAUtQ08SSKcpfOM81SUBez/dVNGSuYDP0aXvOmfFl9z3u5TecrTH9iCCtX3dQjJym0m7g/ovgpE4WZWY+WHR5rCtwJPFxkEHZQyDXQMot3dJScUPHEYIG7f6oK8qeWpuQ3NbrDOxEyLX30ezGsm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 23, 2024 at 04:30:20PM -0400, Johannes Weiner wrote: > On Tue, Apr 23, 2024 at 09:27:07PM +0300, Andy Shevchenko wrote: > > On Tue, Apr 23, 2024 at 11:10:00AM -0700, Andrew Morton wrote: > > > On Tue, 23 Apr 2024 19:14:43 +0300 Andy Shevchenko wrote: > > > > In some configurations I got > > > > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function] > > > > Becuase the only user is guarged with a certain ifdeffery, > > > > do the same for add_to_free_list(). > > > > ... > > > > > Thanks, I'll queue this as a fix against "mm: page_alloc: consolidate > > > free page accounting". > > > > Thank you! > > Thanks for the fix. We switched most callsites to __add_to_free_list() > now, I didn't realize the memory failure code was the only one left. You're welcome! Hint to the future `make W=1` should be a must during development. > Acked-by: Johannes Weiner -- With Best Regards, Andy Shevchenko