From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0CD7C4345F for ; Tue, 23 Apr 2024 17:26:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 311C66B0156; Tue, 23 Apr 2024 13:26:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C1A76B0157; Tue, 23 Apr 2024 13:26:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B0366B0158; Tue, 23 Apr 2024 13:26:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F34926B0156 for ; Tue, 23 Apr 2024 13:26:45 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C27F01C1504 for ; Tue, 23 Apr 2024 17:26:36 +0000 (UTC) X-FDA: 82041475992.22.C7995AD Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf14.hostedemail.com (Postfix) with ESMTP id B5DCC100017 for ; Tue, 23 Apr 2024 17:26:33 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Z6t8fl11; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf14.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713893194; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SFu4S4N401hobfWJm/IQ3Si2iVoGv8l6ArVO3sqzwjk=; b=KwUbKmJ6tsmbnch5oGtWeV2+9ohqfrJkVl9Jog0CNP0r6UAINI1TEqQs05XHO6KRDWIpeg m8G0m1JdXnQ7/N6XeMqXwqbutkm8P1JtQN2Zci6XErNg9BvZe1t10HPw9jw2I9qR3d1ztK PBtG3nS1xwdUPWgt0+kec7UEATycGdo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Z6t8fl11; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf14.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713893194; a=rsa-sha256; cv=none; b=mewtEpX5ufCTgjN3toTS8s2Kh8DzAf3KJCg487I3JmnXQkSnQEy1uFJyCpfSRGIUtUx8i3 PaMKoCevpRVGVKFDVWAaJffXNJHkQVWkp+ARG5VmhTy+O8IdqfsDBCSlYqL9xzfIPODPru nluUSIi5j5kmGp03B1sNllWDo0zOpO8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Cc:Content-ID:Content-Description; bh=SFu4S4N401hobfWJm/IQ3Si2iVoGv8l6ArVO3sqzwjk=; b=Z6t8fl11XS07USzn5AtUq0bvDN P0h97NL5GAqQPBlER+VhEN62gjSmxbxc4CCNgxGjVX4CkMYy/1/oNcd9I9rjvJsXLe6ke2Orv+2OY LqMNm9sBIMy7bUfQZwLZq83/AHc2q2yqAXpM9Tm9TzVC8rqX3eQHxENIQuPRiLwPXWsvq33eZxwa9 Ov1CZTC6upR/8hqfnXJZZ/CoCccgprFDewRi8waHGmjYOtobGIAYv+1K3hntFLzNroAOdpDX3P53f i9B/7GW0zd/qfWg5oRArZK7xtupj52WBLZujX7+eZAK58olp8WJ9M2B8WHnmS2ti+cfXAWyG/SXom UoCzNf+w==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzJuZ-00000000y74-1yy0; Tue, 23 Apr 2024 17:26:31 +0000 Date: Tue, 23 Apr 2024 10:26:31 -0700 From: Luis Chamberlain To: "Liam R. Howlett" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, hare@suse.com, p.raghav@samsung.com, da.gomez@samsung.com, djwong@kernel.org, david@fromorbit.com, willy@infradead.org, akpm@linux-foundation.org Subject: Re: Broken xarray testing in v6.9-rc1 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B5DCC100017 X-Stat-Signature: mtkrdwjauq11yr7am9fbmdj5aadkmiai X-HE-Tag: 1713893193-340559 X-HE-Meta: U2FsdGVkX19ZZJssidZDUMq7KzXmoMQzHyUD4lYA5OyxN5m+dliqWNgUCScp7FfUFzbCcmKmZwxF4moIDqZh3LxKxxTqmu5pvOKsYL8py55AXNC78ykRHDZT8VIA1ql3KGQNI6FvCF2zE8WJGGl6zQGAw8S3YTJqGbWGlSXkZUhXDimxO+MhoTG2eHHFlfF3lJPQcf5ReYUUTfpIL4jrre8bgkbsn6/6DVt9QHVks0VTcJqG4eih360xUgsKWGG1LSNDQNlZRQMDk80XCna66Fk8CiGfYnBUvxU+nXlZ+kk7NHxyRhF/gdW8xFJ1LYSk6Q7krYfHjuZgBxb/WsLwsPfehFy1COHeylZafa2ytSPST4T1nngl+qS+2LxBUylFwiXrJbz/5KXIje3gRemnokqxhuK3UVB85jozhGVMA39f8w9iB05rNMD6+LqgJTnLg168xqGcNPAafsui5HNlnuYjb3TtwxzsWUrYi3bkJoDpQnA6c7b1xWswrU0fiy6fViLyfMpEBZMjm8a8OoFzwbKT+lp749Vhm1ccQzjrTRMHxDJV7JCyf5X7fKAxvxevo902422ciZ9Liod3sTEksCRHDF8z1+QiuRn+HFB/XSDgsHyQDqQVvelDiNVsEfSIsL44RzfUfqeAiDDKd0BzfbJc29Z0qoVthYB94fbWwZ9zEE6JR2a40SrBy0+KIm2oorkgsQ3BIyczvka05RqEIJCgFIWI/cHUcCNyuQh03oEUPc2Iq8fW54nm4kq5luHgWq8zqFhzv4nWjLd9lboDl5ifCm+4MmcN+peQ88hyJSMOUiOnb+VNNIAyupC90jOlbPEQ0hdqLR7p4Ycf9F1P3Nr0iCBCTlNvulWsaesgZ4FkFq7of04Mq6synnqVxu6hvksxv2sguh2tixfpqJQ2M8Xux6YXyt+IbcdVNY9Ud/PVa39NqsoVsEc0215N9b4APLzY34HOo8UNh+7i/2V liBksKOb /Ae8xxOv0N7qBWaJd/e4WOjGikjkr/gFtgYTF7Sg8sY4YVbPcrDyxa0SXq01HAT8C0UOsf3gHpagXggWgy1vlCDV/V9Y3HgwG0RkE8v4QOwxj3JL23mkB8pAvgcA+sxljKm/WjpqSLioB5kevUI15FQ4u91St2H2zOneYUk2Mlz1PZiIl2BE7kjX2Rzf8iY+6W+eXubwlY9kpARzs9XWLP4OUFCxsHQ01hU60sST0Y+pX732lIvX+oLAu3T9Av8LqzzGDllprf0wDbtsbk9ToZqIAyYKer3aiC7b4/NrZsNin5/9ERArPqf5wY4whE5MEbhtU7V+DGk1akroODpE8Qq+ANZ+wLkSjX9GaMBJlk/E/s3I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 23, 2024 at 10:18:36AM -0400, Liam R. Howlett wrote: > Hello, > > Testing of the xarray using the radix tree test suite is currently > broken in v6.9-rc1 and beyond. A bisect resulted in your commit failing > to build: > > a60cc288a1a2604bd86d3df129f269887018c3cb is the first bad commit > commit a60cc288a1a2604bd86d3df129f269887018c3cb > Author: Luis Chamberlain > > ... > > Building in the test suite now fails in linux/tools/testing/radix-tree: > > {bisect/bad(bisect)//radix-tree} $ make > cc -O2 -g -Wall -I. -I../../include -I../../../lib -g -Og -Wall -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined -c -o xarray.o xarray.c > In file included from xarray.c:18: > ../../../lib/test_xarray.c: In function ‘test_get_entry’: > ../../../lib/test_xarray.c:750:17: warning: implicit declaration of function ‘schedule’ [-Wimplicit-function-declaration] > 750 | schedule(); > | ^~~~~~~~ > ../../../lib/test_xarray.c: In function ‘check_xa_multi_store_adv’: > ../../../lib/test_xarray.c:767:24: error: ‘PAGE_SHIFT’ undeclared (first use in this function) > 767 | index = pos >> PAGE_SHIFT; > | ^~~~~~~~~~ > ../../../lib/test_xarray.c:767:24: note: each undeclared identifier is reported only once for each function it appears in > make: *** [: xarray.o] Error 1 > > Can you please have a look? Sure, I'll post patches right away, this also demonstrated an issue in the test code too which I've fixed and will post a fix for too. Thanks for reporting it. Luis