From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6267DC04FFE for ; Tue, 23 Apr 2024 16:06:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBB986B0126; Tue, 23 Apr 2024 12:06:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6B296B0127; Tue, 23 Apr 2024 12:06:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5AE06B0128; Tue, 23 Apr 2024 12:06:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B9F946B0126 for ; Tue, 23 Apr 2024 12:06:53 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 11BC04105F for ; Tue, 23 Apr 2024 16:06:52 +0000 (UTC) X-FDA: 82041275106.13.934E0FA Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by imf23.hostedemail.com (Postfix) with ESMTP id 6702214001C for ; Tue, 23 Apr 2024 16:06:50 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=K31vZVpd; spf=none (imf23.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 198.175.65.10) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713888411; a=rsa-sha256; cv=none; b=XhCpG8uOmv+yi5BSdy5935J6Q6ikRCNUoT/QjZ6+wspLngcfJbmsEqOiH6CyH0tRaxsCCX jhnNq/qV2sgIZBAVk6SkjDvkHJHEplxDjdddjiWPvzdyTV6mIXsozQTfZmZ2YflS1IHe9e L3N6gIS7vvx1qqvLAeRWdBSPOvkzxRA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=K31vZVpd; spf=none (imf23.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 198.175.65.10) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713888411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y+YCZPqNPiTc7RKIgM+7jokb8NTAPiIU5gt5Pz6pV3k=; b=cYCZxbxIb9rSXGOHGDqJA4lGIixHADXdc5OXSXdx/W1HJxVPXmqVALShoF9OUytmK65aKd f5gIilqUyLmoRLhrREQrqXqj3P9HfyXz6l9dbWbupGp4cL+ZeFMpA9ZXLPwQ342wxm56Gx wUkSz/d4DXpZjbMehaIGafKNcGmT4zI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713888411; x=1745424411; h=date:from:to:subject:message-id:references:mime-version: in-reply-to; bh=+GPI8MYmRHggMkNqqlNDqdxueKptVdz/4mNIdvW70SU=; b=K31vZVpd18kzuOODBpX5oexhavRUI2AULhWJg3dXPSIg0XF3HJUSwLgX TevOfXlga/4q9tlRL2ZpCmr5N/xuQ6x6UOQhBpVQDsQ4F0l9pMucxphw/ 2ElH1zF33j2/KcIZd2ecX3a/k4il/wQgP4uWdY/x7ZQrAkyWChkE6QF3h PxlcWcHAZKzsiVYUW3YZM4SRmGAun4EMUntIqxJH/1CoEKoD+9f3/0ssb Z8CN+HrxYt8Ig5VFoCcvAF6XAfKxdx4sXCF47qR5gslQMrGjX8kWq4P1N NGRhHqkT1VFOHYsTqBsPGdlEdriK7dBbgHtdIFF6712SKOewW3LtOs1NR w==; X-CSE-ConnectionGUID: y/KE74I8TPir98/5lqPQBA== X-CSE-MsgGUID: LwwW+VuJQ2eEKUJ5M/MhJA== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="26940105" X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="26940105" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 09:06:48 -0700 X-CSE-ConnectionGUID: CsZkNFG2Q1aASJYgHTE/vw== X-CSE-MsgGUID: XGIvMRGoTaa6Cio7AGICug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="24932596" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 09:06:48 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rzIfM-00000000Nzz-2Qij; Tue, 23 Apr 2024 19:06:44 +0300 Date: Tue, 23 Apr 2024 19:06:44 +0300 From: Andy Shevchenko To: "Liam R. Howlett" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] mm: page_alloc: Avoid defining unused function Message-ID: References: <20240423150622.2526825-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6702214001C X-Stat-Signature: mc39qd8mwt6ap3esi3wgrsnb3kh8awx5 X-Rspam-User: X-HE-Tag: 1713888410-617676 X-HE-Meta: U2FsdGVkX1+/IHohtc8wAvVAM1nTpltsc9UFuiC3EBX+KL1LqDasczrflUC9weXwfEEHzFOi/ueezCKtITn1g1MLV4Mm8kUW28IzSjnfxYGSwXkW5VRvkChkmFs0SEHa1Wc72DznlcleEpZumjRQJez9sDRG4BMhttw11gmxiXkHBTFwWJTAS7PpJFEjsIV2ZUwAEZqlcP4A+EzRnjzTXukSNqvpKwLHe6lwdTodhOr1VqmoZjSU7N1hPLxQz8OsIJCcUzWVUIQco+xScbgaJctBkXni/MIoYRHMSZcZgjvmuKgyG/TDV0a9UDF1TcWx3QaYIAkoClT+Fd4jaeRgb+Wky1IdAWPZsYHCwdvkRzubzEFcOKPEq8Z9Lc82Z/V8pbu2/ByWJWGLYD/xFEEc5kvEmTvD/wU4OUwvc/NCbXoy3lTi5wLkiLpshg3zC/g+B+ZAHhItJgGKDbTwKmtmlGdKnfDEwUVuKjSeml5pIQanZECc1HAu456pcrUyMOP4Nn8ga5gIUe27ROY0fKtoQBqGVKjIG5DoKOsRRHZDdpWkChE2DzNpRcGQAzZg3FV64zfPu7bo9bcQA+7l2MBdYp7zG7oHZyuDq9+/11Dm7F9a865pgpvM6oipIgwx7MuKu58vWuHeaBYJDr2sM8dj7Rse62HPKxkV3r5uSJeByo3eQRFhQvJ6mkw4Io2wMM5RGyMfmN2paLhmCcFkwFZYVPrq90sxvljVsWM78jaHV0z88m4P7kpgfTP9eH50NA7aNeUQvfO/7pfFJcoyopR2z4CY5biSCQnTzGM0uIpSoMPTtJbkt8C9L2+ID417rZmCEBoFhGGOa5Z53u4tTxUYYZjN/XDZh1IhCrUgpWbzpZW7mOqFJLCwj/qqr68Vxa3YQct1+jnfYscIQayq9hFdqh3ca3H/TngW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 23, 2024 at 11:55:49AM -0400, Liam R. Howlett wrote: > * Andy Shevchenko [240423 11:06]: > > In some configurations I got > > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function] > > Becuase the only user is guarged with a certain ifdeffery, > > do the same for add_to_free_list(). > Why not relocate it within the existing CONFIG_MEMORY_FAILURE block? No objections, I'm not familiar with the idea behind this helper. -- With Best Regards, Andy Shevchenko