From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] mm: page_alloc: Avoid defining unused function
Date: Tue, 23 Apr 2024 19:06:44 +0300 [thread overview]
Message-ID: <ZifclKTgLDujzufz@smile.fi.intel.com> (raw)
In-Reply-To: <f3qr7e7nmith6i4dbffsxvm63wappv4nl4d7nuto4432mpcec3@t74zh4amndir>
On Tue, Apr 23, 2024 at 11:55:49AM -0400, Liam R. Howlett wrote:
> * Andy Shevchenko <andriy.shevchenko@linux.intel.com> [240423 11:06]:
> > In some configurations I got
> > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function]
> > Becuase the only user is guarged with a certain ifdeffery,
> > do the same for add_to_free_list().
> Why not relocate it within the existing CONFIG_MEMORY_FAILURE block?
No objections, I'm not familiar with the idea behind this helper.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-04-23 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 15:06 Andy Shevchenko
2024-04-23 15:55 ` Liam R. Howlett
2024-04-23 16:06 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZifclKTgLDujzufz@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox