From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 107AEC4345F for ; Tue, 23 Apr 2024 15:56:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F65C6B0121; Tue, 23 Apr 2024 11:56:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97F566B0123; Tue, 23 Apr 2024 11:56:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81FF46B0124; Tue, 23 Apr 2024 11:56:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5F1086B0121 for ; Tue, 23 Apr 2024 11:56:43 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 19107140532 for ; Tue, 23 Apr 2024 15:56:43 +0000 (UTC) X-FDA: 82041249486.24.B5B3CE8 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf22.hostedemail.com (Postfix) with ESMTP id 3D559C000F for ; Tue, 23 Apr 2024 15:56:41 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WC8z+BSh; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf22.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713887801; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TiXJwUhPMkjGHKs13WSq0NGz2KDz4IaigXpr6ZbxkHA=; b=VnwN8ZtmFOf/U/1K+DqF2bhvKOK15cc7qIhagHDS6mJLjbCJpT+7FWYy9C+81w2oQ5NVeO y/4o/Aayk0gr79K6dZKONemiY9+x25iwwv3O0dbDsO/BfGf2EzZhokAK0xqGEktDy0mJSG Wf0T366mgxdjMSIZ2rYCqXetXfwDi7c= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WC8z+BSh; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf22.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713887801; a=rsa-sha256; cv=none; b=L3MFbnB/FlJhV0n5Nv+8NTBLhpUhqueKAML5b4fjEw1cHVfUALEnYxWr4lN7TcUxbiohuk B/3sXEzGLRYLYNAT62yAIopytYgatKCkhdP91oQBQpOtr4kUaKHjKKCH3rWD2aSVpIt4pU YMFMlxE/vE5jAbFkfmxiy3rHAEKE/Do= Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6ed2170d89fso4457833b3a.1 for ; Tue, 23 Apr 2024 08:56:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713887800; x=1714492600; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=TiXJwUhPMkjGHKs13WSq0NGz2KDz4IaigXpr6ZbxkHA=; b=WC8z+BSh0y1NO2Fe0SDuAL+klKU6kmrsbWXnywmESooOy9ASaBQmFBSRwJmYsTO6uz jQLkidRD+6WDuc14u0XkLQ8pWLVW3t01aRitXmQgdv7QtUkTwFYMSZvGjomAKmChy6+B Q8pbHZht5wqhpcP0OxmbzA/n/zNfhjEMPKDSR43BDvowakDXZ0YegkwpxTZe8vA8IdLi +tHIdpCBBaAiPF73KVQ24qev0NgbaCJd5+EtYE7SavMfxsz6QJ/t88NxTHR2l6KQnsMR myKR6O0zt3DU3W+jD0ezIWHJKABzx3pkoOmrku2ku5620cGJigls3p7lahQCEjI5lkef zujQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713887800; x=1714492600; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TiXJwUhPMkjGHKs13WSq0NGz2KDz4IaigXpr6ZbxkHA=; b=kMzd5qvdbMjJwFX5Pyi3piZrc7IQGXFfVSZX0CR3FTxfxvBo3e8xbu2Ee+MBn0qhZX Scu5YAdxu/mkxMo4KTQN9eYOW4Jlu3oh8/6XTN6lvjILIcIoQYM/iiFPFOTwMfeA4xaL gncHlSqGr/C3OVhcxuKcb47YdYueOFOehTYeIntuh4ej2dEknE3RpU3onABCvo0P6+gD 5ajXFQy2Bpp+7+8guP3TGWL6o0DEEjmPp3zSVMuuSFQO/cRKY0gkpz9UK/xISdFN6q28 /2BPXNus1JD/iWUpfwo/rDPFxpPYPJdtxCHwg0/SROpdTYOkMqgQrDN1JS9HAPrERlji NJKA== X-Forwarded-Encrypted: i=1; AJvYcCXXZJC+BI62y4+7IpkMaQJMGtSXPYjjXBtWW8XjsS8C7zIAVswOS1MCmiVgKH38AxOlyTyZpnDGRtn4aNxlqEaloVA= X-Gm-Message-State: AOJu0Yxc6xe5NIarwtBnW8f/BYzkSTd7VJpUyGh8jzReSAyvxN1SHkoG nCQRb2WPMqOyFnOhMWYX2GPmSD18EUsHaJSDOFSueaXqylF9+Nb7 X-Google-Smtp-Source: AGHT+IEjl28DHNnTcDOKcrrQgkmsbyO0K1hBgAt0eVjjLJ03dT44w2VLFfYWunJLIKjDEVbIXfLeGQ== X-Received: by 2002:a05:6a21:2d8c:b0:1a3:a821:f297 with SMTP id ty12-20020a056a212d8c00b001a3a821f297mr4606950pzb.2.1713887799820; Tue, 23 Apr 2024 08:56:39 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:6f51]) by smtp.gmail.com with ESMTPSA id gs9-20020a056a004d8900b006e694719fa0sm10119667pfb.147.2024.04.23.08.56.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 08:56:39 -0700 (PDT) Date: Tue, 23 Apr 2024 05:56:38 -1000 From: Tejun Heo To: Jan Kara Cc: Xiu Jianfeng , viro@zeniv.linux.org.uk, brauner@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -next] cgroup: Introduce css_is_online() helper Message-ID: References: <20240420094428.1028477-1-xiujianfeng@huawei.com> <20240423134923.osuljlalsd27awz3@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240423134923.osuljlalsd27awz3@quack3> X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3D559C000F X-Stat-Signature: nc6wzr6cfrkog19qp3q736jbhbzczk9g X-HE-Tag: 1713887801-352921 X-HE-Meta: U2FsdGVkX1/yi4/0Uk1Mh2hkw/lTlz52p7QH/JIRW7a8JEBT/qiMk4pGt1QJsZdn8caAfGDXeo37/DL7MerGKel48q1Z8IlET56PMNBcIleJEOwH82WbNfm10JZB/7GkTkmOJQTsetu5oqDgVoChogCcbQ1Schue3h9lFEkUaD0GjHYNxYPVfFvqq5C4BJpUZMIwpRBekjkZkM1HzH8SjxVQu09e5ThabTFjMLoOICRAuNbADuFWsPPq9IlAVYcufJ37adh94sL/yfSp0SAxJVpTZqSsXPs0YCOrF7cEOilzQYwoepZXxIP9M4COTgsAAZI0e4vQ0plXJiGa6kt1mSRXG8ELAJP4huA2ecPNGR8d4u4mvXjpX8yNIcTnfD5W950Grfx5MRx/5JOLN/ku8Goa9txS0DEwqngbHV3xaF6mGcn21RcaHN2X2OUdqGKgPOh01A2nVCZsE/oLUQ0gtgVPJBT0mNsarQOp2CdJFsPwS1hVzJa6i/p9zfwKxQpb4ORn1+UbrUeqUJT9qtjgptRmCpcokkPWKLWSr8rGQ05UGaOKNh78IUYj59r7EmxboRe2s1yEWxIbDZl37THhVgZ4jHBslDOxJIVBguaQ8oOb243hBuNVDNdzZOOlciz5pgIWrVCDSczJIlpXKJ5chFZrdPrbjswubN7+sz0YotSoNUI8PU87yoflN8H+DQeFwXR5bgZefE1BcBEeXqG3luTVXkWZi8+sg1yr7eoKND/EPHsQhtjywPauS1lK42DeEwC8MYiou4bNgjXPyYQqGmXn6nv2MNVK9xGQj6B1NC1ofd2pCOJ2ddJqwwbiVa4vnfTUfVFdTJz6NGdcK+g+U9Ri8nJBbXRy1ZraXFjgXGZTveums0M6CCeEHokUGJHST2yudj0X3mGUghvb8dXG7/YQtp0ULGVXi5une9Z3+4aHPSOSfJxwUvTa4ZOLX+E5wSSE7P/Qgg3vXTQRPI3 dMtFE5/V L9jz3zHITNQFN3vSZL6gWcUpZycsEXQwIgpENsGqw2Mw7sb/wpyI2INo6kS/2ncXNAngV9uBZzmomOm/SIfqcA8BML4gXf8aCSmInLSFBl5PjnXehco2N/F/dsqAIwhBUnhzQL7efpL0L45BJmIjlbJBBNtFZBWNrbM9CmZ5TeUGKmO7Z2RuJwLSgbilao8H5sniB1HfvllPfvYgx+8f7zBO4uYuiMO5wIWTNnLaq49WWzLXyrCkSUzVHCS2T0WLP8PlRUoynM31Mt9C6NxBCTC2LzH3GCJ3ldcXaCOl/HYgGCten4eiPWU6YBdOzKxZbEFIaDLODeyaRRAb3RnXLMAm9JeqyCFETAUR/lB2OIeYuw47tXEJyoOmmwGUELYCFdXoY0fkuvwT3hj5UQ/C5Qxs6iyae9b+b9TWrJjqY3VjsjegErX7/4Bzdx3532Hf+bNCMKIMDSQnJohHWtCOHeZY8UQQ5X9z2lwHoKMQgQZ8CoFxV2xRl9EKvQqAVYH60yA4Yeevy5OEoYJC17qap8CvuzyGD4B1J6G3KlE0ndBYHmi1cXoQSqT3wpl/SLxPdXnN0mh34jqaLSUX+1MkMiS/HCKQiW44d2YgW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Tue, Apr 23, 2024 at 03:49:23PM +0200, Jan Kara wrote: > On Sat 20-04-24 09:44:28, Xiu Jianfeng wrote: > > Introduce css_is_online() helper to test if whether the specified > > css is online, avoid testing css.flags with CSS_ONLINE directly > > outside of cgroup.c. > > > > Signed-off-by: Xiu Jianfeng > > Looks good. Feel free to add: > > Reviewed-by: Jan Kara I'm a bit skeptical about these trivial helpers. If the test is something more involved or has complications which need documentation (e.g. regarding synchronization and what not), the helper would be useful even if it's just as a place to centrally document what's going on. However, here, it's just testing one flag and I'm not sure what benefits the helper brings. Thanks. -- tejun