From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E2A2C4345F for ; Tue, 23 Apr 2024 18:31:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0325B6B0167; Tue, 23 Apr 2024 14:31:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFACB6B0169; Tue, 23 Apr 2024 14:31:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF36F6B016A; Tue, 23 Apr 2024 14:31:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BF7206B0167 for ; Tue, 23 Apr 2024 14:31:52 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6BC31A1A10 for ; Tue, 23 Apr 2024 18:31:52 +0000 (UTC) X-FDA: 82041640464.20.F8316D0 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf05.hostedemail.com (Postfix) with ESMTP id C08DE10001C for ; Tue, 23 Apr 2024 18:31:47 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=WfiCVzYk; spf=none (imf05.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713897110; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rogg05ztOu4aP2/pn8CD75vsgL5H5uwqaxXujjk6r6E=; b=FjBYLoli1Q/u0h4cbV6cDj/6fvBXGzdTmU2E83KlZTeJPr3eUn4TxeFnYsip08pMytF8KJ t8yAXz6gDs9pMnHgka8SfHJnyT/eih6KrmqYjn3PjtlwC/dZAwViu0KCZEexiuoVtEqamH 4GmZDMoLdzyB8Bp/E6D2vdiKSgkedeE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=WfiCVzYk; spf=none (imf05.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713897110; a=rsa-sha256; cv=none; b=1aox+QKrcTnRpv9wO29XbhhuLx/rGgMJOx6xIxwDn3JTP5g0ZYTwNrbNFXZdWYBGtijrs1 lGD0tBZURaFAhbNwJYIJuI+jmlEaas3Lb6qtYIngOjr83h7jEpotXx2Zh8VLl3NagxYCm9 566p0y5AvU6BByeeJbXn/plc14UNUAM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=Rogg05ztOu4aP2/pn8CD75vsgL5H5uwqaxXujjk6r6E=; b=WfiCVzYkyj37KGe/1NcuIa1Hgk I9gAfHu6MCMw7NSXSor84TLrOU+mUG0ndyfzjVt0moZbaiRHo/8L+p3QYdcySteGNhcAPGJCKkoWj g/687Hepcmtf5PZKpuZ7znbxvUnMDD43qnPnbu67zfXVJS8SML5AtXvgw73tSyJkv3Nhg5awIIQnq 1JNMkoOZN3LoUHS53IUhOaxE7wP++2K6T0ediCLJbAhO11cNq5v9xJzhveqww2JPt0aKNdvm5A/Y5 rB55b5NewsYDat/UO4lQuhE8Q3txZ3JjdTGVGjV+Hgo05PhOwNnuMGRbC0LVs1cOtEcnZeCVZdr0F 79Ap4ebA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzKvd-000000018V6-22Td; Tue, 23 Apr 2024 18:31:41 +0000 Date: Tue, 23 Apr 2024 11:31:41 -0700 From: Luis Chamberlain To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Joel Granados , Kees Cook , Eric Dumazet , Dave Chinner , linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-hardening@vger.kernel.org, bridge@lists.linux.dev, lvs-devel@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-sctp@vger.kernel.org, linux-nfs@vger.kernel.org, apparmor@lists.ubuntu.com Subject: Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument of sysctl handlers Message-ID: References: <20240423-sysctl-const-handler-v3-0-e0beccb836e2@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240423-sysctl-const-handler-v3-0-e0beccb836e2@weissschuh.net> X-Stat-Signature: b5d8omfi8qhwiffxbgu196ib1ztu1gqm X-Rspamd-Queue-Id: C08DE10001C X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1713897107-15150 X-HE-Meta: U2FsdGVkX1/YDoqFEA5PP6tULpevXZ8WiEmkSk4iU05f027USE4JPD85Mxi4C3UlqTMisHSijGqJO6S6ZvPGgJrG1Mar225kUik6Tl2ahSgRDCrzSR6w1CN6QQWaxeqeApZ6CsU2PUzx8FigoCc1RD+kv/xpgj4bUccT7HXXmSdNpTyjFuG0A5dj49mIMIkxDKK5U7zE5ztnVhIW/Oh2Sx17SEM4QPSJhITfP69KzM7hUz0pQNmmF0TGiSmX52U633U6SQckhCK37vZUzEqXncfn+jPVOalgvJV9s6Ogz4vHcRQrx5pugLA8bzzx7WaGT3uNFABQbug9fb3d4Lt2cRhXw8WTBSRjB90KuNU/dqLckPoYxD4LCtA5Bqi4/01yoQZhUb4DMJk44dFC2LHV9Tv4mhpsTN2JVIsecXRkdNLl54mhCLySn2Bme46L8VnlsNnzHWPTOS1UBDZ+I5nPIOjOLYj+1aVhhVTLu7U7hX1jctKwFqRKy1uxo2D/kdsYmkvySZ/4QsjQkOHwWNd/LbG8wdEWj5XWusbYTxJJ8owTwl9u/JWOaR/W8gWQyPSTuPrIP3DwIgCqzeXTBzDLBntfDDYJ+UjsDFJUIW6DvIOW9lB/PqGcvfM1hH8p6lwCxXM0A096bUNgEQkPeCE2QNuNWA5S3YFXocPPVZFPh2Bka/yZaSw3wW9Kzdjbz/AVUzo3z1+Q8wwoQG+sXxCgotiGqCFa8eY+GLncQa+ynGrv1Pw4ZVxwtFQTIK4AfRq3CBiuKgkS31TVG5pKCC0b/j48VMpMLZTIDKn6QdGOCfdSDaNStu8LlqGsdyvoD/VP3EVgdFlXQ6UoPW9K5TgIw2GuAsCyBKW0oKjn85851M5HBn7TiApNOucXBR550/J/k6OTVFlob8LFJ9MCpv4pakGLVGyD/Gm2mHCqaIAjQukjzSTULF6PTMs2lmDc5isvIZlsOYa+2Fpf63cmdVF y3ZcqFnF bWujpQEKPNoCgUR3mE5RWMFe3geRgHbyeGtV3eX7yrrFPQg1LtoKdc0NVzBPPUI6iBOfRJwKYmuINnLUHG3/BsCfrOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 23, 2024 at 09:54:35AM +0200, Thomas Weißschuh wrote: > * Patch 1 is a bugfix for the stack_erasing sysctl handler > * Patches 2-10 change various helper functions throughout the kernel to > be able to handle 'const ctl_table'. > * Patch 11 changes the signatures of all proc handlers through the tree. > Some other signatures are also adapted, for details see the commit > message. > > Only patch 1 changes any code at all. > > The series was compile-tested on top of next-20230423 for > i386, x86_64, arm, arm64, riscv, loongarch, s390 and m68k. > > The series was split from my larger series sysctl-const series [0]. > It only focusses on the proc_handlers but is an important step to be > able to move all static definitions of ctl_table into .rodata. > > [0] https://lore.kernel.org/lkml/20231204-const-sysctl-v2-0-7a5060b11447@weissschuh.net/ > > Signed-off-by: Thomas Weißschuh Cover letters don't need SOBS we only use them for patches. But anyway: Reviewed-by: Luis Chamberlain Luis