From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1CC7C4345F for ; Tue, 23 Apr 2024 13:51:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63D4B6B0108; Tue, 23 Apr 2024 09:51:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5ECC86B0109; Tue, 23 Apr 2024 09:51:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48D546B010A; Tue, 23 Apr 2024 09:51:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2A51E6B0108 for ; Tue, 23 Apr 2024 09:51:43 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CA9E2120F84 for ; Tue, 23 Apr 2024 13:51:42 +0000 (UTC) X-FDA: 82040934444.02.61A867B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf14.hostedemail.com (Postfix) with ESMTP id 9F9D5100007 for ; Tue, 23 Apr 2024 13:51:40 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Ek/9j0ik"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=YAU9kVFi; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Ek/9j0ik"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=YAU9kVFi; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf14.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713880301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9nNDYWhAMUr5BYb/IUllkBXMo9i6OC9KEcl7WK30r0Y=; b=p9SwX3xqJqqMvY6mlIaPoj63sBXNS26jZill2K9QskCCHsCdLUbkDLg3Inc/iVzGW9eYgL kaAsoi7ZmTgvahkNl7vonj0l6kmunTv+8/OQSh6H1JDFeNC6/qowZHlKrKCc6P/4H6VdAX aYmBb8sYL82a8o3Z7fl5aya1l7Y9Fhw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Ek/9j0ik"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=YAU9kVFi; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Ek/9j0ik"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=YAU9kVFi; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf14.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713880301; a=rsa-sha256; cv=none; b=l74zxY2rr0rGGjTPRgzShfAksbGZvT9Y/oaJws++vhecGc0jq5m0+I/pz5JNAtSvRrLfij tArbpVnNBqwvpSlF+nxbyOB7zs7bwbehaJT9fBK661jOxlW8hSbTqD4BfSHKedBW53hgR5 deyYnumxEczM//jMOFaxsRJpolkidSg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 537AD38044; Tue, 23 Apr 2024 13:51:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713880299; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9nNDYWhAMUr5BYb/IUllkBXMo9i6OC9KEcl7WK30r0Y=; b=Ek/9j0ikEwb2fBivuYFM4U44EvCDJG4BmiVcPr55e6l2su5UYXMt8McNZThgnAVeKaxLW9 mZkOGkj6etV1VtrBskdx3yNFRBobO6GH4Y6WBpgQLkpyxCO8RazVCTCnFPptQ8XSWhZ4WZ OX2OUilka0BkrpG4XccEyqF/ZZbPtlo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713880299; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9nNDYWhAMUr5BYb/IUllkBXMo9i6OC9KEcl7WK30r0Y=; b=YAU9kVFim6OWfKlIDP6glcAJPF9QDgBZa+U7o/KzpPDBuWhJH/7jiJQQ7hpclD47t8dIYJ jLJOUB1GSKddWhAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713880299; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9nNDYWhAMUr5BYb/IUllkBXMo9i6OC9KEcl7WK30r0Y=; b=Ek/9j0ikEwb2fBivuYFM4U44EvCDJG4BmiVcPr55e6l2su5UYXMt8McNZThgnAVeKaxLW9 mZkOGkj6etV1VtrBskdx3yNFRBobO6GH4Y6WBpgQLkpyxCO8RazVCTCnFPptQ8XSWhZ4WZ OX2OUilka0BkrpG4XccEyqF/ZZbPtlo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713880299; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9nNDYWhAMUr5BYb/IUllkBXMo9i6OC9KEcl7WK30r0Y=; b=YAU9kVFim6OWfKlIDP6glcAJPF9QDgBZa+U7o/KzpPDBuWhJH/7jiJQQ7hpclD47t8dIYJ jLJOUB1GSKddWhAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 382E413929; Tue, 23 Apr 2024 13:51:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CxMaDeu8J2ZpcAAAD6G6ig (envelope-from ); Tue, 23 Apr 2024 13:51:39 +0000 Date: Tue, 23 Apr 2024 15:51:37 +0200 From: Oscar Salvador To: Miaohe Lin Cc: akpm@linux-foundation.org, muchun.song@linux.dev, mike.kravetz@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/hugetlb: fix DEBUG_LOCKS_WARN_ON(1) when dissolve_free_hugetlb_folio() Message-ID: References: <20240419085819.1901645-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240419085819.1901645-1-linmiaohe@huawei.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9F9D5100007 X-Rspam-User: X-Stat-Signature: an571hak8ju6a5tq7qqs4a9it8w5eguy X-HE-Tag: 1713880300-671261 X-HE-Meta: U2FsdGVkX18I7lD8TUvj6iVwL1RM5avlL8LGPabpgQ0S1cOOnW7y/TaezsiTj7hNT+SiBsvU4wm7fVVdZqThMhE5lARBIQqK2xmNsqCrNrz2xyA2Kv2C0rbDdpUazfIYIHhewI+e7Er3+iUkzA1ywR9CbqUFJFZkcEjjEE5HaqQwor029icote4vsLZAd4IRcFT95UfmeDmLgtguX97IWcX8gf2HZoOGMQR9F5vqlRZGULSAiJuurUkH0vgIazJQt2mehOeDAlJTye4NG5xi7lrcW8ScTvMcTqnORvbjOcj9Cc1TWdSnnbtXMYlkXXebFbPDw4n+Cryw5p16hrvVtf00Gkealq6rcN452zjMYcrRIDxaqoi1VlzlUP25SmsPnmzxZ2v9TAW/jLszYadnfb6RsgLpQGtFebYlQrSHjjUaVItH2xAXUSmABwPePlH/kkl05SbzXe3p/fo4aBM44dhZIQm3ZVZydr5T0kDrF1MBmytsIwfIjYUos/PUVpTS7E33a1psghJkAUtr6wFWKlVbrCzZzJseGkcKPQC6h4W1qX9V3gbrITsuIHr4CxCYQtqKv50Fn21v52tG64aMkxEB+L6xbO0F6pVzJ/+BZhkzRBe598FJbDpXaKKIaWMcu2CAzMi5tLJuY9WhkDgR8qHa1q/tjtssGwn2aDlQJZkGbXE1KXJCNQk49zr+ZpeozpMyKyYDeIWm2CM5cjbm/69lZj5PIrq3o7LXpQPmHPeAZmkgwOZiWUJ4RI3ApXaRR+wMXowN/xbx5AiZR/HT7xMUNsr93cRnZ0LHt8UUz9lqtWiLaAsSoZtzN1uM9NOfDdGOJ5UZ0ISeyMo3hI0KYJ1Ka/rTR2Mvqi/T67jvqU4XOK9sBhPyqMaBLoawg5EFaA2P8kDcGyrasuqVf2X+fBip4rNywNmmTz6yrL/vx7QxAe2bBhOQcmpWd5VvaP+4mtuTBhMJmMoAtKziTg1 zEIK9WId QhWxtSemND+CCVHaJFIuVGaqfGXqNKAOWyfy9GIWFQAYTonZ7uQYEqdM1CLIJihLjLjhnYBUYJEUY/pCj3ub4qNx8w3VpBd5WLbWYapvNwV+KAS+a5ysZDIwieqx570suK0wrs4hezjxPoPEVvR7137COI26+7SZTD5a3BxRHqwa43+MQ0atkA/PAiereojnTCVfyknZ36RCb4pMh1KKKm6AQHYGl1DqXDRSa/gQONpG04HqEOUq6KggoGilfRsbvWu7WK+yhwkJxV9pw5WKu/WekC+6Y4AA49mIQS3cHm1I64LdgihvZfQAUgIIaIT65v5hNGE7KnHLayg9S2dUgQAqfzvhPE5uEkxSxQFgVraub+iw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 19, 2024 at 04:58:19PM +0800, Miaohe Lin wrote: > When I did memory failure tests recently, below warning occurs: > ... > > Fix this issue by checking whether folio is hugetlb directly instead > of checking clear_flag to close the race window. > > Fixes: 32c877191e02 ("hugetlb: do not clear hugetlb dtor until allocating vmemmap") > CC: stable@vger.kernel.org > Signed-off-by: Miaohe Lin Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs