From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FF45C07C79 for ; Mon, 22 Apr 2024 18:32:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B4FF6B0092; Mon, 22 Apr 2024 14:32:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03D1A6B0093; Mon, 22 Apr 2024 14:32:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF9A56B0095; Mon, 22 Apr 2024 14:32:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C51696B0092 for ; Mon, 22 Apr 2024 14:32:29 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8125F1606EC for ; Mon, 22 Apr 2024 18:32:29 +0000 (UTC) X-FDA: 82038013218.24.6A85AB1 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf12.hostedemail.com (Postfix) with ESMTP id 908B540024 for ; Mon, 22 Apr 2024 18:32:27 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bMbx3Cwf; spf=pass (imf12.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713810747; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jp4tWIIZBYM3ces7VZbO7/tmznrBRVcZ3K4GAB8wt2Y=; b=trpQ7s0BRWuchvlKUAXG25z17g2QNZpODoL3uhveeKVfyzu69QKreIgUhQZzqMkp8q9/zV /662ieh/Ik1iuqudt6hQC/vDsCYn9mgv8vetcyT5Sys0CcqHKtDyyRxn4Bb6O+Ylp7eUIB /HErqEnp+htMxbDvePFN/1zdUY4Se6c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713810747; a=rsa-sha256; cv=none; b=ktC7VDy+SPi9uH9ncNqNP3Yjf2TxO1+IG//NYrIxCGDtfbOIpbkXE5Rb/gALxDRbpzJavE IcnuTSS6XzFnAxo4m2+IKhjV9RAS105+hSO9HxxYqNOuDGzBbk+loHfQSMw9TMbH0MMIHo 5TYgl77lrFViEb4O5gcmNbgrF60knzw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bMbx3Cwf; spf=pass (imf12.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6eff9dc1821so4677106b3a.3 for ; Mon, 22 Apr 2024 11:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713810746; x=1714415546; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=jp4tWIIZBYM3ces7VZbO7/tmznrBRVcZ3K4GAB8wt2Y=; b=bMbx3CwfTQsCef2bw3rkjmkR04WGz+KjllHuRie0hpeLftnU8kxArgrwNanW1cgr/J aYhcnTAu5a8gvc9MM7qP9N5FBJOPCHm0S+52BFRPVQ2MP+FiSgl7hIVgu8Oj2leUNXRu FvT/ut8dY3JP8CRliiOMxetZ0x2WBXoh0bN3e821/CAMJrH9I8PPNDx0ch4tcojZKwVR pumwekj2zMtiZrjQsdhcDYYl9/ggpcZ4N+e0wJingLaKU3WwPqQMB+KYRFolJp3PEMcH 1bDMqX2BzzwlU1EyvDVJj1zN1vz0bWRm46HtU4qzGMqxRygoInDukWqUrcOliBBviFmP K9mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713810746; x=1714415546; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jp4tWIIZBYM3ces7VZbO7/tmznrBRVcZ3K4GAB8wt2Y=; b=hNaun7oAlmP0NiUqvhlrXz/4R295A0sqg5DwpCdRCeIQvoAJO4odFf2rL7yKGdtTCn npOPSxe7KyIxbIE/VTzz9UsqeEwIMxiHkYvImj5Z8n/ghyK+GaNue0tdeSMw/xn0toKf wktY8x9gmMf3Up8otmR6GXtgtClFRKhNSVGSD5CJTu0HkTqskzUUymVD+DtHp312lr2T xS5rigqfOHHP7VHf3I3hr2OzklxCwWWoYflqAxNocX1UpzZF/pxv9amqzso+5uZeLAXk Yr9BMszFLYpHQ2zzEkgRT2pnw5Ufjh86MGC8/3zeJ8sXTlkqnPlAF3ExaZvsMF1zLdNq PimA== X-Forwarded-Encrypted: i=1; AJvYcCXiASbVIfYoYawoDahF4338wMl/vk8R5IL43Ry4vJJm2VavmMoQ9Mwuoxpi6MtsBrqoLi6b8RBaYcKhrmEMFraSeQM= X-Gm-Message-State: AOJu0YwwQ60ogJdGxaM7wML/Y4AyQ5MAQtJVFUGFGi9g6iJQX0zIvY2P K9YmBpRX1h/wGtv/W47DEfQdXaYCuaTS2EzBuPUUdU+y6juqHQ9FvJru+RBZ X-Google-Smtp-Source: AGHT+IGEOt+a28hbekcZo6XIaIMNWx1fqusnWq11yMO2/OJwWMObs33GeyJM/AjzIPbNeo5nFfhR7Q== X-Received: by 2002:a05:6a00:188e:b0:6ec:ff28:df5 with SMTP id x14-20020a056a00188e00b006ecff280df5mr14077978pfh.27.1713810746140; Mon, 22 Apr 2024 11:32:26 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:6f51]) by smtp.gmail.com with ESMTPSA id gs9-20020a056a004d8900b006e694719fa0sm8419722pfb.147.2024.04.22.11.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 11:32:25 -0700 (PDT) Date: Mon, 22 Apr 2024 08:32:24 -1000 From: Tejun Heo To: Kemeng Shi Cc: akpm@linux-foundation.org, willy@infradead.org, jack@suse.cz, bfoster@redhat.com, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 2/4] writeback: support retrieving per group debug writeback stats of bdi Message-ID: References: <20240422164808.13627-1-shikemeng@huaweicloud.com> <20240422164808.13627-3-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240422164808.13627-3-shikemeng@huaweicloud.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 908B540024 X-Stat-Signature: t64oe3qnfj35no9bjea787e6j8aunwoi X-Rspam-User: X-HE-Tag: 1713810747-696259 X-HE-Meta: U2FsdGVkX19b1YFjr7B+143XoQDf/kaaZPfvCmgfKifqqcWSkc71A4ZINEaTKf6Wtrd0qeDlfIbGIUKWdZVo1gZgzxhuyh2nMzE918PUh5MoQWzIi5fjMqMPed0Q6KLgcW6t5YU12oQC88ju4v08YDlnUTP75gTR6bukG0FUhIEHgRE3ITVB+EfYt8bYSApfLHo26YZRleXPWSp5JtWAz2jvKTbvOztic6WCAdE6oVcuwlJD/2WBLkdFB/qnNB8QND6QeZJB/cdUEHcOb0h1Ufe+qOVsVZMRWoci+/Wj1Tne+ZR7mMLOimrl+J2TsNPk3hks+QZZwPTm/6NTdoC4mqM7tih+PE+IDPbKBG23N5TZC1hGeUs0XYLMSd7chU8KE5cg4v7stYO81/b5APpjX1yp3bWAPqqJnH1a0ttJEmDcRWMUXlkGFbk5JW84LkMHc31XoPW9vSx01+p0IQRscfg5DJ/um97nFNnY1hv+bLxqHcFKXhA+3J6BFpt8RadRD3Wbz/wwH5eJ6Mzr8mnYbsm5Re/JcpBWpd4yfpVxV3nKQaZrh4GVL6m06kp0ijMGxOqeh3vOaL53M5Usob3STI53EX+cAxNMNbSEfh5wI5cHFYnA7HV4U2hSGTjjKjxbb3Gyoz8/SA78/wxCSYhNHy7KZUeJsle3vikaWcFD8KBcidtfOmoUiuTQ2rc2RwPIHTCFZKrCXBFJu849y8HiBppMl+filPCWh4NDYO/eFwYxSfmuE+1omnuE/4XSHVa/ZB1QzoLpZRlVBA/maBefgJRw+M/5p9YmIvJAYamOHfK/BHwz9BgkNN9hFT7wYypSMyJq6GdeXIJ32YKKsnrbvn/ec1Lhw5//izMXK8scg+GgxUHofKYmDxjZXS/LJROvXCXvJK9FzQvzQuHBtpXFKqsnlgZqrNiT9Cu+OQfG0U2d+/7PwYe/FiWdOKhp5tB/w2O90ehGsmT5jiJsOMz jBQGxv0f vw0JAM1nQiUZfbAfL251owLhyPGYUA/Gt+4FDO7Nv4FEzNpvSwhqnwIj5lkZ7ejYeQULswG/+eBce+LlC4y/trV0yuRB/M8YEBvPmH2hcXqf6MLPnV43MZ3Pg3oSaobRKPDRDEQFkvSLCXbRahpegbqqi7RmpSfzv+qBnqMFLy4srH889B+J5P6hDnZJzdKZQQRRvuIQkFYpOVAHYrYdO4fe8DCviRB6Vs9StD5YVDWd4pMW9ndnvJQ4NOaU/vcs5t53TgV1O7IsonSzLS2W8vh4i3OiRiQ13Ypn3XDQSpgNri2y6QXI3rluNQ0CLlhs5I90H5uvK+gSuuL5ii/dMxDYVCy9gQjmFNTnH2nuRuWnzESmRftN+tv7mn2sakxMUK47yFyrXw125ZytQYzCvtfdJjz2ZCoHSZR6bRRne8bfewMBUl1zisQCHyxC6AeVsyKT7Jcvmj98cKeEwFRT/kW+/tdGhBTikfQs/ERtaD97drEOdm57K6PAKk8FbEu22eD/XwwUchSYlD/NOJcQ8Haf2a5QPuB2evuUplSfsGWcGPbMbuFHOoEKwFQ5QxlwUzGpAvbBY7vpi/6jR/Raby9AEe+yWQj9ItN857BV7Saasq7uN/QBF1Z8wY06Gg6Soj948eefTWdq1+W6JKawrLbqxMSHe9L14u1eQltAtKshwEiNJfld+f97UZ1gaYVOokZPn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Tue, Apr 23, 2024 at 12:48:06AM +0800, Kemeng Shi wrote: > Add /sys/kernel/debug/bdi/xxx/wb_stats to show per group writeback stats > of bdi. > > Following domain hierarchy is tested: > global domain (320G) > / \ > cgroup domain1(10G) cgroup domain2(10G) > | | > bdi wb1 wb2 > > /* per wb writeback info of bdi is collected */ > cat /sys/kernel/debug/bdi/252:16/wb_stats > WbCgIno: 1 > WbWriteback: 0 kB > WbReclaimable: 0 kB > WbDirtyThresh: 0 kB > WbDirtied: 0 kB > WbWritten: 0 kB > WbWriteBandwidth: 102400 kBps > b_dirty: 0 > b_io: 0 > b_more_io: 0 > b_dirty_time: 0 > state: 1 > WbCgIno: 4094 > WbWriteback: 54432 kB > WbReclaimable: 766080 kB > WbDirtyThresh: 3094760 kB > WbDirtied: 1656480 kB > WbWritten: 837088 kB > WbWriteBandwidth: 132772 kBps > b_dirty: 1 > b_io: 1 > b_more_io: 0 > b_dirty_time: 0 > state: 7 > WbCgIno: 4135 > WbWriteback: 15232 kB > WbReclaimable: 786688 kB > WbDirtyThresh: 2909984 kB > WbDirtied: 1482656 kB > WbWritten: 681408 kB > WbWriteBandwidth: 124848 kBps > b_dirty: 0 > b_io: 1 > b_more_io: 0 > b_dirty_time: 0 > state: 7 > > Signed-off-by: Kemeng Shi Maybe it'd be useful to delineate each wb better in the output? It's a bit difficult to parse visually. Other than that, Acked-by: Tejun Heo Thanks. -- tejun