From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1629EC4345F for ; Mon, 22 Apr 2024 18:23:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 851D76B0089; Mon, 22 Apr 2024 14:23:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 802F76B008C; Mon, 22 Apr 2024 14:23:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A28A6B0092; Mon, 22 Apr 2024 14:23:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4B53F6B0089 for ; Mon, 22 Apr 2024 14:23:26 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C07BE120580 for ; Mon, 22 Apr 2024 18:23:25 +0000 (UTC) X-FDA: 82037990370.15.B797F7F Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf30.hostedemail.com (Postfix) with ESMTP id DFA5980009 for ; Mon, 22 Apr 2024 18:23:22 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=URnca9ku; spf=pass (imf30.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713810202; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xUsfrPuknVn2eEWdEAnXH6GuTxJPhPcdp068aUQPL6g=; b=WuDLWNKBE5MD4kBJ/ixwGCTPkwygYk7BLJ1/7dvvqynSRewPAnFYUD0SCjblVtnUdEwcB7 h8XepCGrAqcRL+fq936OR1z84Or+pWof4fhpbJaFelrjEWDshSpGRG4YitXR+Wfe3unIbT WV0HbwmOCuVbnKkufTAUEdGjFIEm+NY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=URnca9ku; spf=pass (imf30.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713810202; a=rsa-sha256; cv=none; b=bGn+u32EZxboRf1k/3azTTcbYIjtpDm8tPeSN7nGEwJSCeh5hCoFV05CoWugnjDi9A7fW7 lg6pC2VYxVRykaH0bX8LvZMq2xX8q+85i4AEDNP+b6jIl5LMc2FFmWmPjhZkvXHeWN3ROx hUh8Y3FRQLgxQW2beecGv2FOfZy1WzU= Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1e3c3aa8938so32728435ad.1 for ; Mon, 22 Apr 2024 11:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713810202; x=1714415002; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=xUsfrPuknVn2eEWdEAnXH6GuTxJPhPcdp068aUQPL6g=; b=URnca9kuS8gXZs5mX95YfQadzSpSi42VtmzDyp+ejCDzv1aJzKdr+lWvsgGzRYFB4l 52+uXjw8tGpq4Ni1u3UBoic46ZJt0MKMF+F7g3w9Yb0p4AEdYsPNBhOeNu9uNy2yyHol QG8nY9js/qDbGTYiUNwmgyrmMIe9qTXuWgumd2tAaclWwX4Y1+6xKd+FhQir/HS19asd SKE47ey+bWOu0IX/b1Mz6sC55VMbLEUMEfrC10+idUKttuWN9xOKEnihbufGqQNBaZwl QeT3J6bt27x0lFOZMq6rvZOTbUQlmAKeoOhR60Jwt2iLV77mLmheDe8Ho+OhTHg1wd91 gTiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713810202; x=1714415002; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xUsfrPuknVn2eEWdEAnXH6GuTxJPhPcdp068aUQPL6g=; b=EfCen25mxtXsVPvCcFaUvLuyjekbXkTURYtzW3QoLwjblqnBPIvrwZNJ1gg8SD9dhw jUUvL/SLkekWjLni/LpHr0weqa8CKyBzgpq64fOFC94DAmYhPghqsmUsUH8z2YThlFas N3vzYCffDhNHBYlegb6pCTmIpBTJZAqnmBcZDIslJpqOG0C0KdzYxgDcIO6YSnLqcGlO yS0uPUqafw+KiP72t2yYax1UmynuFjDSJxXGu4CIpEACpb1egpW3LAoG4KZilKIJKyHF sVAwqwp7UMBlMiWGFoyVoAJo0fTixSN00iNPxifKBHO3e0+ezq9EtpRu2/GnUr8SFc6+ O9JA== X-Forwarded-Encrypted: i=1; AJvYcCUURVQ1cTfV/SiLhU2zTAK8SHyQpLaeD/xkEd3HzqAXLUbMlz9yLz9b0J+Y/Z3T442xN+dryHYgBwJeC+TujPl94ig= X-Gm-Message-State: AOJu0YzrsSZ3grUzc78MRuZr74muQ64NbjTyRpyzGvNlwAbLHFXNN49u qbCHUerAbWoc8XiYsbRDQhu1v7qXBKNIs8duujD/ABrwWvKcCoow X-Google-Smtp-Source: AGHT+IGl2na+Kyu0mq52tGR00SH6ZD7tOAk3YfMFtBzHcVw5HMV3aXGaOENqOKZ/Wql9wnBHRG0HKQ== X-Received: by 2002:a17:902:7489:b0:1e7:ad7a:6a81 with SMTP id h9-20020a170902748900b001e7ad7a6a81mr10287853pll.49.1713810201435; Mon, 22 Apr 2024 11:23:21 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:6f51]) by smtp.gmail.com with ESMTPSA id e13-20020a170902ed8d00b001e4464902bcsm8432872plj.60.2024.04.22.11.23.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 11:23:20 -0700 (PDT) Date: Mon, 22 Apr 2024 08:23:19 -1000 From: Tejun Heo To: Kemeng Shi Cc: akpm@linux-foundation.org, willy@infradead.org, jack@suse.cz, bfoster@redhat.com, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 1/4] writeback: collect stats of all wb of bdi in bdi_debug_stats_show Message-ID: References: <20240422164808.13627-1-shikemeng@huaweicloud.com> <20240422164808.13627-2-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240422164808.13627-2-shikemeng@huaweicloud.com> X-Stat-Signature: qx8onbtjabf6xsi517d66uj75u16sg9h X-Rspamd-Queue-Id: DFA5980009 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1713810202-681886 X-HE-Meta: U2FsdGVkX19zbAqq9aDfaMdRDC+Z1Admxj8mCVf/3RTK9W1fC3Mw2BNEDBNo8MqBn+/9tp4CidwmcvskIRt6WAcAerVmp4UpvXKiYAqSLxhMtJywI0Ou992Bnii/G4SgHhn1CAaBZl6Bu3yOxS1Bkxtzi/g1K18L035kHtyW5b+LLHrSiTznYdbFe78Cd6MUpmMXfrhClzAX0TQKwQBfpUcN3/YWdR6mepAFmXtN1dI8CZcMdv+CptkB6z9R4KleNkR00UZNYA9UWvjlnK8g5350AvWxoZRz5Smahlu7Iledf8KLLVvmApd2ddge1S0v14Mouwzi5dU5y7gGm0lXp2EnMME3wK4NuAF8A8j+x4q872AU8d5CJuYx2AkAzo3ialKU1/FQbC3oQVrVJJHucXwcg9JAlTWyDRMH+JP4vM6OlmemUjugqklk/CUDguW6GhKZOd/6/gAvebVAeF5oAaywDB4/thc3RovQoxrEgxKJEvYrsx8BvoMKeCD430sS9oLCWCXkC+zX66whfYgF+UdD9SwY1DqNVOOoALX1UiB5LhN4UFu/zypfal6evWoHqa0QBHs68zErtA5XHlLIH32IoPbGCi3F0yY4QODcv1gUvOL9SPJ8KaN/7/OmkDYsgg033CaL5PJarLK3oUCpcKiYHeyqh1VA7r/SBjmQsxKykl/HQSnRfoMQT/cQMCFrWkvZi4aH/6ZH1WZWbmeMN32EVOTa7uUXW8IMsOwBz0sERzymd5l23aaIgJjj6YeJtYNkiD5bAz7TALjWH05/n+f3stUrl2X+lYpael+TouTxFdZBo78jZkwyYhMfVdvEl1h4nQT53WwIHvEusDC8yEpMIiIqz/yDoBEv06UzWgnFCPtA4If8vo1aTT8llxar+1N7SJzXIiQobOcS3gKfy3gq9gQKIqRZ0cRhSv7/rKf2DDwgmi23toeYGmz1AM6F9jogro0bQzmjXL8iTYk ZhMXrJta DPMxP59sTNnyVHDfZqHAI8znt22pRxEhBKb5UdYkd+EL661Bz0sjPMuaN1bk4P++Mj2qD2aIBtbuqkwyMOjGeH0pd34TyeH5cWRtD2fevP5kqcDJWNSCR3Ykzih2MAbY8lOdudy+eNhntoyzbhM8uf8nulji+xKIlt28PqT0MWT87TX0dr0npA+tO5s/wfSGdbAgZBzXdZPFo3tcOcvHu/BmM0rzJ6xTxUMIEugX5EvkA+Adrs5pDXZhIQPGVqrrTpUE++W15v5XAxoWg1Nk/t9NFN4/Wt9xXbF76/ed1MlhoNmEl4ziB1zmSpM2QiPjVoD5AjGnh4Z5XWqHgWLtB4RTtm0ah46P9oBiikq9lWJcFdVSXVRJlAzwWrgMv6/RF4LXYwnYrkIv1aWZ+cI4tHRqMD6/I+lWNI1Aa0HPNOFl72rQQ55qthd/+HAUpTflQCU/20f8nOutHwdVmI71F7ps71juzGcTl9mvoCT/N1ia4cCueXre2UspfBNNm/9qjPECXSs7FhW15xRaFSujkUuMqb7++tnTI8Y/gMemRV2GKGqaUn061yzpKmnV5ejIMwef3zZ3cYsmubbx6j2/hSECz96LUZhsHIFOrP25pKIIYyWkjI2N6SPlZNFtX+GGxB8cxMnjCAkpB8g/rJ9Ks9tmNPhRiYb7IaUlOk0RKFbsO02cpKyJM1ZTCFt1kV4wOawNGsuFSiXZS0gW8JvoQ7AUDBLo+h4nanpTEbEcSCzFWPh5hfLDZjbXhvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 23, 2024 at 12:48:05AM +0800, Kemeng Shi wrote: > /sys/kernel/debug/bdi/xxx/stats is supposed to show writeback information > of whole bdi, but only writeback information of bdi in root cgroup is > collected. So writeback information in non-root cgroup are missing now. > To be more specific, considering following case: > > /* create writeback cgroup */ > cd /sys/fs/cgroup > echo "+memory +io" > cgroup.subtree_control > mkdir group1 > cd group1 > echo $$ > cgroup.procs > /* do writeback in cgroup */ > fio -name test -filename=/dev/vdb ... > /* get writeback info of bdi */ > cat /sys/kernel/debug/bdi/xxx/stats > The cat result unexpectedly implies that there is no writeback on target > bdi. > > Fix this by collecting stats of all wb in bdi instead of only wb in > root cgroup. > > Following domain hierarchy is tested: > global domain (320G) > / \ > cgroup domain1(10G) cgroup domain2(10G) > | | > bdi wb1 wb2 > > /* all writeback info of bdi is successfully collected */ > cat stats > BdiWriteback: 2912 kB > BdiReclaimable: 1598464 kB > BdiDirtyThresh: 167479028 kB > DirtyThresh: 195038532 kB > BackgroundThresh: 32466728 kB > BdiDirtied: 19141696 kB > BdiWritten: 17543456 kB > BdiWriteBandwidth: 1136172 kBps > b_dirty: 2 > b_io: 0 > b_more_io: 1 > b_dirty_time: 0 > bdi_list: 1 > state: 1 > > Signed-off-by: Kemeng Shi Acked-by: Tejun Heo Thanks. -- tejun