From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 604F1C10F15 for ; Mon, 22 Apr 2024 19:12:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1CD46B0087; Mon, 22 Apr 2024 15:12:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCE696B0088; Mon, 22 Apr 2024 15:12:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABC3D6B0089; Mon, 22 Apr 2024 15:12:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8C8E56B0087 for ; Mon, 22 Apr 2024 15:12:08 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 36DA9C0ABD for ; Mon, 22 Apr 2024 19:12:08 +0000 (UTC) X-FDA: 82038113136.29.9756A4E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id ECC6240017 for ; Mon, 22 Apr 2024 19:12:05 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=N+TAVYd5; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713813126; a=rsa-sha256; cv=none; b=PnIras+E9x98o7PBtvBd0fpbK16NRygGO+UMVUNe2k4wv7UWzPFNMyKlj0DZdAxytmYTLz NB7lA+ewcVnUm8EEPpEMZPWeM3aLY8y9NICCVTaZZ0S4KaAb8Qn9j7pF2oTo2jslVKrv6R /APuI5S0hRaZFa9gkqYuhre0P/rOFK4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=N+TAVYd5; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713813126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Lvwto3yehD40Bt0byCkThGy+w+BpMURn1Z2lSHOmbVw=; b=OOwtpy6PfLDzu2lRmAMyTZ5t2iwPSJDiZpOKbwtUqRrw7uHFkiH0XbSFl0CrOrSIQtGa4u IvBuepYcxakY1p6FeqIpuYMUPOqsAB6tzkBhGzBCxZMav3sZDYsi/dUBy/iKm1PRZJFZKz NK0iHydZADTUvs2JIP17hwle+pDxnvQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Lvwto3yehD40Bt0byCkThGy+w+BpMURn1Z2lSHOmbVw=; b=N+TAVYd5w9IVNa3GMJnn30VXie VSO+0vL53tVLzJT8RQf2Fpri3uH4udAiQlloJryYgSG25HZAC3hm4Df+kyyWBcDrqzYNOnr0bk4d/ HHn+XFc1VljWh8xDEclpEGpKCgR6i5ty95vh+p1neVki7O5VQhnNYZxyqhSihopbHL9E6abaZZcfe XvzRcbjfr51GEjjHH1Mma203Gu/M8yTBkhba0c51WQiwjYu+uz/XqrvYF9AUa4HQ5czKodBkuE2JJ 2ymRqIRjOBeoMyrJwYcPxy6monmSfjXFe20ptd4FciXsBReNBx+WvbJm0emeuEnwcx+fN7uBpANoH WKBlXnJQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryz55-0000000EneE-1Jwh; Mon, 22 Apr 2024 19:11:59 +0000 Date: Mon, 22 Apr 2024 20:11:59 +0100 From: Matthew Wilcox To: Jianfeng Wang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] mm: huge_memory: convert __do_huge_pmd_anonymous_page() to use folios Message-ID: References: <20240422181216.91938-1-jianfeng.w.wang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240422181216.91938-1-jianfeng.w.wang@oracle.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: ECC6240017 X-Stat-Signature: ym8nuwt9snngi71qdxkecfdnsfs1hx3m X-Rspam-User: X-HE-Tag: 1713813125-868920 X-HE-Meta: U2FsdGVkX1/zPTMgy6Yx/+p16yMcz4RGSc0EB8ttjw8kXkqL1x7R3j88i6VPbSZASAtyhCMh2I2kUVSvMQoQoibby6bM/PpJBctRx87vTeLgdsayfxnodP6GJbax8fvC2RHQDYMu7HwIgYyDSzIS0G/rO9eT5Q20J8ef9+qlTnKmYOOSDF9ivDiSZp7W3rhQjW86tpLlPW0K6fxDMkoEMBWWls95rCAEBzIWks62uZ8L+93wQMuAzHoS17duqgZnP0JSjFm48zyGorhLapigGjxu2DCcxws+L5anP3PcgSLE8xIGOs285eWz5uqoOIPJCcdMBBw+Glztd9yq8zgWs6hQ76CAWQX6iBRLT20S2TMElWnMmeKta6bwxTlOo6VfxiHDHMyru3GrdGw6P6CMP/ZY6dEboXDs8PFK12X7BlKX2yNKVEHViU6F2CuGThVjiS9ZvtllHF+sZ3+AltlFq21MVy1MwmAOV2YDUn0cRCE/VQY07J5SWjuqFVw+/SiLXftF4veIR2Ji8Z1igxhLPTaXy9lPDCw9P1gQmhpMQqnvCngo+KU5qJZRA68JZmgwo9oj3aoBnI8ym1pStIgp2cteaQVXtqG8F43xAa+1s0S337hHZbEr8JvzdZ1o3/LIzDLh9phkX4YEK0P1pLVtE4MOXg2NlxCu3wtCC2kjS2j/Vf7NBNnssP/P0YvaXXAEr+RXNWcngvBeBJv58LjaKaDau/7gu26B8q3RqNWHNIunvcIriK9PNsDug6GqEw8Cvz7yvVDVRBLasirVYsmeM7lxdZ9Iad3U4cE9BeXy6Zj4xON9W87sRWFYm83Z/lBGNMCP3HK/iLdFJlXnwzYFaxvdMrmtJlP2Q5PO8TMqFH1V1vfmXq3VAbmoFxOCGXjYjd+sZenHbu+WMbHdfg4EZ2kBcm6YHfjcMXeuZGNrlfg3M06QcwJYySuQhznonJ86xidDq0ugymM6z2WHzuo yGU9FE8x a3ZDohu+PMjj9VOvgwjXh1JkbZz78I5eXGFyYAuvYNuNnVjh44VZIRYDfV4fvO6ToeNdZc/WlfZB4z9alxWaMopJBg6xaUUmGmjkY746YXlqs1AEji77dftDzS0IbVrmNkesNLJDM2brmTKKBNCyXITRMJCHTaB0SXuNVfpRy3JDvDwzz+JW/ARYVcg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 22, 2024 at 11:12:16AM -0700, Jianfeng Wang wrote: > Change __do_huge_pmd_anonymous_page() to take folio as input, as its > caller has used folio. Save one unnecessary call to compound_head(). I don't like this patch. It makes the assumption that folios will never be larger than PMD size, and I don't think that's an assumption that's going to last another five years. Look where you had to do &folio->page: > + clear_huge_page(&folio->page, vmf->address, HPAGE_PMD_NR); > + entry = mk_huge_pmd(&folio->page, vma->vm_page_prot); For mk_huge_pmd() in particular, you need to know the precise page, and not just use the first page of the folio.