From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76126C4345F for ; Sun, 21 Apr 2024 13:53:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98B476B007B; Sun, 21 Apr 2024 09:53:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93B8F6B0082; Sun, 21 Apr 2024 09:53:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 803556B0083; Sun, 21 Apr 2024 09:53:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 624E66B007B for ; Sun, 21 Apr 2024 09:53:50 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CEF081C11EE for ; Sun, 21 Apr 2024 13:53:49 +0000 (UTC) X-FDA: 82033682178.02.C3C63CA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 9DB8020013 for ; Sun, 21 Apr 2024 13:53:47 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xjpn8XjZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713707627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b+jUsjGDmhtvuuLbduZhoA2W1kls30xM9fMZ8LLiv7g=; b=OKAEUFgXaveH5IAoFjbNMAtWGBA2VFaNuqyDXZ3aL1S9WbRtsTrH7wYKPNqwS2lOfyHDo1 +/ZOdRATYPrmA86JbtnYsfPKDmJPeUCDqGJggVWeApz9Es7KILV3GMGa7celjzGKcgh6c+ czFIsuqVm80uBddZwJ1PLfugWoPr/r4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xjpn8XjZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713707627; a=rsa-sha256; cv=none; b=W9ylLC59LTK36PKPu7+kpyg6dFrW70I7xGNHpvKUy1ZcqSxGnegTJng5p74AErTzuHhebT JUr9zBpYOcKnT8CDAI8v0hsr3b6/6d0Fe7alVl0Ds6dokyBdk9ubZ+JhAO9Z65CcaPobld BFZKUkidWhAMzdzeE4AYFKco+6SUmMU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713707626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b+jUsjGDmhtvuuLbduZhoA2W1kls30xM9fMZ8LLiv7g=; b=Xjpn8XjZc1Oqet1MlNl7yuZJ1WiOFxrWtGJqmPJFcNsYZFNjZdEQmYrqt1N2MKYa3w1Uv6 zYnDIzVQqiYjIECoKl28IbPF/zd/G4Yf0ERH5cbbK6mHYHTwqPeg9dX7GedxDtqWUieEgV 6sKBygeM76BuZpXeh93qRmBVlN/KUDA= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-sUmJ1iDTPTKGHsD4tkI4OA-1; Sun, 21 Apr 2024 09:53:45 -0400 X-MC-Unique: sUmJ1iDTPTKGHsD4tkI4OA-1 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-6f0556105beso1019433b3a.2 for ; Sun, 21 Apr 2024 06:53:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713707624; x=1714312424; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b+jUsjGDmhtvuuLbduZhoA2W1kls30xM9fMZ8LLiv7g=; b=qQDBWoYb2x07t4FkKwfBBkeOcrYQ9HuloILhA4o9YK3jZgirj/WPzDMN7EbhGlFTBO S3KQuqEXBPPkUxaOcbbHkZetgzbAvy3KQCbKZvGfaQ9lyu/KBIg9gwlF+S+6SesCZoKa gYixQ9EYQFTe0GtruHqle+oWE//Txl45G1n1WGnuojVUdON5Qs7Jfxi7rYGQ7x46yvad yHEmbBXXgU1npPvHcQ/Br4+rYQu0/kwGSPZLXfaZSMNcIvNtefgObMBq4HFggi0xCXTB lOoJoiAeYZkoUhrAvYEMKgdVL4ryVTYwv1Q7Nr31iRnbuQecwvUKdfVyYYqGxSrK3GmG qYrQ== X-Forwarded-Encrypted: i=1; AJvYcCU3MV9mgFKuKbiliYMFClzlnxHQ1+TFmBq0DSJAdDaTTD9zgateFsDOBcIcILk1UoDRVzJu4FkgtOqiwfVGk0JzNag= X-Gm-Message-State: AOJu0Yx9rqzuISgJyWs7u1RePNE2T8wAynWqjqOw25027EYzIVP+aXIe JY+A+w/2IiP3L4RnRiG+9VDgofVNjs5MSZFptSuoqcM43yXoZ86s4RHS+/9h7c7hC8uOte9sI9N i79lN0PTMjLtMwiTDA0m6ILr9F7pK6uMU2xq1cT/n8jn3VIXLwJcNlHQ+ X-Received: by 2002:a05:6a20:1f20:b0:1a7:17d:8863 with SMTP id dn32-20020a056a201f2000b001a7017d8863mr8009298pzb.4.1713707624049; Sun, 21 Apr 2024 06:53:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjKh+tPE439gpEoiQgflxHTSfUFyrIDtdLp8iLyW1dPuXQFe15JUG41GL7U23CFvNcsE1xGQ== X-Received: by 2002:a05:6a20:1f20:b0:1a7:17d:8863 with SMTP id dn32-20020a056a201f2000b001a7017d8863mr8009282pzb.4.1713707623456; Sun, 21 Apr 2024 06:53:43 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id r8-20020aa78448000000b006e724ccdc3esm6179209pfn.55.2024.04.21.06.53.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Apr 2024 06:53:42 -0700 (PDT) Date: Sun, 21 Apr 2024 09:53:40 -0400 From: Peter Xu To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH v2] mm: memory: check userfaultfd_wp() in vmf_orig_pte_uffd_wp() Message-ID: References: <20240418120641.2653165-1-wangkefeng.wang@huawei.com> <073f3d13-5656-4de0-a62b-cee96f2b0eaa@huawei.com> MIME-Version: 1.0 In-Reply-To: <073f3d13-5656-4de0-a62b-cee96f2b0eaa@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 9DB8020013 X-Stat-Signature: 99kfz5ic9o8kyjftdtzbk6w45mhey8a8 X-HE-Tag: 1713707627-117917 X-HE-Meta: U2FsdGVkX182Xx5pR8kDvKWneM+Bid/tD/JVk+bRBLx306dSgrvT2g7ddUjLzx3ignszxGEuExauEJQoN37kGsbdLH267Nns5SWk1Ex/pC5VAr8HmRPy+eupxwtZPR864JhhEnLpuQb0pG2CH8utTsIwtSddsoDEHVfVa2QNvGAjs7ir1xJ9ZghLgsTBxEoNpPdqaGfwT9grJC9A+UNKkjLqG/z2Rneyr7BfcdCgfVpUPbFzJXtZxcX2smVo3ZIj6qN7MoND87lAhtrlSnfwAY5UEDWAQMCAo4Dzcx4eLVh3Yusl/wxHwvthiYi/Kw8mmBJqj5XbOC+FF988fHubSEEJudUr/dG9hjOoWqKjisSpqNG9eJb3f6c3ROMATvozm9ztLtpnxCNtmRI0pUJbgM+XLn96afqty9BcjyRE4CMnqis9TmVoVFtUqMAVdCyjZgJCaHKYhJlQXkfN8etpcrl8WQ2VuAUn/Or1PSLsRz+aQKupL4jGkcxsYMm1ya3+gK0K5vHOx/L2D+rDlW3wEBm0v8hO2sX5KoQBfRI1Gwz7kkgUV+pLYp+fREUdf/iCXliSILbB3hCMTTciOAS36zlkUH3MCeyxEyHNMK/mvjxmZXli2DUAtax8mR+Ksp3A18PyRT/XVjIYmI/cjXO24D7xZadJyJ3jHF5ATTzyH3zlWmzTotfwYDCD6avJIjslYYo2NQrcBitXm8qiiN2iyHmv8TcRnccRihBL8NCnvbcM3qKiuZ3Eua0QNjrSmYNU4JvZ/AqVAf7tETK3HndaIxsVczpjH+v0fgoINc81ZfxWrYdkEfvytaqBKgD9KIgeTdrRQy33ZWwbLCw2doDkMpK9YBlgSPKq6V2yFSuEwAhEuQDR9hWaC6NIL8nNQebF0CKbLjQFzrNOCtqIm5ZmU3HmRrZLjNojYXf2jV5cng8zknHUHH6APdUymK3+QePWUE4Glt9VUscYPtRt3Eu +QTNTKJs XoHNJKhBBIisvmfzY4lPSOCWR6ld39iL44o1GvnBZhOCstoWb3bgq5ffRcwit5RNkXfMdBYpXbQ/5DGTJbPUaIOrty0ff+YW1hziXKHBBJtaXOTjJ72JTaOEwguH8VDgTEi5uBY4Nf64KcpOQnuISecaCOvO28tH/wMvAnEbfpBQ8AdwaQP3li+NUP1IGq+XpHwoPX6aGi/I/S4ti7dDC51UpZqxaP27/vQIpTA3VTZnlWvKgfw9qZf/3GYJO1sY7VY8gTOCCrG1mN+zJN7KqxhB1LSAHwE6+2j5u+eOKGaUMuOMSvYtTnOVrlif22Wgvgd+9skorVYbjFqSVjyLhWqvZLcpGeNYTDg2iLJyM4KNzyDHCsXVsBojJ99JAhk19EvSyK/jXAZYUwlE8VSU3EZfQXlMo2rilq4p8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 20, 2024 at 12:05:04PM +0800, Kefeng Wang wrote: > The latency of lat_pagefault increased a lot than the old kernel(vs 5.10), > except mm counter updating, the another obvious difference > shown from perf graph is the new vmf_orig_pte_uffd_wp(). Curious how different it is. I wanted to give it a quick shot over lmbench but fails on missing rpc.h, at least for the Intel repo. I think it's because of the libc change to drop that. Are you using a separate repo that fixed all things up? > Moving it upper is better, and maybe add __always_inline to > vmf_orig_pte_uffd_wp() to make set_pte_range() only check VM_UFFD_WP from > vm_flags? Sounds good here, thanks. -- Peter Xu