From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D41C1C04FF8 for ; Thu, 18 Apr 2024 21:32:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 431C76B0098; Thu, 18 Apr 2024 17:32:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E0BF6B009E; Thu, 18 Apr 2024 17:32:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A83E6B009F; Thu, 18 Apr 2024 17:32:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0E2A26B009E for ; Thu, 18 Apr 2024 17:32:27 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AD27116015B for ; Thu, 18 Apr 2024 21:32:26 +0000 (UTC) X-FDA: 82023951492.21.1D7CA73 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf27.hostedemail.com (Postfix) with ESMTP id D956840007 for ; Thu, 18 Apr 2024 21:32:24 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kPdDMCBD; spf=pass (imf27.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713475944; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NRiieToRmsEDG6F1uvaO7TUM4yG+bNyfTeoysL7aDto=; b=b1Pjq2oVx07hSmafnUeFTgY0EkJJpCqarU52hli+ibjtZBMc4KAajEvn9jaqpmH69oagHM 49bqdrdCgy9I2vrLDkBdZcRZGzZARcn/0qhV3Y3Zr0xtvfEvJHJqTsESwi0AuXfv7hvVmM hHYw0dvHeOphIGCuo4Jz/mXZUOafU08= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713475944; a=rsa-sha256; cv=none; b=b5213ObZdnzGk0TrY//wTOrUH3gm96d57llPz6rAPcnyJCp0/Z1cPTVopzC9Eael1tS9IB iH7uzQsQOrwd5Wofl0DT8RX6YGiLtACmInaxqVfDyGO4G9kBGPknN8ni0+hrOovFf1+abD LXxIUoG0w2Ux1LWIl/z7cwrvzN/XmHI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kPdDMCBD; spf=pass (imf27.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6ed2dc03df6so1232309b3a.1 for ; Thu, 18 Apr 2024 14:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713475944; x=1714080744; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=NRiieToRmsEDG6F1uvaO7TUM4yG+bNyfTeoysL7aDto=; b=kPdDMCBDkc97ElvNuhwwwlZhB9vbMHPti47y25w15jY6RsrWlgOYCvA6NWciZ3UiPl QUh2ZNyCcQ7rwvqpeYXyImcvMougCLjoXAr5cNb04E+s+0iaH7G2Sw0ZlD8cOW3K+B0z Ltkh/PiMgozod8uEQP/AvdOR4TOBB46OUvzh5ETvmbBAK04KLeo5tDhOurgvopGxvRQH 6vSlZuDLNcG6sCuz6Z2c7nSNWC81KKOTqE3YEdOdeIv4dAIUEVy0HT1PJD1d9uFdQNIe S/49o7XVSAruVS28inB+/TCQa6Zubr74An8C9VkZQENBaJjfd+VfPFF7TymO1RgOUimU 9wtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713475944; x=1714080744; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NRiieToRmsEDG6F1uvaO7TUM4yG+bNyfTeoysL7aDto=; b=rtqHwlwhByyWuQVocWlDx/OCbA/fOqsXlPKr9U12P8Gzhuhb1SUNg8khZyw+jp3bkb +6p7UqcVwDAiRO9xpQHyFhdxPVBd7JoPGZtCkCMkAoN65P7F86auVjlcT1PS0Fc+armP 4d249DNU/JEeEC2PCn3wFRpAsLtLuMvZoo/db8nq1FIyFtBYkxb78Aizew4DtUf2choP VE8izXY6kfVcj6k268klCmgsvpuOM2RRZOm9GxU7QoH7yLJubc3SWcFzUibcO4tEBm7e YtkHkWVxV2JCoQpI1ltFzfJs+aFJur0C9eQjQyMoHQ5bMe7Y6OeloKz9fxZN0xUVCx9h N9uw== X-Forwarded-Encrypted: i=1; AJvYcCWuJDhCs7rHsb+xd4UdowVZEea0SxEh+fT7r3gNwMSExtbt5qVaS/n/Wlnkc//N1qX7xMlIAZf6hQQe926H6SD0igY= X-Gm-Message-State: AOJu0YyDAZWbibb02sWYPRU50Qe9Zp++FlzXfZpIdM66BuW1VgE6km6o fn/8UFyEpgw8Ag2ceW0vLK/aswih0ypVegGxYGwREDFr5GW+eLIg X-Google-Smtp-Source: AGHT+IGg3Ek6H90kBqi4Eps3Bk5lZgzA2YB7ziqHSvYYmonDJgvHOrg3Gm3HnPEfyEYUlnbI/fcF3A== X-Received: by 2002:a05:6a20:8409:b0:1a9:6c42:77f5 with SMTP id c9-20020a056a20840900b001a96c4277f5mr622170pzd.59.1713475943619; Thu, 18 Apr 2024 14:32:23 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:6f51]) by smtp.gmail.com with ESMTPSA id v3-20020a17090a00c300b002a005778f51sm2077328pjd.50.2024.04.18.14.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 14:32:23 -0700 (PDT) Date: Thu, 18 Apr 2024 11:32:21 -1000 From: Tejun Heo To: Yosry Ahmed Cc: Jesper Dangaard Brouer , hannes@cmpxchg.org, lizefan.x@bytedance.com, cgroups@vger.kernel.org, longman@redhat.com, netdev@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, shakeel.butt@linux.dev, kernel-team@cloudflare.com, Arnaldo Carvalho de Melo , Sebastian Andrzej Siewior , mhocko@kernel.org, Wei Xu Subject: Re: [PATCH v1 3/3] cgroup/rstat: introduce ratelimited rstat flushing Message-ID: References: <171328983017.3930751.9484082608778623495.stgit@firesoul> <171328990014.3930751.10674097155895405137.stgit@firesoul> <72e4a55e-a246-4e28-9d2e-d4f1ef5637c2@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D956840007 X-Rspam-User: X-Stat-Signature: ta1bjuxcxdtbi56gaac8b1fbniuqxw39 X-HE-Tag: 1713475944-280060 X-HE-Meta: U2FsdGVkX19XPUG2t2JPIftgnwEmfge1hI0ESDRSQEYly2oMCsULYAM/u6dAhB3BOgQqH0/8PZBIcTE2YLJEAtycCJS+ATLfpgS5kNrSTVBdNwh1x/2o2XL76w2HXmhvGeIjcKFpJzKgwDW3IuEFk64CeAx09nDYVkJ1i8u8oYsUjiXt8gA1KjDVlzPQbOGOrr1T50cQNA9NdFVmRPfe/ryzpscgjwPL164dLPY7DT9yhjTLZ2+Po2i1djEdVpqKhwliEzWhBIwlhKgV2Iyx0vmQKJPL46nLyQV/FNE8GTbhaD46yyzxsp3m8ggYWB08akATmZWSGal74Sy4NG6W9IBk0oQj238iBdlqkmD4uWSmtFWhqQ1GRPwOlUpzN3r04E8BDfX4BNeWhAOfLdetOpD182eIpttI5rxdLv5V00uIfNv0PafsaK9uogh7EDJ7NDdsZKB6eE/OlVgnVY1bsvRhZY9wuKj9VRchf20ccZ1EH3tM57G6TeN9s+dj/iEyeJgwB5/gUaMUE3BfllDX8FknurVICjjKXIb2X46Iz8U3ZBFxG6bDF0AtrJKzZOA+tUO5pKMW42+dtkXY7wonx8foyQqCD6NP34sxDqWA0+HYrQHdcJvr5V6HZoKUiLOPxq+RlekWSUKSEa3Ea4HPAj44fxDtXghdxUiAr7mxEC0AIOwh4br8MTvjttUWFB18wRyrWY+HwoWUsKQW/BftOE8r+1QbneRCS4Lbtb/YOzxtlBcBCHCjswgckkQm0YJXcRc+ign/k8wcEhd2Qw5FfhV7JwJV7/9j1IM9AS8fxub5FrC0mBxnOV3UB+h6pVFsGvtoBdUi/UDRV3M89AYE9BYMKR6fBbeozsidRV2apfYARQh2Qz4OTesbYznChEsYWH4irWCoLXXc44395MlZUnirVuWJDXcrHadTWRliYYARgOEIC/QK6DPgfbCwb0bE8UDL5CxoQehfsPFdRr+ 3Zw80Tny oluWpPah/EMVNgQdf5REEFfJa0oOf6VHhc7pJiWupMBGnAY8R5N4VuNMjV87+MTlyJnBUr3/Dyv//4RvxKR6SxCrV2znnMJCyd67uSRTdbU4AzgPH+KpTRJx0XHHJSA393TLlZMSaXtNmtxqqIoDG11UBwdB0+Vl7IY19xDz79DXqJ2Uk71KJanQFVRyvvN0wAHhlzNzc6HNRAjP9Zw0PG2YF4qMpaLqfRujcMvwo4+NRSJtrQUVgw4JT+QBUg/q8KckYEPKstg0aT4cqcauBOnMD6+uX0vHyIw0My41ihWH3W1ms0zvLt7MhQsMWvhfknX+HbfRhH58mqZKuSLG3RZsPHmRNTXUrN1+by/2z/+9JzmydXfjvM9bWjzvo+5mxF5X0YUyUxLy46fMS+4A7GtJohyW2ayAmQQuz3afVm1g5vsTn3xTb7ESb7yvFTxBHg8DlkIdwCZHhZcqk9z5I4PxX0Moh6gKqM5G6u9OM0D80jFnf8ZPhBLKO8jW36HZkbgEZ5HDXzY9YB9U/mi1qc2AzzowMvOoHETvifhrwbERZCtuUzpTJtDn0Xfwdevx8ZJf11wK9jAoSYhIqa0JPqtlOthT4d8X9N2jS373lqjOnJBo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000188, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Thu, Apr 18, 2024 at 02:22:58PM -0700, Yosry Ahmed wrote: > Outside of this, I think it helps us add controller-specific > optimizations. For example, I tried to generalize the thresholding > code in the memory controller and put it in the rstat code, but I > couldn't really have a single value representing the "pending stats" > from all controllers. It's impossible to compare memory stats (mostly > in pages or bytes) to cpu time stats for instance. > > Similarly, with this proposal from Jesper (which I am not saying I am > agreeing with :P), instead of having time-based ratelimiting in both > the rstat code and the memcg code to support different thresholds, we > could have the memory controller set a different threshold for itself. > > So perhaps the lock breakdowns are not enough motivation, but if we > start generalizing optimizations in some controllers, we may want to > split the tree for flexibility. I see. Yeah, that makes more sense to me. Thanks. -- tejun