From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9B6CC4345F for ; Thu, 18 Apr 2024 21:15:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 341966B0093; Thu, 18 Apr 2024 17:15:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F1576B00A4; Thu, 18 Apr 2024 17:15:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 192386B00A5; Thu, 18 Apr 2024 17:15:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F02CB6B0093 for ; Thu, 18 Apr 2024 17:15:37 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8494C80BB1 for ; Thu, 18 Apr 2024 21:15:37 +0000 (UTC) X-FDA: 82023909114.22.262AF92 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf10.hostedemail.com (Postfix) with ESMTP id B14FFC0013 for ; Thu, 18 Apr 2024 21:15:35 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UWJPJctX; spf=pass (imf10.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713474935; a=rsa-sha256; cv=none; b=UV8yvJQb3RN08WARVeXVUELrMokO/YyXTGgJ83o9AGJQnZtZdWAjEe7JDoDKReaM5qEg+C 6fk+XSywpfOYpgSKeKrz9td7UqdpuvzIv9tVDwntz4A9+b2TqIqMM5WrQDgZmBNk3iZKgw rSiJZvT/RYCssDARlkyS+UfxDh7gZZE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UWJPJctX; spf=pass (imf10.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713474935; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+6DT+/uHX76vAoe8Nox+BNf0yRb++O2cYsiA+2lRAAU=; b=Zh0mU8CBJ1aIyFasCsspNeUNr+0tVyfRt0E9Wc9Lr2Z2TdA/dg8y57nvTExLQbIS2uGzey ucQ6bcDCoG2iodJb6EAblyuj+t25MBqhZYs1xIg1cE6yKa346Dm+mnJwsasUu2D3bD+EoB voT7DQZaJVC/YSM3roml+HkLzIJCIeo= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1e5b6e8f662so11805455ad.0 for ; Thu, 18 Apr 2024 14:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713474934; x=1714079734; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=+6DT+/uHX76vAoe8Nox+BNf0yRb++O2cYsiA+2lRAAU=; b=UWJPJctXfCwrOmIAFNpn0ur1SMROsvPF0yth1lJkdYB/qqr8EJdcFzM4Mhk2HpJjB6 jzt4C1QtbCg6VwT82y9WtQXvjOXx1/PUWphr0EQi1WAel7ii91oUaNEehnvSqZSGg580 Y9aVv3opV3JyDOgJR61W+bbmG0J5wGp7uKzszjUtNGigySMwU8AKuUD4YTXZysaBvzKF 3qjUI9YrNqwQ8qJ+aPs75OjRCnAu7EenhOBak0MmdHfzS+pwaqqZD15T/ICOcC73Nu7w APvEC1z2PJAe6nzSrcc6/Vr4lcHbZ6TAWGvngtRnhtwM88jRghX/09kBBCS9FiK/vf4a hELA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713474934; x=1714079734; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+6DT+/uHX76vAoe8Nox+BNf0yRb++O2cYsiA+2lRAAU=; b=pLFnuxDaxxBj06p7Kv5uVPT9aFIvQwrANHsW6Fz5gXALkPbZUE9Tt/AFxY+9A1cxdB 3JA+9aMRYg2mv4Ek9V8ke5A2SZTpWfWogN+umofr2a9XaQux6yOBorx8ccROG327sNoT syT/Z1A3Hcl57eAGPyqMZ4s1qIcWpMQ3oMA/iE8/2pwfvoQPKW8gjBcjpfLbrukWxVQI 9T7IOk9A4DY4zAGw1c1NST1rxMjyOlzFDYZOibWRLCWCtAILbN+B7zfxOZeMvepOc5Bx KZLx9OicZps+hwIJj4aRdrFbO8yPBNwR/YISm/j8uDbKZIgr5P4dJn1FIRvDQdGqRFzd IQRQ== X-Forwarded-Encrypted: i=1; AJvYcCUw07Eu0YiS9GgzVm2LfgtN4RgnuRgaJPI+NtFk5FQxu7gHaE4AcIX+nF4XjMdhHBuSU9dPZ7oWsiAQROXdbozgqFI= X-Gm-Message-State: AOJu0YwlcS8gzqb96en9wK/jkW4/s4b5k8gFHyDVr/jE5zd7s3xT3ynr SUtzXkniM8r9iwKE4kBiRb1gBqlMcICrIDnUxGxLGBMflrSNBDeo X-Google-Smtp-Source: AGHT+IEioWklFEee85ZpymAJHFHHlrLqBFD3nxO91qEPXU1q2uXzgFRVGrx3OlWJBCY/+7TvQu/E1A== X-Received: by 2002:a17:902:db07:b0:1e4:bd90:f1d4 with SMTP id m7-20020a170902db0700b001e4bd90f1d4mr310366plx.40.1713474934334; Thu, 18 Apr 2024 14:15:34 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:6f51]) by smtp.gmail.com with ESMTPSA id y20-20020a170902ed5400b001e0648dfd68sm1961787plb.296.2024.04.18.14.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 14:15:33 -0700 (PDT) Date: Thu, 18 Apr 2024 11:15:31 -1000 From: Tejun Heo To: Yosry Ahmed Cc: Jesper Dangaard Brouer , hannes@cmpxchg.org, lizefan.x@bytedance.com, cgroups@vger.kernel.org, longman@redhat.com, netdev@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, shakeel.butt@linux.dev, kernel-team@cloudflare.com, Arnaldo Carvalho de Melo , Sebastian Andrzej Siewior , mhocko@kernel.org, Wei Xu Subject: Re: [PATCH v1 3/3] cgroup/rstat: introduce ratelimited rstat flushing Message-ID: References: <171328983017.3930751.9484082608778623495.stgit@firesoul> <171328990014.3930751.10674097155895405137.stgit@firesoul> <72e4a55e-a246-4e28-9d2e-d4f1ef5637c2@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B14FFC0013 X-Stat-Signature: scqs9ntsph76prm45bjfiffs8nj156je X-Rspam-User: X-HE-Tag: 1713474935-253799 X-HE-Meta: U2FsdGVkX18LvSAKEZ8Wzx0kjs7mH7427VxiIL3b84HFmsO7TSZEvT4wlH5sYsHWeuM64v14+9uNBIa5WDBM9q0BOW1e+lIpdiMdmOLAZ4K/XXc/U+82lJKArdJj7Z1ZiDbjMncS+1SeFkUgagFQpGE6qjiOS7BeJ9uCR7VdDDy9kKs5u66nsnJ/4KozB3KJNMwii/E2zg0Hvrcsjb3Cc5l5EbCoJGOxi3FexGtyceZJTz/Uda9GrO9K8/dV8q5D3P9wKW4OCI7kFJgiKdWgIiRof7Vtkx7KLcl2xURHwb/miSGCbYAjB0ZPbyshq4qXrfgUDIvjXjBGREaDqpFE5urZsuH69BkTrwjdW8UHOZE8tOaVP7CzkXL8dTC5GXjR9V/0tIVm2ClhvFJgua0mxFhX34UsKcYdx/1wAHLgGG36YoGkX7+o6HZ+77Rceai82Q4VR2AIgrO7K2j/ZTaJGTkNG5u+y9mEtDUHz8HyqmgjG+rDO3GhLime2u2uAJwLQVN9wQCiSgrv5qvofs8apdt6Kl70Johj+J+KroSEbl93PD8EW0oLJk1nuWpBxlXhwSaAD7ccHNdqsCKAQDcBYpXLoTFsgbLZVaSw2GMRxh05NAerJGCS09tYx5YaQbvq/G2C+6oCnZ4j0ayjvRs/ItThjnw4rQIUhGHnDkqE8nBYlVbDM6xyGE+IJSj/8tCXDfzncXcTU6KeXRV3pm0Y6iArRXeSqXTeJf9XcYpAwZjxX/1bjWPo8b4+R1xGjGFK9AJUSNb56bjlNQLV79On0bQuNMgXexkgHXoFC50LnUuUyrxX6Ote32vX63XK8bL3nuEOoRyOaxdw2g5AaS4fe3NX+NErCFSqkkuV/EFLiJMncOUY8GKY0MDNYYymWnZqw6VOjqoUsiYPqn+7RkYwH+rC58HnHKTNN6BG0/O4ZDXr/YJDAwDCPbEKrD1oiv5GHqSo1FvhAJDJjL55+LK HwldZgd0 AZVRN9JFXnD0ZF1OFHhMc4stddHkSU/SieqIwIL1IZFDalpiyNPG10WVlg2OtXhss2SvwW5gInwnAVcfotYvQ0csMz+waJr8pUSsIKtX4DR/H6gvhj2UFaNjS3dsgIPRlHfPsOeOCToSKScj7s/f64OlOV2LySZ42SBsEVHbrT//LXZM6Uf9JTPFJVArA2CyfKWks0z1BdFJzEUy0SgZheIqkeO+YhcZRP5mhvhiXmsG7V7fZV7ceeTwEBLj+lKF7aJ/QbjyAnYq78/mP15ROPtMtA7GPYzftp07jzE1wu1UbQK2RqLIg321u+J3O0oXDDAGsQBq6tu0ShWFS+/MBZ7wRQTJigUvQle+uGVv3CgZGY1cD6vJ+SLFu4HsxtXN2+QK1x9Xmo+hFm514dFnkI/gVLu2FK8sESciQw1yHoTnXeK366Ip/dLSPc+Nvmbf6PV6VE2WhUTqrCsPIUbwDHvtHVpmQC9GAusk26xi/jANwxYtYyQK2Pz6QhGOk9mU0XI+GYrtkcze5BZwMhCkjMUup7kIvNLyCTmFSdHSKpCzLLmt5QiNj9j8hSjH54SVQOcJDjTAgKM3hFGN6O7vnYiEJS9hm9/GKS+2QV80Yph0HIiE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.010623, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, Yosry. On Thu, Apr 18, 2024 at 02:00:28PM -0700, Yosry Ahmed wrote: ... > I think this is an artifact of different subsystems sharing the same > rstat tree for no specific reason. I think almost all flushing calls > really need the stats from one subsystem after all. > > If we have separate trees, lock contention gets slightly better as > different subsystems do not compete. We can also have different > subsystems "customize" their trees, for e.g. by setting different > time-based or magnitude-based rate-limiting thresholds. > > I know this is a bigger lift, just thinking out loud :) I have no objection to separating out rstat trees so that it has per-controller tracking. However, the high frequency source of updates are cpu and memory, which tend to fire together, and the only really high frequency consumer seems to be memory, so I'm not too sure how much benefit separating the trees out would bring. Thanks. -- tejun