From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB63DC4345F for ; Wed, 17 Apr 2024 22:42:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2470F6B0083; Wed, 17 Apr 2024 18:42:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F6E26B0085; Wed, 17 Apr 2024 18:42:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 048E76B0087; Wed, 17 Apr 2024 18:42:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DC64C6B0083 for ; Wed, 17 Apr 2024 18:42:00 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9BF5D1C0695 for ; Wed, 17 Apr 2024 22:42:00 +0000 (UTC) X-FDA: 82020498000.07.31BA6DE Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by imf08.hostedemail.com (Postfix) with ESMTP id E4B0216000E for ; Wed, 17 Apr 2024 22:41:56 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fhwHl70m; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf08.hostedemail.com: domain of yan.y.zhao@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=yan.y.zhao@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713393717; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u4SCowBjsjYE2l7KLSU8y8YvD19FSfStvapNOy+fb6A=; b=ZifQSI0WVah58ao+JBGuPMphr7UA4OvYo7DRwcXwZzOizpNbQKJHgUqLhlP9Fimm/NtTuq pP4Ltxg192Vw+Ukg7lOFzj5z4yGwSv4LNqCORHxmqmpxiFlSl8pB1UAC31vt8fXI3VTkm8 cZSnfICwHl/wdHm2Miz8fgwMLpSnqTw= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fhwHl70m; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf08.hostedemail.com: domain of yan.y.zhao@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=yan.y.zhao@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1713393717; a=rsa-sha256; cv=fail; b=7VGbtDSDqjwUf5BykKxUSGDOMlRLOnFGaXgdxV100zQv9TupTtr8sUSWZoWfoB4A8jp9j8 eIlFRCVTTvZpfF1jfL7602U6h3XUUe7lu3bWyCfp1bHAYmw4Hu6dZsREx4P3TGxjgrw97M 15kuhJm/P6R2SnD+DYTKQg3ekq2SwTU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713393717; x=1744929717; h=date:from:to:cc:subject:message-id:reply-to:references: in-reply-to:mime-version; bh=dzrQz88HLZ/us3Zzg7rJmq4xuOu9YKe4+QmdAQwnoy8=; b=fhwHl70m1Bo3HsNW6K4dwstVXInJ9JAkLl5OBf1OdLvw0z60khrN2R4e QOGXOXmL/PbHq5k9cLnInAKoNoFp57bXk/E3Z33ldnWYGE1UYY2886F3h ZB1IK/J2rHEfvkKmHFY0NMgcR+qdrsMzkGAsXKfimPN1AHPQVBEXtdt2L StawggauiHj6Gm5d9olpuK+bTYbEyRT++K46CjQ3hRPoaMd90XVgZO8y4 PAqyrKHkSx09pc68sH2lVVL5i5UvBW7G9ku8Oes1TqwWUBTwlaHrL86Bb uxoKMGYySK4Fj2RPPk4VXOu1K2lGFPqRO39/1UlB+0CwTEIMWC8HfhNIo g==; X-CSE-ConnectionGUID: wZ73VmYTTumcxUUjW0IXaA== X-CSE-MsgGUID: bnTcYc22SzSygMCjNXMVRw== X-IronPort-AV: E=McAfee;i="6600,9927,11047"; a="19472128" X-IronPort-AV: E=Sophos;i="6.07,210,1708416000"; d="scan'208";a="19472128" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2024 15:41:55 -0700 X-CSE-ConnectionGUID: Kw1elCslSh6fnjpdrgex1w== X-CSE-MsgGUID: XtPzNc7KTSSlYAxPgRWKlw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,210,1708416000"; d="scan'208";a="27351706" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Apr 2024 15:41:54 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 17 Apr 2024 15:41:54 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 17 Apr 2024 15:41:53 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 17 Apr 2024 15:41:53 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 17 Apr 2024 15:41:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Melwcjn1fdEcRykmkVSh8AnBsjDkKqcGeDF5yIVb4xob9sCR028zb4vbht/ckUPLzr473Qkmacr19ZFMy2KhIMFCcPeavevJDidjNoZSkhoWh4IOGnCDM/FdY2a0Xm5uUiMWWrNS+q/PFdJvMC6WAYyTbmr3ebhyaVmuGMXBuV7pGqCRYVJIqwvHiSyY/3AYVT63SQqMn5FSrppr6PmgpIEelUiGrStlE9rXrK4nqL6HKqHoXBYAPjs5HzTMbRfFi60kHvixgDgryuh4QMcPuTaThpNPwgciOeQu31F64jtX3xR6oyfE+hyYcvGBAjTqFXr9Lrf6ER8Mbupy6zIa0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u4SCowBjsjYE2l7KLSU8y8YvD19FSfStvapNOy+fb6A=; b=fGSrhIfBX5Pw9yy5p/iV53Waqc7isWDxp0+pfClsHvIg2nGnSBadtUN5Sgld8QJTLOZG+mRNpOSOLZijCa80gmLwC3s/B8eCTYAmlGqjiszO0q0bojOPL4gLA1jwK9Njp7kxdoTEL8mljVI0WFBsSkEX6StFwW29FN+Mpn83EhL5jgSZqa/rtxVGwkCk1bG8F185gg6iBADXoJauXundSGVhrmnpf6EIiSiJHa7BaZbzS971cP2hvtO5Z0OilUz1+NoYeB/0w1AA2WOM4R7yUT/CH2FTnZVyVNc2963xYMv14uz3vSpLcjreU+o16vB7IHpz6qAWNgHUCz4ipEjfGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB5964.namprd11.prod.outlook.com (2603:10b6:208:373::17) by IA1PR11MB7199.namprd11.prod.outlook.com (2603:10b6:208:418::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.37; Wed, 17 Apr 2024 22:41:51 +0000 Received: from MN0PR11MB5964.namprd11.prod.outlook.com ([fe80::6977:62ac:420d:3753]) by MN0PR11MB5964.namprd11.prod.outlook.com ([fe80::6977:62ac:420d:3753%6]) with mapi id 15.20.7472.037; Wed, 17 Apr 2024 22:41:51 +0000 Date: Thu, 18 Apr 2024 06:41:02 +0800 From: Yan Zhao To: Sean Christopherson CC: Ackerley Tng , , , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v5 09/29] KVM: selftests: TDX: Add report_fatal_error test Message-ID: Reply-To: Yan Zhao References: Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SI1PR02CA0028.apcprd02.prod.outlook.com (2603:1096:4:1f4::6) To DS7PR11MB5966.namprd11.prod.outlook.com (2603:10b6:8:71::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN0PR11MB5964:EE_|IA1PR11MB7199:EE_ X-MS-Office365-Filtering-Correlation-Id: b5c40a7b-cc5f-480e-deca-08dc5f2f8a6a X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TGDi9rPSqRucxtWSWeoX1Sa47saCg3lYUyeUjfFeF4DhkBiDEYkOn68kN6G6nH8Wj1iezuXmkWlhg5bvHtJa2jCc4+XfDmqZySfejLhFW+/Vfoz6eSYLKxIESyqukqJGRuwfoJJIACYAwQGVBJaqORfLt0eh8kdqrf1gnME30RwQLlxdrBS+VUP4aK76YWliI1hQ9FqMjLeGWdkWERk0RqbSABsdIhlcD5MO25IgC+yUQfjQgqjs2vKLE3sMH7dsRO7rOjHWxdibzsTQSLAFwCn1WjXdcylpMc1GBaaLa5iKY9suMlj1Tz6Uxnp7OdV5RsCB35YaMzsfR/sdUf718EG1DMuLy/rdLAac72Z3v1Km84Z1vPhYvvH3dBeS2ssLaoOfhsaQbz0lyI0XtoJFPNr0VDHKKL4nL42Yq0iXtkWNq0cqWc1hVqWmnn+LaxS4KUEsH5ofRndrXfcwZx7rTWURNtl2SMGN7T+hFFkhL58BYnASyAnqgGWMsuT7IpztPURQYJGQpQQ6AE/WYq92LA23EQ6aaMC919DKH3C34ehvUOisijyAC/UAtnkY5bIFJGoPutwfGvaXSkeA0IOFjaOaY2bkaUqIY/k86WJQEmEzvGjzla7zVIsDV/D3fGDs4bseokcs3sI/8rN0x+eoYaBzjxobZo4XdrUDySboQMk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB5964.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(376005)(1800799015)(366007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Js8wGY4gUZsBmWTwEhjvYsRSUkfQ6J6QB0RNcThqD3vBvrqXjxfi3nQGoJQu?= =?us-ascii?Q?OZZ5bqJEBbTLq85wQUWNOhR9cpOcDZR48c7nenSzfjr+t0G/840euMsfA1Iv?= =?us-ascii?Q?QC1kM70fKZXs/b5AGt1G9DqWJjaHdZc/dorjCZFIg37EwcffJFc0LqptfEHx?= =?us-ascii?Q?9OrKyPLm21LruwGLTRguypsbWram4OY4YP4IVj+qk2LCx57nCvtb0QWfxYjl?= =?us-ascii?Q?QznWeXQfqxxX4Qo7Q3vD3d1KxuN4CllDMoHX3iAvN+8wVbXEKOEOjFjHUi+g?= =?us-ascii?Q?pLKmEK+IVNl4dJBw0XB0P1RZzbA+bfOztrRaSdlx7ZSEQYm4SBTKZnusWEdB?= =?us-ascii?Q?j8TUHG9z3srPQtruVH2YN5dK2R2amKdMNqTlmRWHU4n0BbVaCskCGiL24j+d?= =?us-ascii?Q?QlT1R3zjuF1MZo9+enOOEBCh8HfzX3NdO2/KRLTyojIFTQibGNmPPhDjkKxr?= =?us-ascii?Q?U0Duj1E0lyqMma2UGI7h5FIQ+oCbTW1cc30t+fpkQAKtrOcE/duGk8UhuxPg?= =?us-ascii?Q?g/whMCy439+p76OLitnXnphMLC1hwrJiP+7MFqve9+mDUnEzk3004I3zkmSX?= =?us-ascii?Q?Ypbw6xvhkJRuwFWUlxio4cYfmb9XTeZrVLYfZSaVBZOy9MTJoiPLBxCpSY/F?= =?us-ascii?Q?svY7FbQyOTHxSELCnXuy66+1EqPeW6uSl4MRmIXQrFrPe6njosVIQ6G1UqsP?= =?us-ascii?Q?3w71qT3Ky4vPkAfI+PhFCL0HVVe46TnjisKY+3ntlSsN2PZ/cpvhjPOvRW1O?= =?us-ascii?Q?mqs3LWNyyACZ4as/ovRJaum6yqIvAYijnd6/YVmEsDnrdWcGT4tiTsWhdfzb?= =?us-ascii?Q?UO74QvQZufE8+jj1zI6AVTlmNr+Nhm4KSXS6WX3e9rNNjq4GlXl7fI0e77sG?= =?us-ascii?Q?fduI54gjN0TAbBvBNfHSYocM2wKhxpT2b2ugMtorEd2XHyv7I+MGqaRBhLZw?= =?us-ascii?Q?Cht2k8eOhWzi4bvNM+Y2NtTENcQcBFhbQYBo4cm65Zv3v3m+a3mmC0CZhdnB?= =?us-ascii?Q?FMRoI5qwd8yl37NdtB1Btpmm/1rI+hu9C/hcJV6dXDj50YDHXw4/fb5Ec7ya?= =?us-ascii?Q?nRC1EP9NeIXDfAfJc9Wml1IAaeI9FWSVjJWAMjbiIUhGNbiA0qd4L0wl+FVp?= =?us-ascii?Q?3V4HHf8r4j6CNLaoGrfqvCiF508/tVLz7Jx6vkQat/rqEZa9g7zO7+1yiRxI?= =?us-ascii?Q?c4NutHzClqdUSqs54xdcWZWE4h3hZvikflaaGMytouDF3zmljBMn0DoOC4Im?= =?us-ascii?Q?axxels0K5IW6eeyvVfZKtOIv3lCAN8kY1EXdRXemod/oCxpUN3yfIbi9N1hg?= =?us-ascii?Q?VHZjvtYPNcRNKhED1TJBKr1Nb8MC5OOvziHBLynQ6/OB4aLnYFFL+askZrbQ?= =?us-ascii?Q?FQGDNjK0rJcWEinONbqoPrPdhFlGWw9KXbOlekCsz9G7RSeKBCtXWnAw+lco?= =?us-ascii?Q?+WQSHpxDzrYF2A6uoKxw3rxiZ8wL+6Sm/qyJM+5U05ncmG9mr7Sn0DkbvDqj?= =?us-ascii?Q?5l1fdlEMHYvR7hQdMTGX55y7C4U9UxdXCJQ4WS3D+cQgJwGxTABs1dKO0Kbe?= =?us-ascii?Q?pwC/DvT+XxlBDlg8cSzrJsix3us/gtorf9mW3pxO?= X-MS-Exchange-CrossTenant-Network-Message-Id: b5c40a7b-cc5f-480e-deca-08dc5f2f8a6a X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 22:41:51.2362 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KlOJh6PLYo5c0Azez0Sw6LVq/Ef7JALH4nGkGZaAxew/nx6GyAQ7TdoxgMHG7mbZbQINlc9spQ/dSS9cQnCVfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7199 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E4B0216000E X-Stat-Signature: zj1tncksp53k8d8hxumcrkjpdp6akc4n X-HE-Tag: 1713393716-451206 X-HE-Meta: U2FsdGVkX18rQ03voVg8Inwr5cRXLazaKZiFb8fiASNnwBssKJCb5d0A/jfUT+6hHZ5KLn0iHk2dbWNaUPFSiUuw7MAn/1H9xlPLobOWv7nVUC5uqokxThBK/VQf53LMqC0RCrDWi3uYln8Iis9T1uxQb08fYjW0HY93hrFRUsMWCbUU5XqZIW/CYjqTyHBCvS62e715FO7omm3tFSS2fnKcoUJ+/ZGnGSTsqFd9Ut6X6dZXWYN5sDldSaKiwVtZw5E8CSti2x6TfHSjS+eoij2Q+MrJjzLk1jKLQk6oMwcbxXMNo5+RI0LMqRRD3B9MOoWVT/5a+/tvUvYpBW69Ymf4PJxoyhnIl0KPbEXzPZTcAoRVpOdsggPzDU4h9nsD53KmVCH7cjZ6b8FQfwPqgIk2tJyoPWccL+9BWzyEugKNAhrmJ0P8Wby+Z+vScGpyHErVyyFynOj+o2ERaho7DnegwrtM7RWWasMM+/xZHG2YdczBmZr8afyEScoRSTZUi9eXVLLmz8LM5f736UHLUsJeGll0kCXAqSfBDRAn6MRmYVQ1B3wv7+Ir05+u8zsbE7zpCra/vlr6WbFsYKV4ZW015r2OVdd27eYOBFBQGuv3zAItIeQzXNjU1BndLO1SmhTHkdRQzT1xqoeA46MR42w0B+5G2ms6d12N47pB8o+Z3GYtecxV+o18yXDpElGvs6h+r4v0QICs+JF+V1i9BlJslERcl/MkGQBH9gd/wVigQ1MHmCi3yBooJKgswHoqsibm/E/HZaMbpUKgDrmaPl9k35suJ0Lf4PFqG+zZvvTDToo+VQLJ0WlIarG6jzwXJfXjvoo/PFrtgsS5UKs0W5uxA5/g51n1bWtROhuA/CwAN3LPav22CpRP2cDgj7VkmYbO01fdHYuvNb6EaevpJ/61RjwSUjPXtwNfGmQKaZ5oyxpGMQpPXu8Qt2/gSmExTV9Z9jf6hNayWhlv6qp OslMLf2y HKpP7xj86MT6YrAq//c7RryNgaO4h9exFGC/mn+mUHUbMunmeeyacYEhL0H+R1YgdsL0S4ytTnWul2PSSp6u2Rs75v23unUVOnPjTJbYEJkiMd/f3eGZMe9CWVgJrf28o9Kxa5MfjPv9TEKwA9Q0AgaPT4zS+1Om0KkG00EO9SSXK88VTiKirtXbV+ZwdOykLseAxnyRvds3gK5oq7mPjkzmFkBvYHHT7rzD5nyHq9pWz0TdElpVG6d9+iE7O4xnfnoAVjEY61s9jNRce4WL/PwiG/G4Sw5jNWL6Ls1Om4wZeM790jM3on/owE6zkQkYSz/nvPA3WVr4xFqLYZmRf8ScVlCD/BOVxeSVuHwKJSFcn8urf9PeUwf/6dGkfX/vr4iB4CWJ5Ml7bniSiOuHdip8iap0ubXiruENWYdimetZ5FaxjrFgw3eatoY+Ft7Xdux7iIXY754bG/ULm9RevmU/uhR56VcOfw93JYZJCCOWLm25DdWPprk4+Y6Xk6/2/y7TW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 16, 2024 at 11:50:19AM -0700, Sean Christopherson wrote: > On Mon, Apr 15, 2024, Yan Zhao wrote: > > On Mon, Apr 15, 2024 at 08:05:49AM +0000, Ackerley Tng wrote: > > > >> The Intel GHCI Spec says in R12, bit 63 is set if the GPA is valid. As a > > > > But above "__LINE__" is obviously not a valid GPA. > > > > > > > > Do you think it's better to check "data_gpa" is with shared bit on and > > > > aligned in 4K before setting bit 63? > > > > > > > > > > I read "valid" in the spec to mean that the value in R13 "should be > > > considered as useful" or "should be passed on to the host VMM via the > > > TDX module", and not so much as in "validated". > > > > > > We could validate the data_gpa as you suggested to check alignment and > > > shared bit, but perhaps that could be a higher-level function that calls > > > tdg_vp_vmcall_report_fatal_error()? > > > > > > If it helps, shall we rename "data_gpa" to "data" for this lower-level, > > > generic helper function and remove these two lines > > > > > > if (data_gpa) > > > error_code |= 0x8000000000000000; > > > > > > A higher-level function could perhaps do the validation as you suggested > > > and then set bit 63. > > This could be all right. But I'm not sure if it would be a burden for > > higher-level function to set bit 63 which is of GHCI details. > > > > What about adding another "data_gpa_valid" parameter and then test > > "data_gpa_valid" rather than test "data_gpa" to set bit 63? > > Who cares what the GHCI says about validity? The GHCI is a spec for getting > random guests to play nice with random hosts. Selftests own both, and the goal > of selftests is to test that KVM (and KVM's dependencies) adhere to their relevant > specs. And more importantly, KVM is NOT inheriting the GHCI ABI verbatim[*]. > > So except for the bits and bobs that *KVM* (or the TDX module) gets involved in, > just ignore the GHCI (or even deliberately abuse it). To put it differently, use > selftests verify *KVM's* ABI and functionality. > > As it pertains to this thread, while I haven't looked at any of this in detail, > I'm guessing that whether or not bit 63 is set is a complete "don't care", i.e. > KVM and the TDX Module should pass it through as-is. > > [*] https://lore.kernel.org/all/Zg18ul8Q4PGQMWam@google.com Ok. It makes sense to KVM_EXIT_TDX. But what if the TDVMCALL is handled in TDX specific code in kernel in future? (not possible?) Should guest set bits correctly according to GHCI?