From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0F00C4345F for ; Thu, 18 Apr 2024 01:30:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49AFB6B0089; Wed, 17 Apr 2024 21:30:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44B0F6B008C; Wed, 17 Apr 2024 21:30:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 339B76B0092; Wed, 17 Apr 2024 21:30:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 154266B0089 for ; Wed, 17 Apr 2024 21:30:44 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D07F2161273 for ; Thu, 18 Apr 2024 01:30:43 +0000 (UTC) X-FDA: 82020923166.07.6248303 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 7A4FB140021 for ; Thu, 18 Apr 2024 01:30:41 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T4t341uu; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713403842; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f/kljw3WIu9Nyid/c/jp8gr+BElyOPqDQkGlBVNzXGU=; b=zxOKG2uxs+GOni15iPko+UXVpuWkIT5I2GO5M8nRCRw3yWhsc24rjOsiwfgq/s/DyO14qb Ix3ebxg3uoarVe35hcv4neo5sGffpARfkdUNIe4YvHLRV7EOGnAB5tTeFwp9ZG39Rt9vsB o3inAe3FuQCgnj13GpttC0cfy+xqYfI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T4t341uu; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713403842; a=rsa-sha256; cv=none; b=uD3ZGBdvqTWQRDjLln5Gt/Jl3xO6WCO9DiPlzwg8ptdf33vKG1kX3aBPMDAYR67cIX8U1o G4921wYntockQZOtXgUudQ4p/TeVn4F/O3mwYpXMqmPHVKXqgrXNGKCPeO3w21jfoRs+AD +O0bRRKlmQPgUZXXTYL3DgHeXGhm4WU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=f/kljw3WIu9Nyid/c/jp8gr+BElyOPqDQkGlBVNzXGU=; b=T4t341uuJ0iIcv6IObZnoplnuJ QvhQzlNIlkOP4kKYvsiTJks0GDoV9FzODjn0K+hp0MPz69D4xaTqXXV9ypP7Sp1Z54hYdySib553E ZN625x+8mgnSHU5tHI6U/ky8oq6HQEGea1BvdVtxhK85KcCtRHQpr7Qa8UOx+iiJPBLtOcDf14YM+ S1rBvQETqdH0jvAnzTCN5iqpFKRwdkDjInBdACC6KlM7ZNZFNyE3kf8Wh8EyoJntAPHb7I2hT6mKv Qku9qDciTYw2zgQ8ilYqfd8ByFhUwO82c1DoisITx0u+0pKjW4yAsw9osfl9ZfBz5rPYyI3+ULfch 3NFXKg5g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxGbW-00000004DjD-3q35; Thu, 18 Apr 2024 01:30:23 +0000 Date: Thu, 18 Apr 2024 02:30:22 +0100 From: Matthew Wilcox To: Xiubo Li Cc: Kairui Song , linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ilya Dryomov , Jeff Layton , ceph-devel@vger.kernel.org Subject: Re: [PATCH 4/8] ceph: drop usage of page_index Message-ID: References: <20240417160842.76665-1-ryncsn@gmail.com> <20240417160842.76665-5-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7A4FB140021 X-Rspam-User: X-Stat-Signature: hztnsnwe4w4h65hpkaazumureohesdpc X-HE-Tag: 1713403841-337887 X-HE-Meta: U2FsdGVkX18keHfaOQ4IYo8BGhFOtV3rJC58mUGfbXUo3RA1W1IhoNEQ3yNH5y0iLiAq3YWr0ie8x3dzUi109hcl6an6/CIzSi0ORC0dd9bvUTRLLbkvi+A/qEFIhrVOxmtrPFl1VunGEoh9XMEragN+hCml0Xb8BNyMiJyH2R6+0G0gOjvwXSU7sZlm+TTco5XwGyVe69tXq23gBKgLojpZ9rB5jUhTgKA/RUInB5nFeOYXf5/tDcuQFGFA7w9laSnBEtj+qQTptCi828vlpUYGip0QRxrqki0ocawZghU9V4Lmc0msn+A6s4h/zsCelYW7iJlx5TYueRYhc63R24nc90mB+cCuD8Esc+r+kU1VodSF/VsmbFcgWKPrWl49FjauTGaKK3va9bJ8KWOdEAR1wx4hEg82jZ0V2AboBZpLl6FJ3V6HrgaAiUeNTEgIpwrEQyiIwUVcwYsd+MKOh68Ht8CdI7DQAjnrOmptmS3zxEcu6EJ/Mb1INcACrHA4ljJnN5VJ+0pBsPz92QpAlg7KRFfO7u3XVcR6W8lPpp0Pwk9FbMqOiFE8VpBPiGnmnyD84+3GzuM2Y8Gx9yuZsfj91jPkABP9dXZyutFnP6W3kztrQigYmHYKb45yMLmZ/mDqwgPoBXWQtfRY2+00N8rlyntqFl6IbMeWz8FYIDwACuR8YSLgKdIJc076j6K1uDxnOX47Vx27RWoAMY8EVrGojJObHU4j5mh7BTH7QOR1U8sEgSIHe1tUpsDZFwsv3xkXDzAbxxXkMviFC8SjL2x9eXQcDpvSWsfCNhVODpyLEFTzPrzOkiucFIdG0XkZBwvB9Xaqfmy+knjYx8PMRvqvW0AdCLEIWUEpyJIoWyjA2KpOuOH9uMO+iI7dGTAoI20bhLp3zJT7qHAG5yEClzIPYOTZqlHmxAfdCnxpIttF3cMsQxLr6jkpoY9T/Q/z8TUPFNMkKPwgcc6LM6V tBJLfPuc g7Zmqmi//iT0iCID9A0W+jO5tkVokYO1Y02HgBl2ZgghfgCiROL+CHs/QppDBaaUCO8LwB9URidVI697AVzaBFcvI/wu951sfgDOc5BEO8zUOgf7SsReURBBlVN9NGIlrWjKRiMT/jCZjYrn0FVBcpoQbi4mlw4ktbnq9EEfoAjcLO2MrRoiNEXLffg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 18, 2024 at 08:28:22AM +0800, Xiubo Li wrote: > Thanks for you patch and will it be doable to switch to folio_index() > instead ? No. Just use folio->index. You only need folio_index() if the folio might belong to the swapcache instead of a file.