From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4943BC4345F for ; Wed, 17 Apr 2024 18:55:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB46B6B008C; Wed, 17 Apr 2024 14:55:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B641A6B0092; Wed, 17 Apr 2024 14:55:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2C2E6B0093; Wed, 17 Apr 2024 14:55:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 81F266B008C for ; Wed, 17 Apr 2024 14:55:49 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 388844080B for ; Wed, 17 Apr 2024 18:55:49 +0000 (UTC) X-FDA: 82019928018.23.4445768 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 455164000D for ; Wed, 17 Apr 2024 18:55:47 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MX7eq+tP; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713380147; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a5FP4ZMXWvD56jod+P4Mz3epLSftJiyYtHPql+dMS5U=; b=vURw9aU7iEpcsdaaFDclaZs/9r01FiiCibv4uHg59EYg1/nVl99ynaMVUitkKFAB8WsTMH AldComU93t5TGwAOwAOgVLgN9JMLVOY7xkH+YHD7D+ukxBdih+9w2jihpGZgAF1uUZc9BY PVmqayUyDRGy2B/fFzs0VAtrS9wVypY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MX7eq+tP; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713380147; a=rsa-sha256; cv=none; b=pMRpJlRN4KL6znDSD6naBPtbfbCkIMKauWK1UcT+uZkdM0Am3AGw8TDxa2U+wW97K50XHK mt+vyKLhxu054tbBWNWgRRKf3UknGyTGuswkPSpm7T0nl1ZZT/btGyGMLI4F8aBRGeIqV4 mLRDC2VNH2k6k3+MRR7N4nHwhn9tT0k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713380146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a5FP4ZMXWvD56jod+P4Mz3epLSftJiyYtHPql+dMS5U=; b=MX7eq+tP8th+QtGNy9D7QpViAuGLX1yJD2MbKMN6xIHxM5hqiI09G2P1JaZbvzB2pez5++ smzkN1aIl9Hvwm9GQplIekjVcf0INuuun0oXX38WbelDOddjl2nAXqrIMZlMH5Ciuvl8GT qySZvZgs3d0EoWitYQkrZgmSoPakRBQ= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650--D-OlMx8OJWxqQQxK3b2rQ-1; Wed, 17 Apr 2024 14:55:42 -0400 X-MC-Unique: -D-OlMx8OJWxqQQxK3b2rQ-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6a0426ccbe0so65726d6.3 for ; Wed, 17 Apr 2024 11:55:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713380142; x=1713984942; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a5FP4ZMXWvD56jod+P4Mz3epLSftJiyYtHPql+dMS5U=; b=rEFfz5tI180Ir4y35Y/v+epUXTYPTQ0E5/SPJKcVIAyFV4jYiAFKtgj1X4/AON/8VS yuV0NISDSeSGOADD+X3pSJg0mdyS9rfIb3r39PL8qAuD27miEwiJvlYtZ0/33/nE7zcO lvmCK/1N+jF6JZLBTcxWZIVhYoK9EHmf/DdUJVmme3C121QX433q5EVeryMxGcoy5/Ov EpHNkHsjqQTxi9x6V2GmFQP1psUHl/xwPrRGGszNVJXt1537jcordMUVp16QBaGALGa3 GJ+3XYB+N5XcYfVLJlxsJj07Ejx9xbzoWRCvKuP9TDSmigFVFk9R8L9mFBQG7pgjGFGs oTDQ== X-Forwarded-Encrypted: i=1; AJvYcCVXCZDdOT8gO6/DjwzIx5K+Fjnr+KEbc6u8rZs8RDj0zdMD1DsdZ6PQfkw7YQSj/4f/kBtA2V+2eHj/ff1mXRV5iLc= X-Gm-Message-State: AOJu0Yx8K13DinZk4acpboKTQE22uUwjTZiKyNcNgtaSpDnub6QHzsBb 5g/Wns/lck+2XIF4qm6DVw6XkJBhE3c3Ei+F5Akl1TW6wXv7BMJ9w/v8yoHDUgaR/jmdN5Q1qO1 EiyXWNeNlJ08Tkotswif0SKDl48Ur0uF5oRQqaS3jqb0IsqxP X-Received: by 2002:a05:6214:23ce:b0:69b:1c5c:28fb with SMTP id hr14-20020a05621423ce00b0069b1c5c28fbmr322381qvb.0.1713380142325; Wed, 17 Apr 2024 11:55:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEslpFqTi2iY9urJ7zoJJWAHsKS7CknlIlU3ST+wwwb0jPwoRa2iWZHfO/IbOU5UzodzG7AsQ== X-Received: by 2002:a05:6214:23ce:b0:69b:1c5c:28fb with SMTP id hr14-20020a05621423ce00b0069b1c5c28fbmr322363qvb.0.1713380141796; Wed, 17 Apr 2024 11:55:41 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id ej6-20020ad45a46000000b00696b1050be8sm8585776qvb.133.2024.04.17.11.55.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 11:55:41 -0700 (PDT) Date: Wed, 17 Apr 2024 14:55:39 -0400 From: Peter Xu To: Pasha Tatashin Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand , Andrew Morton , Nadav Amit , Axel Rasmussen Subject: Re: [PATCH] mm/page_table_check: Support userfault wr-protect entries Message-ID: References: <20240415205259.2535077-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Stat-Signature: e9hn9qp51ddiq48zixd83o9abiucomjp X-Rspamd-Queue-Id: 455164000D X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1713380147-591180 X-HE-Meta: U2FsdGVkX1/sa978jctEvUzh/I8ROEghRufQYhmE1FUnx3MhUjf2x/1iXEIVDsvV5H+IZrCxO89xNN+bFd0rCRm7Q1DJDVDsmhIhT/yHycdXTLgXtBAGHm+kJgeAURs44aQrOIaPqiEwsFUYKk3wHS7pjBc5HAhAfO4VGpbRJRX1HLm68Y3uCF555Ew730l5JpUy2ISAlcpPDKB8hDTwe8tfgjILNLmitvmyPiKxUeyaSKFpUCzQTT2aErYvGoyPQxIMMvH3fB3ubFM1sTDDN9qSv+1uZg4TyZ8AWTxoBCkMqdeIUCouqtgM2FO30m62mvIXYG2wgVp+rOwJy7Esv6FZve+9IYMV+W9GVY/PVjQi1nNyYv7Dds4eOIesDBnk0qI0KdY+X9+uqCpH/ppoAsenlrnTbaQmuYY3VfWkf391a2NDrhDAmlToOByu5qSkqLpY5jwowBCUYL9wgdogqMaKP9MSyVyu50hIYtIDYxDX7jJvnIRHBK5YQdkrRMBH57SIq7NfDCvXhJ96ksfI9cFlMa0dn4HQC+Ra26WYK36E4k0aVD6ZfiduZTmL9ehS1xCRjfgvsMB3XGEqNgO05Ce3kzu0MvI3qA3LBC1Nv5U95lRgGMf66TwYLPX5hvaff6PAfnKqW+QimKFvotMVgJ06mL0zRQ9+u5fEPkEB/h+9o3NFt8mjdg1ZxZeXPzisasxgqsMfmYj+R0yrfnWN4qkJ52W2BdikSpSlznTyFQY78WkMLPgW+BxhtWw/F/BxIAU8tG3cr8wqBOjEuab+zP+D6cbcfGJJy5RMmFnWHRdG9lNoS/NCZe5YcY3/dDb0HNhBgsMLmK8GQTLt4CpNR3L3OD574h0CX8sxXzZl2gzeKtNDXkXxwbpfRB+ZClMAHg2HGgjb9qWuME90Uq7o8zIO2JNqqfqHXtr3Dlc6PdKZ8yksACIIcw9m0xOiBPr9UlNtJztk0maPSzI34cY XdT/PnA+ cmzwHgx8xoJaSBR/dorIzIg4AH+yL5XqiiHGFNPsppTo8STLpXakW7ffgs46pK6Cgcn3i7rVebX3n/wPJTe4Tgw/TMYu2GsHGDnMYUSgHyVrLFSdZY1v2zlIkigFWQ3C34Bm3Lmezc+gkBqgFuNxnmu6x0876wJFogYnO/5GLTqBTTZ7qZFehkAt/qExxWRu+EkXbQVYGjkFhLWU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.116656, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 17, 2024 at 02:51:48PM -0400, Pasha Tatashin wrote: > This breaks linux-next build: > > mm/page_table_check.c: In function ‘swap_cached_writable’: > mm/page_table_check.c:192:24: error: ‘SWP_DEVICE_EXCLUSIVE_WRITE’ > undeclared (first use in this function) > 192 | return type == SWP_DEVICE_EXCLUSIVE_WRITE || > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > mm/page_table_check.c:192:24: note: each undeclared identifier is > reported only once for each function it appears in > mm/page_table_check.c:194:1: error: control reaches end of non-void > function [-Werror=return-type] > 194 | } > > Looks like there is a dependence on CONFIG_DEVICE_PRIVATE. Right, same to SWP_MIGRATION_WRITE. I've already sent a v2 with everything fixed, please have a look. I also added one more device private entry type that I overlooked. Thanks, -- Peter Xu