linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	David Hildenbrand <david@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Nadav Amit <nadav.amit@gmail.com>,
	Axel Rasmussen <axelrasmussen@google.com>
Subject: Re: [PATCH] mm/page_table_check: Support userfault wr-protect entries
Date: Wed, 17 Apr 2024 14:55:39 -0400	[thread overview]
Message-ID: <ZiAbK63JshbyW48z@x1n> (raw)
In-Reply-To: <CA+CK2bCr0eb+tc-Hp8Gqjsor4C9vpcGB2y1zhPORTAX=phhzig@mail.gmail.com>

On Wed, Apr 17, 2024 at 02:51:48PM -0400, Pasha Tatashin wrote:
> This breaks linux-next build:
> 
> mm/page_table_check.c: In function ‘swap_cached_writable’:
> mm/page_table_check.c:192:24: error: ‘SWP_DEVICE_EXCLUSIVE_WRITE’
> undeclared (first use in this function)
>   192 |         return type == SWP_DEVICE_EXCLUSIVE_WRITE ||
>       |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~
> mm/page_table_check.c:192:24: note: each undeclared identifier is
> reported only once for each function it appears in
> mm/page_table_check.c:194:1: error: control reaches end of non-void
> function [-Werror=return-type]
>   194 | }
> 
> Looks like there is a dependence on CONFIG_DEVICE_PRIVATE.

Right, same to SWP_MIGRATION_WRITE.

I've already sent a v2 with everything fixed, please have a look.  I also
added one more device private entry type that I overlooked.

Thanks,

-- 
Peter Xu



      reply	other threads:[~2024-04-17 18:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 20:52 Peter Xu
2024-04-16 21:34 ` Pasha Tatashin
2024-04-17 16:53   ` Peter Xu
2024-04-17 17:17     ` Pasha Tatashin
2024-04-17 18:51       ` Pasha Tatashin
2024-04-17 18:55         ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZiAbK63JshbyW48z@x1n \
    --to=peterx@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nadav.amit@gmail.com \
    --cc=pasha.tatashin@soleen.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox