From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C5CC4345F for ; Mon, 29 Apr 2024 13:51:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 683A86B008C; Mon, 29 Apr 2024 09:51:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6327B6B0092; Mon, 29 Apr 2024 09:51:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FC216B0095; Mon, 29 Apr 2024 09:51:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 30AEF6B008C for ; Mon, 29 Apr 2024 09:51:20 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CC8F880FFE for ; Mon, 29 Apr 2024 13:51:19 +0000 (UTC) X-FDA: 82062706278.05.D6D8427 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id BA65B12001B for ; Mon, 29 Apr 2024 13:51:17 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=T1GjTcmX; spf=pass (imf29.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714398677; a=rsa-sha256; cv=none; b=8msRDHSsCGBp4XCpaqCiONAhuOhjVzQIWdVmJ4eV8vAjSGeMIKFKL+CZU135j2NVolhqEI 9h1r6LiALxuoCewGYDdP8rgETWonJFfsvGQhwOLF7YUOYwfngzt78bGXaw1m1xWtlOQQWD yrDbtVIdH58tOqBmUH1L4AGkHZwlHjA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=T1GjTcmX; spf=pass (imf29.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714398677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8tbMD2h7PJ3lWi6PtX11/1+14job09F9/bpkbzHIXK8=; b=WAUGiefdHC6/MtsP1nGSVFORwJQbHiWwbnvCNGbXcjLvrg2ijLSOugCVxcrFy/IL1y/QW3 fylU99lfHMgxjZZr2qBuue6HOt3RVugEnOLkI+l2V4i3fAYUdYnmN0Hz3+eTzxFyodHUEV J4gEFdAxtmmQXadIqHWUqh8YnlePZ0A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714398677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8tbMD2h7PJ3lWi6PtX11/1+14job09F9/bpkbzHIXK8=; b=T1GjTcmXBqkFmfEFLhls6bEKwVwFv6gvsbJsAhcH74JOXfQ3BJCrPaqltyTbUF0snPKKoO BwWBF11Rj8Myg0imCJtQLSENaCfkYlX6dTiWt3nfKQjJtryx3TETE940HSegDwuSykiZ8H gdYAn/EOWKhFLUHmBWP3lilUqhZxZvE= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-202-9_X85yCNPk6vFGB8LuqFoQ-1; Mon, 29 Apr 2024 09:51:15 -0400 X-MC-Unique: 9_X85yCNPk6vFGB8LuqFoQ-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-61b57c7b151so10301127b3.1 for ; Mon, 29 Apr 2024 06:51:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714398674; x=1715003474; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8tbMD2h7PJ3lWi6PtX11/1+14job09F9/bpkbzHIXK8=; b=baawqpSRYNKIfszAPdfC9viwozA+GqLZ7M3RiRTNYyw6ZFh6onxGvES+F4loBN2wje fpJtag1hoUkIgmsocoNr5caxvnyDiP20bSEolPtD3CRtIAbVeEtTl+6UJPlgSoKzN+/B UuFRCXfXq07z7H8I/koWYZMzXITit5gEYqFAh9XU1W5SC/PkiTsCvaoZZ2ILOu9JP0Uv OE4YfSfrwx99G2PO9XZ2Y4FbwA6LesWVW9OIcHMg6QmAZdEneIa3a9pBMMV0S35AFx2m BXtYNiwbWnjAZZpMnUn5RtcAk4Vo69hXtTSohxdou2zx0cDHAsNRMEMtWSh1caRQKCWI HUDQ== X-Forwarded-Encrypted: i=1; AJvYcCXbIOBZAYPwb48zNKlNNHybRgSTde2we26jgqHStVEvIgvBBXYkaQ/W3tBX7eoP+m6y38qBTF+2Qw9AH+9sa7kdcGs= X-Gm-Message-State: AOJu0YxphAbOiRgqtzvfN48o3QaaOE0NycmJqWMDZ8qND06E4TK4Pb1D HfrLtSjzow7Vpm3DMQ8Z5gGvqAVupZunu9M+MsuwZEJ4eOfvLsYUGiCPIUXie8YUgt9kUcFfv3O yXUYcwA8ziDTP78Us71oyT+yVps9zWZQY2j83ao/uZSOzHidT X-Received: by 2002:a25:b29f:0:b0:de4:5c38:40b8 with SMTP id k31-20020a25b29f000000b00de45c3840b8mr9172216ybj.6.1714398673781; Mon, 29 Apr 2024 06:51:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFzbclBqcimK4lAEWdX1Uas2H83fsLI+db0WSQp/ICCVyIzSWiD5cYwnQ01wud/FLiGmgLing== X-Received: by 2002:a25:b29f:0:b0:de4:5c38:40b8 with SMTP id k31-20020a25b29f000000b00de45c3840b8mr9172187ybj.6.1714398673284; Mon, 29 Apr 2024 06:51:13 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id fu48-20020a05622a5db000b0043781985244sm10433284qtb.59.2024.04.29.06.51.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 06:51:13 -0700 (PDT) Date: Mon, 29 Apr 2024 09:51:10 -0400 From: Peter Xu To: David Hildenbrand , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christophe Leroy , Andrew Morton , "Aneesh Kumar K . V" , Lorenzo Stoakes , John Hubbard , linuxppc-dev@lists.ozlabs.org, Muchun Song , Jason Gunthorpe Subject: Re: [PATCH 2/2] mm/selftests: Don't prefault in gup_longterm tests Message-ID: References: <20240428190151.201002-1-peterx@redhat.com> <20240428190151.201002-3-peterx@redhat.com> <4171dbb6-81c0-4553-a405-a55f75be4cb7@redhat.com> <2338119d-060b-4127-9199-5ff39fd62fc4@redhat.com> MIME-Version: 1.0 In-Reply-To: <2338119d-060b-4127-9199-5ff39fd62fc4@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: 37tqf9ga1ut114u3kpr3wg4eo5x13qec X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BA65B12001B X-HE-Tag: 1714398677-1100 X-HE-Meta: U2FsdGVkX1+dxg9ivCzNlGPZX6sXmiURkRNUM76LenmoG6IOXO5KIFCLs707uWIxLRq5a2AP7YL1mm48mTJxYCyFVGra9LtQinKlZrefyVWbM1f+DUbmita8CCknpgCE8CaWbU1rKUmQjjXyUPZlK6JKCbXtPB35crk5ExVR+Ox/QHFJiDqxDk7eMqPTlCMUF8G7Lm8gpMtVqUSTkkBp4oJ/OCFuJSeA+xJ1hqB7sAjZW+e3vFw0gTR1A8bPK3YJBEItRR/+xa75eBIScfZF0GxGGhI/gkJ44i+Z0vAod3crW/mLRJx7dizfmbHwycS43mU8M+wPauNtGtJp7emoQRKjEB5krwk/thJ+KQuF5fytN+wvGhCFo4D5wSgAcgcjx/5CKDxta2qGNGskyPUuD6ANq2IqIdaXPLFabQPr8RL+Ppvzw5F+nTZ/hpiP1UfR4g0Jjvhof5CPkrKPQzJib7A+pOe4GrqZO6qAIBYdWLuKlerDdDjYOVZqH9adWNOBaBzobufq0A8Y3D6T2udvr73sh280bC5+Hq8PpfzSCzHBgfP0E/XXeMkLYFbyZFVJYnm0uh3YburTRlGzECtxmO8zvXymhUXtlpIeQWI6LfFo0YjhORLrGJFCF8Z4yfwkIrgKQk786SDVQ4Rf0NDkFAAR7ey4UtC87obwD93gQC4GQqnCaGfAO23A2QIK3eu9M4pvYodNX4a/hUrC5wVGMF1q2JEvJNb3Cw7GaromhXP/Mdtkl4jSpjMUCgeWoUz6rKvkE4aGmtX+vmxTxR4x+kafK9Oml87GsRpSyPoBskv6u0KztQZU4F0YaVFN8fuuACOo+HrUoMJuKh2MClP45jnZaTG2ZnAlFpmcZhx12RlP3LBeb4Ehim9XyR249quHmJJ8liLDb++bZu1ho/rT7w7aE9SeoBOgN+Jx7j31L9StwWGM+WiAieR6BPXKDI4BLC5qrKaAETyUD/osDXi 4TwuAhS/ X469RQx160mt+qs7O8IU/gVLaUCUC59p2UbZx+CDJr9qJkMcURbdrSviXUIFeXobi8W2W5n039bycwIIdSQ/VsZHUtoNQtgu3Oyrk7zcFL2Z8XFSHnpOBH6kGKRv+TaIBMpl78x+JE3qH+jM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 03:26:22PM +0200, David Hildenbrand wrote: > > The test patch here doesn't need to rush. David, how about you prepare a > > better and verified patch and post it separately, making sure to cover all > > the things we used to cover plus the unshare? IIUC it used to be not > > touched because of pte_write() always returns true with a write prefault. > > > > Then we let patch 1 go through first, and drop this one? > > Whatever you prefer! Thanks! Andrew, would you consider taking patch 1 but ignore this patch 2? Or do you prefer me to resend? -- Peter Xu