From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23A7AC19F53 for ; Mon, 29 Apr 2024 15:36:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 688326B008C; Mon, 29 Apr 2024 11:36:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 637B46B0096; Mon, 29 Apr 2024 11:36:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 526846B009A; Mon, 29 Apr 2024 11:36:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 36DD06B008C for ; Mon, 29 Apr 2024 11:36:24 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C65E2A031F for ; Mon, 29 Apr 2024 15:36:23 +0000 (UTC) X-FDA: 82062971046.27.E88ED96 Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) by imf27.hostedemail.com (Postfix) with ESMTP id E6C8F4001C for ; Mon, 29 Apr 2024 15:36:20 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="U/ADFdM7"; spf=pass (imf27.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714404981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7pgIU5d1obfciNK5ZO1w/49MA6EFqpbOPs15zytydTc=; b=y5LPgfqfXsKqvcpWwqqLoCagFi3Hf3sa0zaHXumWUf9u9csdxpQZ+EsPObjiexbN/OZX3r dz88Z7BxenZOsojrtiVxoq3pkXILYXlnM+zibvnikxbIKeEn0IY/elmKMAmFmk64QEYGqF af/vW+3pRaRmh8jOvWjVK86bGMcSetA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="U/ADFdM7"; spf=pass (imf27.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714404981; a=rsa-sha256; cv=none; b=o+DryXzS7LsVfvRHs67mfP1icsm/ocekmR8bpccJO7vWwyp097LTkQWHTQR5rTeWQlo3AD iDi1NsMCVju/KS732VvuuRrC4vlVu3waJLT31+Z/1U52KIKKMNETITeQzFAsj8C64nYOPn waO2hb8AZFOHkL6mRieSf9OGoZMiKRM= Date: Mon, 29 Apr 2024 08:36:12 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714404977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7pgIU5d1obfciNK5ZO1w/49MA6EFqpbOPs15zytydTc=; b=U/ADFdM745j3hf4HRTQdWUpmPhb8wVUiIyzqLow8fCO10A54hhEZu6tUEL7b6qBL3Ou5W/ qZ9qenQ3UEK8vQtoKjKTkfGih6rcDrb8BMmzbUjncKkZzatMPVFUWyxsf3/8ktLwcxAx13 +1mLbgkRziwZfUw+QY3UPftp2vEuDFc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/7] memcg: reduce memory size of mem_cgroup_events_index Message-ID: References: <20240427003733.3898961-1-shakeel.butt@linux.dev> <20240427003733.3898961-2-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240427003733.3898961-2-shakeel.butt@linux.dev> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: os88es7g7ewrpbprqpt4syd8waxdredf X-Rspamd-Queue-Id: E6C8F4001C X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714404980-311054 X-HE-Meta: U2FsdGVkX184WmieQJagmgU/J2r8wK8+p0pWXFhQthmIPbX7Ubq9srLMymSm07aWTcnC7H+0VwP1xkMQRADDl9bZUuDRJvMg2vSiQJCRbxuxF1WTVXisz9ab6XXCChXn0sIIEhA8WT6m+5LniAbT93q+SQJ7IJJw6DWeykszsCvFjxBIK5+SWnBOCHXy9FoLGbwfXbX7WCZ28TEh5zyy+E/8uEsP1us5kOxsdme5M9PLPvhtiG73FPZMlu3/4N2B6LBcB7cAIGoNc+GCJw1W8iIYKFtCg+NbZ5+VYQyg2zLua/HiMQbshzsh/ImXatgQAJ2MansWQahtSQjM+AAS/x4+Qz0qIQsBa8ynjGoS5WzbbPLliamlii1V44ckbLrQm4vnoivmHKLEvD0ciXv0+az5caOe59Bmly1WIHT3pGgq+S1h8cA+/D1DPt0PRAsCwRAg15vfOH/dl5F9bJZjmIQfw5s8IccH5dGoLfrK0+Md7o9urUu6R6vEy9QmWFt3u4J1UFEHfpJ9n0nrSRIj6XU/R0rA706DKsrMjDVWNmPQt6iW3UPeULNXZesaynrWfsL3Zkdaz1vdHw0J/IEUVwV0XbSzGdU5TQRU9cUeT9XsEhbH/7Bv0+i5C/ivKTTH1AxRzt/XV06jqnTyzMIUoURAhup3rAhL6EaoxP1e2fAjw58KX3ukQA3NSD9sKFK0Yle0dD/tXU7xOW+3wfNmOwItZRli4eAonjwE7fp87Vt3aCWKCi8MTdB2qWUW3QfTKkI1uj1WhP1TAGjCyl+HnyeX0cOTBjoVvc4OkrplTBW8y4OVnmTGrNK9w/VUboZ+kAI6+p7si7cmlWyYUexcJ4P25aHzfYH8nSk94QI+gvSrEviCJvObeAruxCjKUlroubs4nfN5F8ccoCL+ofJbFBUrzvDRXz6TbM0at+yyRpg2pgduswnC/ZOgiIINFRNpyNK813G2MRsob1kXyVi d4eFd41h 6t0gzYHB6wMZoHk7lOBIB4p0wJOVuC3eNi6G6V8uxQImPHS4NjBgw7Vw67JLwLAT17VrveY/IPBwqDCwr51tfNAu0bTpaIw68HvbH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 26, 2024 at 05:37:27PM -0700, Shakeel Butt wrote: > mem_cgroup_events_index is a translation table to get the right index of > the memcg relevant entry for the general vm_event_item. At the moment, > it is defined as integer array. However on a typical system the max > entry of vm_event_item (NR_VM_EVENT_ITEMS) is 113, so we don't need to > use int as storage type of the array. For now just use int8_t as type > and add a BUILD_BUG_ON() and will switch to short once NR_VM_EVENT_ITEMS > touches 127. > > Signed-off-by: Shakeel Butt Reviewed-by: Roman Gushchin