From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D377AC4345F for ; Sun, 14 Apr 2024 21:06:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B873A6B007B; Sun, 14 Apr 2024 17:06:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0FFE6B0082; Sun, 14 Apr 2024 17:06:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 988756B0083; Sun, 14 Apr 2024 17:06:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 775256B007B for ; Sun, 14 Apr 2024 17:06:36 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0F72AC03BE for ; Sun, 14 Apr 2024 21:06:36 +0000 (UTC) X-FDA: 82009371192.04.4A4B26D Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) by imf12.hostedemail.com (Postfix) with ESMTP id 4A24340002 for ; Sun, 14 Apr 2024 21:06:34 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VNJjfZkz; spf=pass (imf12.hostedemail.com: domain of 3WEUcZgoKCIsD376Dpw1tsv33v0t.r310x29C-11zAprz.36v@flex--yosryahmed.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3WEUcZgoKCIsD376Dpw1tsv33v0t.r310x29C-11zAprz.36v@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713128794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BdBwYWuVW4AqQLpUoIhih1uGjNBTaB7zR1bxs61C0zI=; b=GoavNdlEY8VP8I/G7cqgS4LG2p7Bc8FuQbAQtk8AHCNSzJdLerA8Q2Zv7JHjd/Ng/SQDZb LksjjVj1zp2J+Sd3ZQt7jG0cwNkbIsCTR9lWy69E3dLEKDWYfdN5ATs9HXllLTLBZ1Fh74 So11dqhBDkQowY8WDYYZ+Gm9vp/Vo54= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713128794; a=rsa-sha256; cv=none; b=XFwNFGyNn1DF2nJ+eoGlIClCRChP8flIbhkGlGPv+fgAF3/wHZS1PHR2arjWoBp8s/3pvg sgOPjYAvY6ZCnbaho+zF2wLCpDFsu/e9m4wAQX1kW3uMI2rZQu+iwXVbfNoH1ofL30eVMt hD8EMkZwgsgHlqfCpOOqLJYpMu7hqC8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VNJjfZkz; spf=pass (imf12.hostedemail.com: domain of 3WEUcZgoKCIsD376Dpw1tsv33v0t.r310x29C-11zAprz.36v@flex--yosryahmed.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3WEUcZgoKCIsD376Dpw1tsv33v0t.r310x29C-11zAprz.36v@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-2a48ed89c7eso2344779a91.3 for ; Sun, 14 Apr 2024 14:06:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713128793; x=1713733593; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=BdBwYWuVW4AqQLpUoIhih1uGjNBTaB7zR1bxs61C0zI=; b=VNJjfZkzkOGbK/p501w+mD5Q+cZWGNmWiHxS6tqsUtE4mh+Bg20d3vTArBFevhHX76 2do3laqpF3Po1dwAX2xuc9+H/B1oTDPg51R2OCaIZH+9T/f2vZuqxHengb6x/sVdSTxy gFPHbaMym0g/LKEmSz5Vg10/vkU9Xgm7KKjOI5GfRxublpPQtcg+EDvyBe2aLan5VYsZ F9kNVcLLKop8i3OVqy2EvokyQRnWyN8CgutC62tvYgrJo5+58DLcY1YW4fheR2l3A6L7 bwrziK5A+tEI7iNFGnxhB+L5C1mTLeSeN9oXFsPJruGNLzxeu6lwYL1vzhGKbU1vMCuQ HhDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713128793; x=1713733593; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BdBwYWuVW4AqQLpUoIhih1uGjNBTaB7zR1bxs61C0zI=; b=Cf0u0VwGpbBlQaDGpD7FhlxqWxnOIKD989eXZRJYiLGlIX0DqHcVqWfp6v6d1O0Xv5 RiSLN/K/VxmY3yLkjGPTmzqTh2ixCSupkJ0erPxLB3GqNUPZyY/y+CYKMaSTg9nnewrD yaE1ezGRHxebSEGT1n74KNif4WQOKgrW8e6d80xLAr2AhXKXXaq2cRYBGyoOwB1dQh32 tXiBI6u66tHN+MXhVkxU4FxB6LHJ5MnGu/Be9zvTkZRXmU3WD4ST8PXC+TwtI3VwBfUr WVcnkHgFkoQB2M2KxOiKq90y45xJqoBBGMjIYEX/R6j3pr52BgWIajTlR7U+veuyNf3v YG8w== X-Forwarded-Encrypted: i=1; AJvYcCX7Q18C6RlePmb8YVO3IvTpdBrWLZ/a8/ZrFBmL2O474uH3rmWZkZr8d6nEnkW2RITPsx95ulU5bktjtUU+OaNBq0c= X-Gm-Message-State: AOJu0YyxXS1UVpjcCAnxuX+FcNW0RCMQuVyX5GOGr4QaSrjfTt4KQB7i +Zs6D0VDrQDBQnjJQTwdiExg6171cRjYU7MXcG1HkxvT21z1F4AxbyZN8bubtv+nFEAq8u9G60j Bzo9XKSXj4crALFHocw== X-Google-Smtp-Source: AGHT+IGM2khxPg7tK4h8PAgGkzh+uhM2hW2ruzB5mqea7FJcnasbsCi94kbNLsJP4rHiG6MfRcvHI1SITe8WMKCD X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:6a00:2d99:b0:6ea:f424:85ce with SMTP id fb25-20020a056a002d9900b006eaf42485cemr112155pfb.0.1713128792684; Sun, 14 Apr 2024 14:06:32 -0700 (PDT) Date: Sun, 14 Apr 2024 21:06:30 +0000 In-Reply-To: Mime-Version: 1.0 References: <20240413022407.785696-1-yosryahmed@google.com> <20240413022407.785696-5-yosryahmed@google.com> Message-ID: Subject: Re: [PATCH v3 4/4] mm: zswap: remove same_filled module params From: Yosry Ahmed To: "Maciej S. Szmigiero" Cc: Johannes Weiner , Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 4A24340002 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 9woipj9j1rd9p5r5pa99wz6g7c19uqf9 X-HE-Tag: 1713128794-552994 X-HE-Meta: U2FsdGVkX18GH0u11q7TG3bcm7C/phJ+lUFgn6Zs3W/7Nhhtoq7O44ucRrolTY8tJC6IdPlWdBwSLyTRFKtniEzaMsbh3La2C++BaYzDHjfpQas5zZ2B544qbmT4o7M/nAPhWmJLTW+keeoN6z1uvcUKasIu6PeEx+o5V+Vai50tlq1ymTOW77pu1vvaVDaE36R7zXLZmoEUbRyV2ACZS4U39NGdQkvMoK2iWN0BSxbeVEvAToelDbeqr2fn8TOEpj6FpwfkccTxRsrr8ANNBhijVhn8UKQ+mA6IZaD/k16HQo8hlvPDCEregkstRr1P49NeTdy2XxfcY7vEDb4AodMPO5zNdgoyOM1JDjy75nJdkkiuXvY41cYs2A1YnTDyguPve95oU79FKrg+eq8NGuK6WXxzdM3z9YqL3ffnHfQWw48EvCPI1BeeP2wNzUyQ912Eh/zxfBVojU7dma7mI47HbQ/QDJvpjBVqRAhwAsfHIzn3RoIfkV1lXX1KQIiNMv5fVxwhY6upr/pS1AJVSAQiYjfMLJBLcJoJ2cAaQQUaBHZw01YO0vAGJU4HINM10TuFs6O+tQCxUV2eGRn61WyzhouhXAWdJEqg9yQ2lPVlenoPPtWmatUSY00CPAld9Kigho7aL6DByOlL7RLix+EFGmgoWKf5VrTOy6yUQ/LBd3/8rlVWRrh1lVYXSKweIfpDTukRy/+Pb9xURp55GwR5LaPHqVuTqzOieXsge3Lb9n8ecJdzhs1b+Enf5uiGdriPvjAu3xMhTO3Gj5rVMlqBu+cgOUqxOMHU3DTlZrpXfMmIIsNAisvb9eokEym/FlIWbhI4EtG3q1H0wcCyUiuL+S/5+gBK+0bTaqOhPIhAoEow6GlpvvH+RyZp3bYIm4W9VJo/i/XCttB/3haLWk+obJ02oalhJDYEPFX8qle/xpAQ+kuK0ZQZ29AmWqdAkDfn01QRlq+nW2NnEZD +l+T3bVZ xeE/AuZJ4qmVdM1X71kY7ZtAt0TkOXpxXeW+xM5QIuDAserSdCR0hlw+8kSg3XMn+wqxFeSv5kylGKVFBZ39DpGZiYMQxYCDwq79pJX18tFoh0ptmxS3iVd2mR4BxkZy13UAcQSqlyLGI6VEYKay1/2XI9iuElAMWJMAzMOer/tOrcgj7F4nywgL6y9d8WcfFJ3a/+aYyXoHnXFVynuTbBHRn6IHUtRjEzQJxdaEbeX3dsN7Wp7vrTvyukpDGJNCnFi0ASG1/+G8vZEeLsEhCLBFUEBKqUQnuOJ8gAP1BK4tgEWb2t75XKGp8tMC794WcU+Q5HJ6Fi1HfFpAq89U03pwrqopSaXa8a83if7g066PkBcnOaIQDvtRpKPM+bhONNRJdKhDrr342KerEQohhuA8vXnBzumuzPtckLYo2YbabW86KdIutmSPjupxwjQ7aW+fzyTn90/fkoZnewbaToyOvKDmSLqQI8UtDB0BRgONXEQLozMexSJfEZYRd9mTlMc3WFpPkV7ZWFlqObpZY+d/AHLeipSlLU78kmttxy1rRLOT9LNoKUSgV4hSBi5yLusGemi1jSWpfKf785/ZUJ0uH25oCTHt6a1kCIQC3k71+bRnYzhf3eYk1XCyGsNMW6Bg1aOJBUAUJgvGpwnc7cUaKVENlS2SI27kD3Q7T/6uQw4iEw+vwexvBl8QOP4lCe6/scc/4AcLsQb4ytU0avBsvn7B1xaOVqohKvsdSgTA4H/9TYbtOEEgZxTBvVW8jr71aJUf5xVLCTpSLJDQAohBD/Cx7FzHDnufkNbWPsT8a//oAkMJE7C1ggfi0hX7WIuQBek5fwmI65IA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 13, 2024 at 10:56:47PM +0200, Maciej S. Szmigiero wrote: > On 13.04.2024 04:24, Yosry Ahmed wrote: > > These knobs offer more fine-grained control to userspace than needed and > > directly expose/influence kernel implementation; remove them. > > > > For disabling same_filled handling, there is no logical reason to refuse > > storing same-filled pages more efficiently and opt for compression. > > Scanning pages for patterns may be an argument, but the page contents > > will be read into the CPU cache anyway during compression. Also, > > removing the same_filled handling code does not move the needle > > significantly in terms of performance anyway [1]. > > > > For disabling non_same_filled handling, it was added when the compressed > > pages in zswap were not being properly charged to memcgs, as workloads > > could escape the accounting with compression [2]. This is no longer the > > case after commit f4840ccfca25 ("zswap: memcg accounting"), and using > > zswap without compression does not make much sense. > > > > [1]https://lore.kernel.org/lkml/CAJD7tkaySFP2hBQw4pnZHJJwe3bMdjJ1t9VC2VJd=khn1_TXvA@mail.gmail.com/ > > [2]https://lore.kernel.org/lkml/19d5cdee-2868-41bd-83d5-6da75d72e940@maciej.szmigiero.name/ > > > > Cc: "Maciej S. Szmigiero" > > Signed-off-by: Yosry Ahmed > > Acked-by: Johannes Weiner > > Reviewed-by: Nhat Pham > > Reviewed-by: Chengming Zhou > > --- > > I think you need to update zswap kernel docs, too. Ah yes, I had local changes to update the docs but apparently never committed them. Thanks for catching this. Andrew, could you please fold in the following patch or merge it as as separate one? Whatever you prefer. Thanks. >From 6191c528fee01a4c79b43c53ccbd0273b705965e Mon Sep 17 00:00:00 2001 From: Yosry Ahmed Date: Sun, 14 Apr 2024 21:03:43 +0000 Subject: [PATCH] mm: zswap: remove same_filled_pages from docs The module parameters are now removed, remove all references from kernel docs. Signed-off-by: Yosry Ahmed --- Documentation/admin-guide/mm/zswap.rst | 29 ------------------- .../driver-api/crypto/iaa/iaa-crypto.rst | 2 -- 2 files changed, 31 deletions(-) diff --git a/Documentation/admin-guide/mm/zswap.rst b/Documentation/admin-guide/mm/zswap.rst index b42132969e315..59783134afbe9 100644 --- a/Documentation/admin-guide/mm/zswap.rst +++ b/Documentation/admin-guide/mm/zswap.rst @@ -111,35 +111,6 @@ checked if it is a same-value filled page before compressing it. If true, the compressed length of the page is set to zero and the pattern or same-filled value is stored. -Same-value filled pages identification feature is enabled by default and can be -disabled at boot time by setting the ``same_filled_pages_enabled`` attribute -to 0, e.g. ``zswap.same_filled_pages_enabled=0``. It can also be enabled and -disabled at runtime using the sysfs ``same_filled_pages_enabled`` -attribute, e.g.:: - - echo 1 > /sys/module/zswap/parameters/same_filled_pages_enabled - -When zswap same-filled page identification is disabled at runtime, it will stop -checking for the same-value filled pages during store operation. -In other words, every page will be then considered non-same-value filled. -However, the existing pages which are marked as same-value filled pages remain -stored unchanged in zswap until they are either loaded or invalidated. - -In some circumstances it might be advantageous to make use of just the zswap -ability to efficiently store same-filled pages without enabling the whole -compressed page storage. -In this case the handling of non-same-value pages by zswap (enabled by default) -can be disabled by setting the ``non_same_filled_pages_enabled`` attribute -to 0, e.g. ``zswap.non_same_filled_pages_enabled=0``. -It can also be enabled and disabled at runtime using the sysfs -``non_same_filled_pages_enabled`` attribute, e.g.:: - - echo 1 > /sys/module/zswap/parameters/non_same_filled_pages_enabled - -Disabling both ``zswap.same_filled_pages_enabled`` and -``zswap.non_same_filled_pages_enabled`` effectively disables accepting any new -pages by zswap. - To prevent zswap from shrinking pool when zswap is full and there's a high pressure on swap (this will result in flipping pages in and out zswap pool without any real benefit but with a performance drop for the system), a diff --git a/Documentation/driver-api/crypto/iaa/iaa-crypto.rst b/Documentation/driver-api/crypto/iaa/iaa-crypto.rst index de587cf9cbed4..4cb1d52ea6dc4 100644 --- a/Documentation/driver-api/crypto/iaa/iaa-crypto.rst +++ b/Documentation/driver-api/crypto/iaa/iaa-crypto.rst @@ -457,7 +457,6 @@ Use the following commands to enable zswap:: # echo deflate-iaa > /sys/module/zswap/parameters/compressor # echo zsmalloc > /sys/module/zswap/parameters/zpool # echo 1 > /sys/module/zswap/parameters/enabled - # echo 0 > /sys/module/zswap/parameters/same_filled_pages_enabled # echo 100 > /proc/sys/vm/swappiness # echo never > /sys/kernel/mm/transparent_hugepage/enabled # echo 1 > /proc/sys/vm/overcommit_memory @@ -599,7 +598,6 @@ the 'fixed' compression mode:: echo deflate-iaa > /sys/module/zswap/parameters/compressor echo zsmalloc > /sys/module/zswap/parameters/zpool echo 1 > /sys/module/zswap/parameters/enabled - echo 0 > /sys/module/zswap/parameters/same_filled_pages_enabled echo 100 > /proc/sys/vm/swappiness echo never > /sys/kernel/mm/transparent_hugepage/enabled -- 2.44.0.683.g7961c838ac-goog