From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AE44C4345F for ; Sat, 13 Apr 2024 22:46:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 883CB6B007B; Sat, 13 Apr 2024 18:46:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80CCB6B0082; Sat, 13 Apr 2024 18:46:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AD906B0083; Sat, 13 Apr 2024 18:46:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4C8D46B007B for ; Sat, 13 Apr 2024 18:46:44 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C77611C157F for ; Sat, 13 Apr 2024 22:46:43 +0000 (UTC) X-FDA: 82005994686.01.9CC6AA0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 35B7FC000B for ; Sat, 13 Apr 2024 22:46:38 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TZHCcAQ2; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713048401; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=upkPxeJULDIqVjxQGrFGBzCuYaSNuydHTzRPVCk4Ul4=; b=OMw1P5TKVC23VwAs2Ktb3SZFGAsXeXR1n0eo83FV1lh8ovUcjehYMEDyzpg3uepL14NtkF Y1zxpg0lyXjg1LX71MnKlzmW7qKabCPv1AYenbozEqRclVtaprmb6HU/hZVnngLI9TueQP HJoPazh61bsM+bJl82dgPFKR8tl8ZWI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713048401; a=rsa-sha256; cv=none; b=pEeoAgEyoIyid0HDiJO8R1HkOgB6L+ruuuZIv/vm4XqUAva5Sq5V+eO/xB/mPExlytkc+d Ki+I9lzquhLpVJ+mtHTHMKZPM5mGhKULLjH4XWUUv3lxbHFl7lzCeqFg0ahLnGd2E4q2Dv KAZp3PFnjwG7t6mUQfOldrz49tbKwUM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TZHCcAQ2; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=upkPxeJULDIqVjxQGrFGBzCuYaSNuydHTzRPVCk4Ul4=; b=TZHCcAQ2iHu50QymwwhaQq1+68 57ipOpLVh3k//iR8bRmORko79WByHr+cvPoCSCi+PAxXgDyLJW8pOC6skPf8AZeFTKI7ItjSXSPvW vPrOLAFoiS2UqemYQ1h0YweOILEood7Qo2hLf8HfqkXkUUZJzVrhRRT8hprGEpidge7B/WyXbVpkP tG4Rd5YLs9UCcPgavM9R7FHdGVg1usM0wegq+l76eVcfMWVg4dGqYRmmZbFbNkVVGiSP+Ua+H4i2g aq2ZTwHTSeAPqoynlVU1pOyprpqmwcqxF+4ZDDJklV9SBexz+H0DzAdL6+xCzRKAh5KjSzERBmbWM s1KJ8gWQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvm8i-0000000CH5s-0y1Z; Sat, 13 Apr 2024 22:46:28 +0000 Date: Sat, 13 Apr 2024 23:46:28 +0100 From: Matthew Wilcox To: Suren Baghdasaryan Cc: Peter Xu , "Liam R. Howlett" , LKML , linux-mm@kvack.org, Andrew Morton , Lokesh Gidra , Alistair Popple Subject: Re: [PATCH] mm: Always sanity check anon_vma first for per-vma locks Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 1od1syjb5ap9dobeh8ee3fg6ycsm3ktf X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 35B7FC000B X-Rspam-User: X-HE-Tag: 1713048398-556726 X-HE-Meta: U2FsdGVkX18uV25OiE++GZdtCKJFJPslTHpGpII6/aShyOarklLnT8T7YcdekiklTi9S1ybZ+stWZFNhl90G9lggTRbUJmhdI4K6iJEX2XoxS7Lz3LPbY8ERBfiPsC+t8kGQhKb+jSXPS64WnmUj8jEBLGkbYRgpNcIRuaCbXrvL68RcA1FoOBFKovKXpyVWqrKEcGtccgEh6Dh/qX4Crs6Yf6TPoz4ZkkHgME/XBnuENtRgNvFpWiLVczCT0peKHho5lD1Rks4DB6UB22VBANQItaT/91DwSYQkS6FCY3pqb/p2+TYVLHyMfda2I9c4BUB7BgryAGgi1yzQFJnhoB9Ma9+xW4gUT3KtNKp1mokb66sYMB7ZdKInyJyQGcTXLt+GdyHGtbyBbVndH9jTwURtZZdFGWo59zfQY8SDlJOUaZuDDfBIvfcnC4hKqSQzovFC0vLe9FStFYgygdzZEM51LH6iQchV0GJ+zViOQKOdh9N27eSNb8lKnAGTGg6yES3NwaMuNFaby4yzFJEeRlnkJTZ4P8fgF5VJJ2yGdve6kQ4nJm94zR/+p+OBLO1mv7s/wua9anGDvEYPFf5CeUVQ834z6ZBBxr/+i/7K+aQlbGhLyiDwIW8Dywaj0f46sC3QXKsfqgjvxOFFJqInf2ZdhQ7N1a7/XQG37GueyHnSz8n7MqpkhkROWOgg95R8kfZOYPOX11Qiaj9NNgegobtnEJL5xsXRuXe60n9LRvuYEQnbxAf+tqYKbneLDT8DAqv4VsGJbAtJn88txD27DWWhU3BTRdrNQb+jkw4G58m3ut2uHvnIAXG6AqzxWUUssw+xL+9ZwaU2sfqnMRCH6cU5j+tk09HCG+xuzIqPBQflXNIxlXWE7BeFmTNoix3fOfpR7yWXO//cMKhY0GceXBoKpLim5MpefSPrt1/NM9lfW8Dmd6r+OYcn4xMtu/hX3A0SHHLmv0KZ1VbSUDS 8HtQLHx7 fVy2UeiqWbtV95adhEOv0aUqgag2lP32lxlo4oEHa3GS1VIbVIamxDH5maLK5POnhfyDQ0l4RWT7cLMGZYTcC2BhRSRH4b+D2KisjYJOox9fMOCCpdKzQu6qJgonzT2QKe9S0EheItssYSDc9RBBnFPvMpHho23EygaZ3S3W0v09KzXZmxCztb6NswIpoFL+heQf061ncarEKkrcS8uRSWpY4/vKA2ORYox3zJkPl9yCOxiRzvNLA0hi4MIYlsdFNrnWE6LBNqC0gaSIkpFJp9IJHshW6RhcxwCzF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 13, 2024 at 02:41:55PM -0700, Suren Baghdasaryan wrote: > The patch looks good to me but I would like to run benchmark tests to > see how it affects different workloads (both positive and negative > effects). I'll try to do that in this coming week and will report if I > find any considerable difference. For now: > > Reviewed-by: Suren Baghdasaryan > > Also we should ensure that this patch goes together with the next one > adjusting related code in uffd. It would be better to resend them as > one patchset to avoid confusion. I've put them here: http://git.infradead.org/?p=users/willy/pagecache.git;a=shortlog;h=refs/heads/vma-lock 0day has already run build tests, and I'm assured that they'll run perf tests in the next few days.