From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECAA8C4345F for ; Fri, 12 Apr 2024 14:31:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 651416B0096; Fri, 12 Apr 2024 10:31:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 601486B0099; Fri, 12 Apr 2024 10:31:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A1716B009A; Fri, 12 Apr 2024 10:31:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2BD586B0096 for ; Fri, 12 Apr 2024 10:31:06 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E17DE1A0EAA for ; Fri, 12 Apr 2024 14:31:05 +0000 (UTC) X-FDA: 82001116890.19.4BCB8C3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id A79962002C for ; Fri, 12 Apr 2024 14:31:03 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XDtYIR1n; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712932263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5gvIPcFWYwEFpmmOj32QPWexxorRFZ+mmSvRstzL0kU=; b=OOXG9n7mQmRd9Et4Y9TbCd2SFZUODFRdqhkJVQ0UlH4X4h2nNjxFNBW29QQm7pWETfwtWC R7x+TYT1qD8x5WymZAxR4nnyZwlt7lVGk8Y3DgKirgTGsMi7LKH2lvxCVvd0C8gX+KdHeY e49Pt0f2cR4T9KVgqVsgbk5Em7wUKbU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XDtYIR1n; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712932263; a=rsa-sha256; cv=none; b=XEWhqyMyS8eQhME95M+xSm6aU4xovhWs606Pldab+Xd4plL9LPi6bBBh1uyLGYtVdW2QmM 65ChaG417bE99kaKU5WViqBo1p9lWNFiYXgQlnIs9SdK8iCO3zcnlgH7rcEJZyfbtGWE+S q59IyhNHDL5gC33tFvEzC77akkYdvjY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712932262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5gvIPcFWYwEFpmmOj32QPWexxorRFZ+mmSvRstzL0kU=; b=XDtYIR1n6iSdsHvy27IMipSEjegKy7mTt+VV//kPOF1q4J/Sq/IPfKMz0iSkjgiSZEnDtT 4lO7VGc8btICl27LRX0UznS986E28Yi8IUpPS6uPqeTLiv3pSJIShmJla3jPTzTu6GJiEH MfrvLl2I38HmbD9oqLVy+l2II0R5ciA= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-BKKaUEmsN9OSx6LqXKQPpA-1; Fri, 12 Apr 2024 10:31:01 -0400 X-MC-Unique: BKKaUEmsN9OSx6LqXKQPpA-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-43493db472fso2886101cf.0 for ; Fri, 12 Apr 2024 07:31:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712932261; x=1713537061; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5gvIPcFWYwEFpmmOj32QPWexxorRFZ+mmSvRstzL0kU=; b=CfBeMSO4zUEE9S9vglWMKq5bI1E4LItneJcqwcAC1VUyYYt43YvW1inrx1aVdrsUmD c2opJ5HP6xkbpfgmeohP9LhQX1dk2/+54nnPy5To+rjl6pJg2Gpdbv5EyeKjSSqDl12W gdYwqrMW52666C0U61UGkP8sO9S30L+Aj9n9d98zpqFpsyOpqvM//BJ6mgz9SKzmzvZh roHu5DrRjZzxGv75M3NQvb7CLvqUFlQMhJo/YkVeNPQtYYbsurkUEAOw8JizJa8FbCgA C1ynIIErQYXpusoYn1y1weUJ98igMdA8DuLic+9kDaiI2rAyKJLsqoZgD3xDvTRUf5C5 gpsA== X-Forwarded-Encrypted: i=1; AJvYcCXsUv8Hzw6HbzQfT6H0UH4mkp3qhM4rNb0XPS6wjrbrIWra5qbEBSi44vKQZsB9hQ1IdrA2Vrkn44XLQOftQa6fgts= X-Gm-Message-State: AOJu0Yw3TPKWX+5HroWAFAsHbo6nxaT5OSDCqO4Q0DLC7YsYmS6vgwic BheDRjB3g0xGUAzuTjRaF0VWrnu1m+pNjIEKiTWO6hd/OxcJyolqBO+l18QJGd5fF3S2xK0QXCv RNcw51cOpu2hCL3rKvg47jMYuw9jwtQ1w5ks1jxKunkBZQTkV X-Received: by 2002:a05:6214:27ec:b0:699:1c74:bd54 with SMTP id jt12-20020a05621427ec00b006991c74bd54mr3044507qvb.3.1712932260268; Fri, 12 Apr 2024 07:31:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGDgbuVeaiYa+iRpf0cfy8PiIaqZ4WRcM9oHh6Gsf+qbEBfhxoFcZIHBXMGQOqhTvyFuTiFRw== X-Received: by 2002:a05:6214:27ec:b0:699:1c74:bd54 with SMTP id jt12-20020a05621427ec00b006991c74bd54mr3044473qvb.3.1712932259555; Fri, 12 Apr 2024 07:30:59 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id r26-20020a0c9e9a000000b0069b5c6f074bsm514693qvd.112.2024.04.12.07.30.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 07:30:59 -0700 (PDT) Date: Fri, 12 Apr 2024 10:30:58 -0400 From: Peter Xu To: Christophe Leroy Cc: Jason Gunthorpe , Andrew Morton , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [RFC PATCH 0/8] Reimplement huge pages without hugepd on powerpc 8xx Message-ID: References: <20240325163840.GF6245@nvidia.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: q1rgz5m61oubnokrrm7i11cd8ub68px4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A79962002C X-HE-Tag: 1712932263-64101 X-HE-Meta: U2FsdGVkX191lZhMDJIgH1t+KuMods/i9OcPcEpeyqYWWNzNQNZ5Yfa9RxIIejeJ33LQ3KxGYkznkHJcVyIDOk8m5r8mT7agImHKGCKY4LEZXBKVfKiANd34P1+0lxDGJzEpM2acuAj9qCBNfIZdK1iELGVv48IwiNk0h67QJVVfGcMNvpdys038r9TgCFXhgoF6Nm2SlqoFixD+2LQmhG3Wqg3fRHtRNByKYxBXXMsyZ/dztJ4bVdS/4ve6D0XHtzBhHBdpyrAGoBk4tsI7HHOKl2AqT6MvfMM1Cv484smsWBuI8P9cTdgs2g7w3WjXyaK/Tm7LzpUtQGyTWFHIM3+BMTMedzHbib8qIJzTYkCu6VbWvA+GdpariwNC1XAtMDz7rgYuYBl2neJxhEfg3ZiG9y495gf6e6VW9qUfuzhw8/q8wullt0HIg9un4IU5CwAvG4dQEAtTAoVCGmEXvjHwTeumpqyycoho6JwY/wHyv5xQc6tJlVfQNLkfr4ERmwYDmvnWKmnuyba6qUm1vkANXf3jf0cq5uACfEYe1wdn45AVuSq5tMKZXRR8kefGUTXw9ipXSfqwE+M8xgNbB0a5NG4KbRIcgDL23ncmko6CkElb4hOhq+OpqIgzS9rtyL+nSEtMdWdvfM/hEH0gf0EeRr5z7mQZt3DMDzW5OlzSOiP8rEwnQZdUaIELWfqGLX069baXg3cK6C8bmmGoL8WSsX7GpdxwKalLG4MdSnogGqOYV0zGOhBlgQ21eaLLyizfBqs48WPX0Gwk2eABKE9ZUXlNAhbhx1VraqTzdIV4yDcwZxf+i03xmXMwuMSDZfsOrEEhDtxTnEy8zOjmRFYR46rqzKGfWkIq7fwVOY/ksmvzC/F4lOjX+bh6A/qYxqsl90YXZQN60CWC7lFuPhJ54xZIbIeiw8F4cM7WVJTjuUFz5x4gGJjQFttx02EqcgzHjiM/8SY0juLq/Ih ASjmwWEu nQUDdixSnN60EnGaSqz7X/1sKQkKgSlVs1lPGNMWUyE/hW4Yq3yhwlYjHjJvX/AIudUYjvC2GiarKDSLllLNgnnqAR/CaG07U+UK3JSNOrnPMOrNu7CNo9BPW2iGFTzvAALY1cfFTC9H4oiTh337PCXbp9nPOnbMLXqXIdQFfPvf6UhXgsik0M9oZ3uNhinPx5t7Oe/L6K6hBIkjXvgLvLTtCRungevKtAvNXwqN2e0FgTeKUt+WFpjg6DSKMq338i/TQFg7a19juuzIpLOIgUedL4f32PHHEeyJYojc5ZIShtZpyvjTwcprN5LsJl8as5si+p0zCbJVNKsY9lRDxV5cleetnGyqzE4gGyl6Ir04HIHP4qZ5Nfi5di1a07J1jwVaCzK2Fekg76SqwfIozuyiFehBdUfKLHVgV10R5s9Kb6RU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000022, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 12, 2024 at 02:08:03PM +0000, Christophe Leroy wrote: > > > Le 11/04/2024 à 18:15, Peter Xu a écrit : > > On Mon, Mar 25, 2024 at 01:38:40PM -0300, Jason Gunthorpe wrote: > >> On Mon, Mar 25, 2024 at 03:55:53PM +0100, Christophe Leroy wrote: > >>> This series reimplements hugepages with hugepd on powerpc 8xx. > >>> > >>> Unlike most architectures, powerpc 8xx HW requires a two-level > >>> pagetable topology for all page sizes. So a leaf PMD-contig approach > >>> is not feasible as such. > >>> > >>> Possible sizes are 4k, 16k, 512k and 8M. > >>> > >>> First level (PGD/PMD) covers 4M per entry. For 8M pages, two PMD entries > >>> must point to a single entry level-2 page table. Until now that was > >>> done using hugepd. This series changes it to use standard page tables > >>> where the entry is replicated 1024 times on each of the two pagetables > >>> refered by the two associated PMD entries for that 8M page. > >>> > >>> At the moment it has to look into each helper to know if the > >>> hugepage ptep is a PTE or a PMD in order to know it is a 8M page or > >>> a lower size. I hope this can me handled by core-mm in the future. > >>> > >>> There are probably several ways to implement stuff, so feedback is > >>> very welcome. > >> > >> I thought it looks pretty good! > > > > I second it. > > > > I saw the discussions in patch 1. Christophe, I suppose you're exploring > > the big hammer over hugepd, and perhaps went already with the 32bit pmd > > solution for nohash/32bit challenge you mentioned? > > > > I'm trying to position my next step; it seems like at least I should not > > adding any more hugepd code, then should I go with ARCH_HAS_HUGEPD checks, > > or you're going to have an RFC soon then I can base on top? > > Depends on what you expect by "soon". > > I sure won't be able to send any RFC before end of April. > > Should be possible to have something during May. That's good enough, thanks. I'll see what is the best I can do. Then do you think I can leave p4d/pgd leaves alone? Please check the other email where I'm not sure whether pgd leaves ever existed for any of PowerPC. That's so far what I plan to do, on teaching pgtable walkers recognize pud and lower for all leaves. Then if Power can switch from hugepd to this it should just work. Even if pgd exists (then something I overlooked..), I'm wondering whether we can push that downwards to be either pud/pmd (and looks like we all agree p4d is never used on Power). That may involve some pgtable operations moving from pgd level to lower, e.g. my pure imagination would look like starting with: #define PTE_INDEX_SIZE PTE_SHIFT #define PMD_INDEX_SIZE 0 #define PUD_INDEX_SIZE 0 #define PGD_INDEX_SIZE (32 - PGDIR_SHIFT) To: #define PTE_INDEX_SIZE PTE_SHIFT #define PMD_INDEX_SIZE (32 - PMD_SHIFT) #define PUD_INDEX_SIZE 0 #define PGD_INDEX_SIZE 0 And the rest will need care too. I hope moving downward is easier (e.g. the walker should always exist for lower levels but not always for higher levels), but I actually have little idea on whether there's any other implications, so please bare with me on stupid mistakes. I just hope pgd leaves don't exist already, then I think it'll be simpler. Thanks, -- Peter Xu