From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71D96C4345F for ; Fri, 12 Apr 2024 14:18:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11ADC6B0099; Fri, 12 Apr 2024 10:18:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CA3C6B009A; Fri, 12 Apr 2024 10:18:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F24296B009B; Fri, 12 Apr 2024 10:18:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D00CC6B0099 for ; Fri, 12 Apr 2024 10:18:20 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 984A8160EE2 for ; Fri, 12 Apr 2024 14:18:20 +0000 (UTC) X-FDA: 82001084760.12.F2CEE5A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id F31F818000D for ; Fri, 12 Apr 2024 14:18:18 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VKfFXUGa; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712931499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2BYJNmVdG5wpg99XHThDNC7LECCoy2+Z5eSz1sME4BI=; b=B7om6eqzGIedpgrdWTA9oDGvZ1Za2UP1dHzYnsfahGqyAPARsrFKplRIkRSqpF24tDHIYh 5YrLkHOcIsF74oUPvpsiKMs86ldZK0B2G3a4FwPOfxanLby3tHXDIQxM3z2JZivi/cPE/q V4a/nj2NMhSXmIKqfJYrp3/ZfmID5Hs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VKfFXUGa; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712931499; a=rsa-sha256; cv=none; b=jDTac2R5S4O1jp9Jhqdpu+DLUDwqm8oQikXN7rQdQ/r0bXIxTlkNUOYl6HWJrltn4E69s2 ShAcEvU8+Gel3S294NemBWdem0m30Lg2Za+02DxtaQjhFPyU59XkhASBK/J+SHz8mb1hdy CCQkYgl7xVtY0eXahJffscdjJl3u5Kg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2BYJNmVdG5wpg99XHThDNC7LECCoy2+Z5eSz1sME4BI=; b=VKfFXUGa5RGNXIQPsrIofPTz/w kCpdI0ua5ft51EzicG+Ch0K50IrrJoOVZgDzUMtoGFkrZin9tKkI34Nv7sZ2Ol3dzwKLuX/ZebtnS Rx5SKaJtulKZEz56dl3IdH0wCXk5WicLtLpfwvx6LvGAOMvS+2yVXGVQjOyDHtuNoWSvqMk6K1g1q 0+6/dZXMS48D14SDSKlA4HbeY86Txw/9bXdbrjCjkpDqs2tjsSO7cTtpgtmnGmYdlYajKRVc+k0ZW szZr+/jhlFJw/1GXjij64uCOYg43nJ+FuAGnYb6MF5T9iasIkZ8AcXykRfluiXd5khw61FVOnBtCs UzRNXlVg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvHjG-00000009PBV-3ArS; Fri, 12 Apr 2024 14:18:10 +0000 Date: Fri, 12 Apr 2024 15:18:10 +0100 From: Matthew Wilcox To: Haifeng Xu Cc: Vlastimil Babka , "Christoph Lameter (Ampere)" , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] slub: Clear __GFP_COMP flag when allocating 0 order page Message-ID: References: <20240411091832.608280-1-haifeng.xu@shopee.com> <5482360c-0a0b-e5f5-b88e-4a6ec4d43f7d@linux.com> <5d3c4a5e-0c27-4058-adf1-91e9602e5ccb@suse.cz> <2031ea8c-29a0-4514-b042-7c0eabb4f443@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2031ea8c-29a0-4514-b042-7c0eabb4f443@shopee.com> X-Rspamd-Queue-Id: F31F818000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: w4h6nwmh4f9ypaaszemziya3ckgb7tyd X-HE-Tag: 1712931498-776284 X-HE-Meta: U2FsdGVkX1/mQ7+eyCzRkhYhCTHAS9j9qktJrAfTvh7Zg0vzZYdct96TdqATSRcvRTn3O7grJliWh0EKMN0rdhjfxamIsJ5eG7jwawLOrOpWXg/skBHxGDQgSS2oAYLwX13lUOk4/wJgoHACH7YBEr29vudJ2YvfTF+QVnv7QGxGN+9wTaAGqn8/vVmGZCXXl9JGCATtHmTa7y3NFvVGUamo/2AOJZbNBvgksUnuk6E4ohqVk/vEzUdRbJZ3esiW1SO/aR+CSgW3fAjNF9XqqIhuTwan2sL2Q1TXjH6XCDqAy82pZAUpS3kGjGz2QQL8ohcUwz/fFjkxxGawiYQfeXIjJfLiStmQsytNdhe5+NiNhh++DkKtCJdbakaufMSbapqOkcGvce5QYOOraVMe2SbbH/DMAFc5ODB8R+eBjCYBOUgkms+Rc9qqwerPBtCzgAfVy76vD+Zs5mDv0948zceQxoZEG5BeS4HllFupAP59I7OvwvF05flZBSluZYq/NAcaiXl5vQkq9SguQDGwNtbvPx+C6dY4hxs7fau98nAzjrMIAn9J+6AgT1BnE3meDNk+8TvPppxYV0aRdUmjM38Olw6bMibR7qEuKQeyfqfTuG6MPOwv25bv8GNtJDCdIJ0qG6D9ZRM+nDPGizMyTS2VdUuQhBtcPszYvV3fVAwz3uOpAJSuskLHuQDk06ltyK9HXjN76eEvJL/255uEL1eey3urmxZo78XIgzboFhdLQTjVklum9jCSj37O3zNiEIM719Ieq7D20AER9inhwxgdfohsi/lkhoU5wkMK7syJlYIvH1Cqcog503dN/CizumsLKRdX8OGpXGQxOJfIcIF96N5ahnFubdlPE4onwImRmr9CIoYiYA/NgxIjCoG+skzSK1NgNyLYIzDwvSbwYL2IPSzkbznWNUGYbnJZylICEnxnkTGQp5fqWhqNO1SaRD9zu7DvnSRHXV9VvmQ AE6toHs+ xxbz3sd/H+DPpI+lBtnre3MrqTirwlDIezDkK9lvbZ5v5/V3AlpSTce7X2G+0ZsE5HhcMVxiUtHOxHNAFwSkWe/1rrKAHLoxL6VxUjhqeduGSbQCFPugAN7dVwxzL+FytjiYDZeNdUlKaPJxRPY2GQLZyoeakYW0IllNaAhqZuY/tIwH177DRnqPsR8UYUUmSLiuA2y+gKbRQLFtCy+WsbyQ+lVkSGVuNcDpVajoV1lr91TAkox/5LvBHaYVoEP9g3euWmHghtkJzZy0+A89YoUo8Xb28ZdlzoE3Rg7dEFWsOUWA2WpnrbcVrwQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 12, 2024 at 10:14:39PM +0800, Haifeng Xu wrote: > diff --git a/mm/slub.c b/mm/slub.c > index e7bf1a1a31a8..49a3ebefab86 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4461,9 +4461,7 @@ static int calculate_sizes(struct kmem_cache *s) > if ((int)order < 0) > return 0; > > - s->allocflags = 0; > - if (order) > - s->allocflags |= __GFP_COMP; > + s->allocflags = __GFP_COMP; > > if (s->flags & SLAB_CACHE_DMA) > s->allocflags |= GFP_DMA; Resend this with a proper changelog and you can add: Reviewed-by: Matthew Wilcox (Oracle)