From: Matthew Wilcox <willy@infradead.org>
To: Haifeng Xu <haifeng.xu@shopee.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
"Christoph Lameter (Ampere)" <cl@linux.com>,
penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, roman.gushchin@linux.dev,
42.hyeyoo@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slub: Clear __GFP_COMP flag when allocating 0 order page
Date: Fri, 12 Apr 2024 15:18:10 +0100 [thread overview]
Message-ID: <ZhlCogEsWEjTbl8_@casper.infradead.org> (raw)
In-Reply-To: <2031ea8c-29a0-4514-b042-7c0eabb4f443@shopee.com>
On Fri, Apr 12, 2024 at 10:14:39PM +0800, Haifeng Xu wrote:
> diff --git a/mm/slub.c b/mm/slub.c
> index e7bf1a1a31a8..49a3ebefab86 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -4461,9 +4461,7 @@ static int calculate_sizes(struct kmem_cache *s)
> if ((int)order < 0)
> return 0;
>
> - s->allocflags = 0;
> - if (order)
> - s->allocflags |= __GFP_COMP;
> + s->allocflags = __GFP_COMP;
>
> if (s->flags & SLAB_CACHE_DMA)
> s->allocflags |= GFP_DMA;
Resend this with a proper changelog and you can add:
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
next prev parent reply other threads:[~2024-04-12 14:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 9:18 Haifeng Xu
2024-04-11 16:51 ` Christoph Lameter (Ampere)
2024-04-12 8:01 ` Vlastimil Babka
2024-04-12 12:17 ` Matthew Wilcox
2024-04-12 14:14 ` Haifeng Xu
2024-04-12 14:18 ` Matthew Wilcox [this message]
2024-04-12 9:34 ` Haifeng Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhlCogEsWEjTbl8_@casper.infradead.org \
--to=willy@infradead.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=haifeng.xu@shopee.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox