From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40B06C4345F for ; Fri, 12 Apr 2024 12:24:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3E0F6B007B; Fri, 12 Apr 2024 08:24:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9ECDB6B0088; Fri, 12 Apr 2024 08:24:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DB306B0083; Fri, 12 Apr 2024 08:24:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 701E96B0088 for ; Fri, 12 Apr 2024 08:24:51 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id ABA30C0E4A for ; Fri, 12 Apr 2024 12:24:50 +0000 (UTC) X-FDA: 82000798740.25.7142721 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 16AE28000B for ; Fri, 12 Apr 2024 12:24:48 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uWkCeV4y; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712924689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V8tHIi8mtmD3siYN748Lkzi4LVwXGCeJa+lIehzP4co=; b=y6bfWIz7SjyFz5/Lrd0mmV+804IVzlyrzYBjzQtJ2i2foqF7b1zVzSrQJMhYuUYIKBPpSb l9DE7J5WCbFSOCbLbySofZuRjdimDuGAgAuaECR1JjJrgNMZUAsS1LG4yaGxlKJ1NwOCug touGFRCEkck6v7MAJjx4yB/iJVlFlEM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712924689; a=rsa-sha256; cv=none; b=DN1XFp07E7csuywn6g4VBz58I+4beDzGgzzpfRW8wcuNCpdBSPpbIbwtubcJZ3q9CjjhX3 qu8nZyXeXTw2Z11hqXkyd0nbr9C0echDeEX7e/wrWp4D/Mlzz/MU//h8q9CA2rlmHUqT2k 184GI/DDLTB1VLOvry0l9yhKgKtKvKY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uWkCeV4y; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=V8tHIi8mtmD3siYN748Lkzi4LVwXGCeJa+lIehzP4co=; b=uWkCeV4ysT2+I4xSNxZgjS/hDW O0MYpnRf2G3nZscjAqThdwQD6jkYNEpjVypoLlkvW6o0CubwwU4bn3HQgwXxqE2bkpyvzE1YCRI6e xfKZwJDOlZ9qrqrqi1JS1OBvNoXQbDA/d0lpIBHq8igi5ZbiNF6tlvh3YHmbMMyfLTXduF7KjlDyy 8pF7x+/i2qveYWxGRGWmo8R6NHtfURZDYaTFE38szNynHh3vD3NpOnHi2Zev5QAE0Pzii85oL1mr3 cx/C/CLXXuGXJ+bfOSvRVP6gnMN4/mWHOVvjBs1c7fu0EvEXJUrDSO5eIhdAw/2qRfOzbbgfMmKeC DubM335Q==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvFxM-0000000986C-2SQq; Fri, 12 Apr 2024 12:24:36 +0000 Date: Fri, 12 Apr 2024 13:24:36 +0100 From: Matthew Wilcox To: "zhaoyang.huang" Cc: Andrew Morton , Alex Shi , "Kirill A . Shutemov" , Hugh Dickins , Baolin Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com Subject: Re: [PATCH 1/1] mm: protect xa split stuff under lruvec->lru_lock during migration Message-ID: References: <20240412064353.133497-1-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240412064353.133497-1-zhaoyang.huang@unisoc.com> X-Rspamd-Queue-Id: 16AE28000B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: t3a5ai41fpbq451s58m3zbzebr7hducj X-HE-Tag: 1712924688-95036 X-HE-Meta: U2FsdGVkX19i7IR+ndHdpWfmIolD1Lc15Z/tR1UfK+3Z2kANxBTSGZgYEpugYCXXws83BNV5efzE0IjEoG6gAbMRYjpfLpca2sUD1hnOztD44oAgrAfvtZjiOl3abP4WRJYTduXCmfj+Ghjdlmp/ENvKk3B6pdVU2M4ZQ+ugdCIvYbvXVGdKjTB+6wklz9Kug1KbMaUEwdnu+SKHV1TlTZv1JyEC3cHZfxs9gLK2AZI+6QLrN643+8tw9953aVqNdRNj6Sp+W+uOTCREviGNZKzZFHp1hSW8GyQIB8nHWFcKfC7qTf5WNNF2XKsmZHsmF8Pd7yECpRuEq8OLgDsnIEVdVM/Aq1sAkNK9VUZLZwkyscSzbnm0ZfJ7I//qCjiITQq8ll9d9l0z5m1qdlNUloHgHEgr6a+LlDw/HbvGwMC5VqQluFM+Pwme5o8jTM3ZCxVmBDlzVo7jPvBsDBLqstUmVcSXieUiREj3gSeTvqcS1iy4FFGnyXiQAP7uFy1Ws0A1k8MZw1L9NqRbwJZdvvMQLlj/f/NE9FOdoFkzNpsS6PCLb5sWQNLpj7sWiDutReRtVmUFPcTgspHxr9MAVOmxWZ9PKrYZKKSOI6OioxtA8h9RGo4sx17zrOQEQ/36JX1GbZG0uSaoTcMnUbMnQwSROhclqQOSzIOM5+1VFZTKr/3nSO297wpasu38/E9+Gh3aBTCfV0XHFmfO0rNynVQITQG+CfAqV65EFoi5zGHwjzGjma9pop2N2LNEGT/A8ACCORMJjvt0EhEcfuwj/2CzQKo45P4AdG5TfkIksKj+U0ZGQ8RbkmalJMj5KapUzID60NjRjdRyx4qqzI5bL/zH6egeCTy7iDMXVcF6A+iTC2UbwAMWxryS1RevMOrWDcWLTLXz30ZlWv1MRxT+oCorg+WyrpRlDl05X4kD8MCwFiZt11WKEQjdVk1wA5snSV6Mika9wliYqqaYqL5 qn1WFSuN xuRSTjSN6jOjUZN3D5W96jqNoZjpazKJSifKGGD61Q7OSoA+bBy5c/qCZkO9hnx4H4Hl24Mp3YFxRorzswaY9OJKdlf+wn1SdVNzWgVACkyW6Psve2q34uA4rqw9QtLjnRGTSmkUzBrZaNgUN3bx5dKE7Ki3LB429kPgydA7TFznl6WdcNbx4XfXMK23zcJq0fkEnMgxtdEUOY4jdFH68ZUrciLCizSr7SmMo8WUt08CKnFJbd86rzIOUGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 12, 2024 at 02:43:53PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > Livelock in [1] is reported multitimes since v515, where the zero-ref > folio is repeatly found on the page cache by find_get_entry. A possible > timing sequence is proposed in [2], which can be described briefly as I have no patience for going through another one of your "analyses". 1. Can you reproduce this bug without this patch? 2. Does the reproducer stop working after this patch? Otherwise I'm not interested. Sorry. You burnt all my good will. > the lockless xarray operation could get harmed by an illegal folio > remaining on the slot[offset]. This commit would like to protect > the xa split stuff(folio_ref_freeze and __split_huge_page) under > lruvec->lock to remove the race window.