From: Matthew Wilcox <willy@infradead.org>
To: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alex Shi <alexs@kernel.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Hugh Dickins <hughd@google.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Zhaoyang Huang <huangzhaoyang@gmail.com>,
steve.kang@unisoc.com
Subject: Re: [PATCH 1/1] mm: protect xa split stuff under lruvec->lru_lock during migration
Date: Fri, 12 Apr 2024 13:24:36 +0100 [thread overview]
Message-ID: <ZhkoBNudREynp6GQ@casper.infradead.org> (raw)
In-Reply-To: <20240412064353.133497-1-zhaoyang.huang@unisoc.com>
On Fri, Apr 12, 2024 at 02:43:53PM +0800, zhaoyang.huang wrote:
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
>
> Livelock in [1] is reported multitimes since v515, where the zero-ref
> folio is repeatly found on the page cache by find_get_entry. A possible
> timing sequence is proposed in [2], which can be described briefly as
I have no patience for going through another one of your "analyses".
1. Can you reproduce this bug without this patch?
2. Does the reproducer stop working after this patch?
Otherwise I'm not interested. Sorry. You burnt all my good will.
> the lockless xarray operation could get harmed by an illegal folio
> remaining on the slot[offset]. This commit would like to protect
> the xa split stuff(folio_ref_freeze and __split_huge_page) under
> lruvec->lock to remove the race window.
next prev parent reply other threads:[~2024-04-12 12:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 6:43 zhaoyang.huang
2024-04-12 12:24 ` Matthew Wilcox [this message]
2024-04-13 7:10 ` Zhaoyang Huang
2024-04-12 21:34 ` Andrew Morton
2024-04-13 2:01 ` Zhaoyang Huang
2024-04-15 0:09 ` Dave Chinner
2024-04-15 1:50 ` Zhaoyang Huang
2024-05-20 19:42 ` Marcin Wanat
2024-05-21 0:58 ` Zhaoyang Huang
2024-05-21 1:00 ` Zhaoyang Huang
2024-05-21 15:47 ` Marcin Wanat
2024-05-22 5:37 ` Zhaoyang Huang
2024-05-22 10:13 ` Marcin Wanat
2024-05-27 8:22 ` Marcin Wanat
2024-05-27 8:53 ` Zhaoyang Huang
2024-06-14 3:31 ` Zhaoyang Huang
2024-05-30 8:48 ` Yafang Shao
2024-05-30 8:57 ` Zhaoyang Huang
2024-05-30 9:24 ` Yafang Shao
2024-05-31 6:17 ` Zhaoyang Huang
-- strict thread matches above, loose matches on Subject: below --
2023-10-03 13:48 [BUG] soft lockup in filemap_get_read_batch antal.nemes
2024-04-16 9:31 ` [PATCH 1/1] mm: protect xa split stuff under lruvec->lru_lock during migration zhaoyang.huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhkoBNudREynp6GQ@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=huangzhaoyang@gmail.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=steve.kang@unisoc.com \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox