From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5732C4345F for ; Fri, 12 Apr 2024 03:18:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5ABC06B008A; Thu, 11 Apr 2024 23:18:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55BA76B008C; Thu, 11 Apr 2024 23:18:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 423526B0092; Thu, 11 Apr 2024 23:18:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 23A8D6B008A for ; Thu, 11 Apr 2024 23:18:05 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D6C3340D47 for ; Fri, 12 Apr 2024 03:18:04 +0000 (UTC) X-FDA: 81999420888.27.7C33E31 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 48A8710000A for ; Fri, 12 Apr 2024 03:18:03 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gKsvZNoQ; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712891883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NGHNEfNwPq0wTlQXXsUCHhOb4IS9TlCKr2ChArmFvL0=; b=7kpATNTmEoKXBui9/NW4ndRx1wRtqUHcaQpm/SrVqxIxYzsKkuSX//GRgeDZmzRsZBQ54p rzFM/PHubU44D9Q1dGcsSJri9DeDSDtKzhXuL0wQX3Os0ikQ48ke3EWqIJALs1Mzyrsk+G xbMqlPr+5Pg4COmHKUTM4C4no7C/BKo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gKsvZNoQ; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712891883; a=rsa-sha256; cv=none; b=O9YZ77fc/sBJqEZ0RXfqX3G9PJigoWrrCSwSxSlgm2w9WFmUrB94wsFhhIvb+bfeaUqTql 8mZ2DRr+7soBT5iHSx3Kl1RsO9gLz2G6zQrgeKf5vCtGt228tZNJakbaUBG4LLm1pdb1Ix fzxgzFLqFfAhveLmbsKU21YZiTxg/6w= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NGHNEfNwPq0wTlQXXsUCHhOb4IS9TlCKr2ChArmFvL0=; b=gKsvZNoQ/xGKsyiRcJe5LvBEc5 W3PqUJhIfX5ik4VpsNSukXOfqkr3mxbuhICmSTEunKWsT9yoDV1tOzFhLeI7QNe3qvTeIbbin2yk0 GKWeRVmCtMDmSMYHwTDvCsFuvMJetVI53WPE2poe16vBjXALu3y/RZ7UE189+WG1jERBaVXNr6yo2 WUCjhspvvre5O8rr8kLM1W9dCPbR4eWXUgKwv+IgsH9s5JlUOvFUTqDKt+myAHIizoIot4TdVXSWt fgpVtixX6GJqvaK9TISTNadcacxhxuog0erM/d0s4fNypJxpNrC0BBWaprUC7z8amepkcJ0gq80vw Wq75sRtg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rv7QM-00000008I4m-3oLV; Fri, 12 Apr 2024 03:17:58 +0000 Date: Fri, 12 Apr 2024 04:17:58 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/2] mm: filemap: batch mm counter updating in filemap_map_pages() Message-ID: References: <20240412025704.53245-1-wangkefeng.wang@huawei.com> <20240412025704.53245-3-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240412025704.53245-3-wangkefeng.wang@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 48A8710000A X-Stat-Signature: kqw3gkr3rz4gb4tdgk1iq493hqj1t1jm X-HE-Tag: 1712891883-129113 X-HE-Meta: U2FsdGVkX1+xu3o1/MkKo/DX+5gqfRuJ7S066m95xowD0PWxpRcwFBuhdfYI4mZmIBogVltl3+F1ONEfcffY1yUXAMWsKoGLXzXGeKLcWQtaNZJENGIqb5sOtzCHfFVUd0QUyqaCC4g9gf6NScHfY7+DP6lTq89/K0k+0LqSWA8IUnngsA2mhWlYha0hc3JBKC+7HJ1KTcFS4rhBaU1i0GfW8wWojPtQAf2GnOXANYuhfbz/dToFMUKl0i7IG7eUmJ3UylRCMT9pNLMYHfAqdA2cM663dlR7uSrW9xMhf+4tYz1umVJlt0k5ERbm1u7Zq1YbgL1T87eocNoBGPM5yuNrqSuznH89AXy5FSZ43M2JRpLn7LGX5ys1Gn6omgTiRhr1GPmWeayHzQSNUc2mh3sLCnPlMYNEn10EKJdvOQLdxE6xaobf0s4QGXnLAOBmrdwbPo4JY1YFLgNc5CMIXnjjuf0x1R+/5ZGP9TuqgHR9aqkv0inObYUhsE8sokRPeF9A1rRK4mQELTSOqOl6Jtee6ZhpaMWkjYdCOmRl/vlKYAQsyF3btZRJf+1FyKg9zK597HTi1mSSH86lfePWigpV8cww11r0pHcIe2LDbs55mu+ftRpnPA8yF9xsw6tKsnmmRqXAW0rNewCIlVVrm1yz1tEV2V54KsOeDFLJv1vGx39XF2gFyTpPhukEau0zhXipWscHLOV5qJdfJI8jkpZMfgwaHZdHXMeFauZnH6wlJr5+33QzHA0zxMtT6g+7cFoChisFQ3a+YsskKGdSZTB38Jayf8iIVBzGHtTbClYPUD0+/qPmtsej05e4PYo9jZOme4pgAndaQk3PJ1zZhUC9KcO/11Yra+cbBbFevlvkaU4tOV0ZrxUvgHxMGm9Ki9tBRIbLy46t+H9vW/RfGUNgmkm4aL8c4eXPvYclj04Xt2kxRLsHNZPgF5fRaskztA3dPBl0sKQqjiMPMHl b7rXJ1Lc CsJGZXor/LOoN/QoduLj49/D85m8GFW231JQoMqX5Pg6daMuANXho8TIZb9J/dQnOwTZTBgXccrq06S3Tt763/2BFe/AxzynrFl+UWU7RklOO6A76tjMCIYcCDTXtOR6eenP7ip8HH7KihSA69I8yxA+c4aUoV1ksEB+fAH+G9j56xzFfjHleqgme+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 12, 2024 at 10:57:04AM +0800, Kefeng Wang wrote: > } while ((folio = next_uptodate_folio(&xas, mapping, end_pgoff)) != NULL); > + > + add_mm_counter(vma->vm_mm, mm_counter_file(folio), rss); Can't folio be NULL here?