From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97876C4345F for ; Thu, 11 Apr 2024 21:28:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17FEA6B008A; Thu, 11 Apr 2024 17:28:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 130986B008C; Thu, 11 Apr 2024 17:28:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3A036B0092; Thu, 11 Apr 2024 17:28:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D3AFA6B008A for ; Thu, 11 Apr 2024 17:28:02 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 69DF2A0D0F for ; Thu, 11 Apr 2024 21:28:02 +0000 (UTC) X-FDA: 81998538804.13.29DC45F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 1C62A8000B for ; Thu, 11 Apr 2024 21:27:59 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=D5sgudyB; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712870881; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1tQ0lOIHbz5US+vfPM6E5TPrSdCoeYL4E06YeAvQ17s=; b=3Vyc8an0+XXzY+BMA272h4SQtUkxqr/XqE1C6tv7adCpaJ+KOHTzR8GIGWMw/wN9jOlnDW SZhmh5gIPXqILg4RpSn23ngY1TWaK8n+5Eb2MdD9lOdVHr1/tyM0XfJyCsQmKYTGdJwMYD iOaW1VIRePY/xR9kgNNe6izI02dThGY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712870881; a=rsa-sha256; cv=none; b=u3WW8WSYDy20xoqxG651dHP0g0bsETqDu5HrDqwA2pdi9rC4AuP5wvxgBlBlBo1QDEo5Rs pi9GSkMKkV6Rfy7BxUdptydtn7uFZCr1M6fwZTexDM8chQkb4ALbuJAWvIXoevOAWD9VZS QmC3vVKWusfoTPWs+un3uMbKRTrAiDU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=D5sgudyB; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1tQ0lOIHbz5US+vfPM6E5TPrSdCoeYL4E06YeAvQ17s=; b=D5sgudyBnVEWp5Tvvr6jUtqqI1 azQxRvV2ZzrQI4RjhaYwh8Amq3V/fcKd5eO55nAHPF30t972JaZpQp1HbEy99n0Usf2x7b9S9H6Le D4noTgL2drl3XfPVAho/3QKYQuzK8KUwKkzsZ5NkdFV3xgiEYmN0UAdd+h30keRLYngYG58LKLwqg GxoRaL4nAkviVNqqYNYtIW2ZPOx7FiZwJrT5x8rkrYwKTkkzc+6hdTI+tD3GLh4lTI9aaV5kkjrv6 XKqXREhQFcWmvDpMtwZIUohklBq4brkLR040e6S4OY5QGM7NPqwlMZGH2E/X7z4xgpatpBzHFpVbu +EPajBPg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rv1xc-00000007lZf-0YzY; Thu, 11 Apr 2024 21:27:56 +0000 Date: Thu, 11 Apr 2024 22:27:56 +0100 From: Matthew Wilcox To: Peter Xu Cc: "Liam R. Howlett" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Suren Baghdasaryan , Lokesh Gidra , Alistair Popple Subject: Re: [PATCH] mm: Always sanity check anon_vma first for per-vma locks Message-ID: References: <20240410170621.2011171-1-peterx@redhat.com> <20240411171319.almhz23xulg4f7op@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 1C62A8000B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 65jzb47tywhmribr3a6cyqaqmce38xog X-HE-Tag: 1712870879-877427 X-HE-Meta: U2FsdGVkX18JmlIgfbTanO/iX0RQRjAiBRKoYYvgFdmup+UYDDIsFsO+7YAFzAXEvTw+hfrsra0B7/S6u5LVYHW1rbU57a7ByhDoFN4RantbdM2YYXD5ghHFwfwVniYp8hgjXDSwtIpiukaOxaWkG1jPOHGOrNsLtzQM+rOjLhSQ9Ux4m4FOxyYhd1GG5DCd5yFEIAvg3rIBGXPtsCMQRX1T+qVc/RkcxOKEyeSE2IvNEvTENHihvtYP2vj7Uk3qmOCKhqVR175sA0XRu4zBic+D3JsSMQroZwEzDMZGT0JTFVnJsfpP/ONsIFKwdCo17wZNVH8F6q5NtQT2J8jIviF5u8kbREHy7goPrSrMItuI4czE2BxHXrv9u4eO3zCBchpbNHcVeeGBo2Ifv0pSMSKssWYkxT0o+FIDRraBZQkCV8Q8VBliiZTamlatMuwRPR+qlIHkc4YpurjWUQZJ2ad/hvld82VyJAruITTaHIBElHYhwRWRGs8Ki0g8VmueQ86P3HBFclds4yrJo1uKrWGDsoxVTh30CJPZibqa1ITFHUob9y1YnOHubOpqW8oWZlnzmK5v9rA2rcmpoiGLmEarbknP5NDZSkAzQJjw0PdFUJMYpW8IL3gOtt+Kvuh15QJB/ia9PZYS1ddrdR1rrG1r/rh6W2WYDAZG2TjsXKUHou+EnCfQwpjy6D6bsJZtA70FzbAZKT+gCq3pbZss36vbbYH40uYAS0Ij2VMpEo48tUjnhhlR1roFMkFM0NvEcAkrRUQ0Glb/jZAIqK+3Tgp3s3qEshm812ZDT5MWqIglF0FT8JZfTgZ2s405BTr3bwfOZIVlJJNl9psv1rHBUWRch3JCmwUTJjaFbX/zTwAt24kcBBi/DuGfKV0XjwdSYz6v9uSEAzx0nMk8MLTo+OJdRZnWoABVYzAq394GAxQN0B2/2BIJX6KRZISYQC2UhW0SF88G7iL/OdGAWj5 vo9XgMcn 6ueVvmex3UJdfKLfKqFy7Ma9CVvtDCexPsh99ocYypSeWbZ+9OCLWFv/yrKVpZQyV20RDrgwYQcGRXVAiF8vqPOEu5C3D0O19xme4aAEzTquWiDoLK2R8Z0TlMBZGXE/BJMAucVd8JJ5FlRKRpDZ+C41yeLMiFYJb4w0MRojTXnZVR3MoqmTfRuM/8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 11, 2024 at 05:12:02PM -0400, Peter Xu wrote: > The question is whether that's intended to make it as complicated. For > example, why don't we check anon_vma for anonymous too later when prepare > anon_vma, however we do it late for file memory. AFAICT there's nothing > special with file memory in this case. Yes, it's absolutely intended. If anything, anon memory is the special case that checks up-front. Congratulations on adding additional instructions to the common case. I don't understand why you persist with your nonsense. Please stop.