From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2A26C4345F for ; Thu, 11 Apr 2024 15:51:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62D276B0092; Thu, 11 Apr 2024 11:51:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DDDB6B0093; Thu, 11 Apr 2024 11:51:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A4BD6B0095; Thu, 11 Apr 2024 11:51:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2DFA76B0092 for ; Thu, 11 Apr 2024 11:51:07 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E1FA1409B3 for ; Thu, 11 Apr 2024 15:51:06 +0000 (UTC) X-FDA: 81997689732.27.866FEEF Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf19.hostedemail.com (Postfix) with ESMTP id EDDD41A0016 for ; Thu, 11 Apr 2024 15:51:04 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ii25P0BG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of shorne@gmail.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=shorne@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712850665; a=rsa-sha256; cv=none; b=j8t0IyU52Yl0DA5hvQMwG24GJFordZN5G0rEDN+4lBNwOn3rSwy3SrhLIXcrgNNSYOoqJO HcgnLuX1Szz5PPN+9ZhBiKGzifI8JKv/I7qMzoTW6b3BM+8EA60G3G5c/BubKpKgRvXP0r zp9SsYd2uiLbe9kdoinh3rVq3VkDPx4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ii25P0BG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of shorne@gmail.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=shorne@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712850665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qBD6bXpxU7Hkw+zKfp0+6VUMe+k70Bih07sQJuwKqO4=; b=7ogHygR3Idy6129fQchbDGwYDEpkefvufdBTOKpXbClxEzYJyirQ2+9RU2+N2q+MhsJ8dB oLEyuWbDxMswMfJKpQu60opFy6/bniE9FFO5sAaOCoZM/NOOLB8ZjQXNqwvU6ufZd7sRq1 YPxA37NZRbKCjsNUyJCEYAan/sCpa8Q= Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-343e096965bso4461026f8f.3 for ; Thu, 11 Apr 2024 08:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712850663; x=1713455463; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=qBD6bXpxU7Hkw+zKfp0+6VUMe+k70Bih07sQJuwKqO4=; b=Ii25P0BGqWsD5HEv0sBqsdVBSfERLEJVrzkiyD8A+lZOlDk2YpnND8Kibu4Bhp/704 /vQC00NyqJBcJVQAwCHi/FxrsBsdhVv0sQJriAfnelmhxfBW9MQhRler5G751hoXeUrS EZk549+EAOTkvU0MfKLzbJbT4m1UYd7v4gEntiMDyaPF/YgepjOyAkZyQLZnODHLm6km JjohNSeSMMxFj4d8MzBQcGH2ypSw06Gb/lzXw0hJWRFpXNUizUiyeTI6KDJvXwpA+mii jPywQUlpyooICOb7vfsNAMwuPOiWmBlvHgct1EnUVDl4JWNMaxtTNEB1rpbLIxrhixNz frbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712850663; x=1713455463; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qBD6bXpxU7Hkw+zKfp0+6VUMe+k70Bih07sQJuwKqO4=; b=X7XLbvY4raMPMaR0Yle6evjNL2En/aavd5c9ajYLeGbIgOpfs4YF4mKFVSWTi/FTZP dFMRDeWFqINSOlbI+d4sp6dHdb/e5JLZjMSSHRQyxRfog3kl5NsQp0v9CybEPveiO4GQ bNisSxwPqCdESua3SObrN24MiZhajrYKNOgs0jIHB0TYC/wxYuM7nXHnLJf52Y9G6lL/ 9+pNZN1yAf6Q1TTkr/lCnso+z8ubKJzLvP/AqM0pePDnGAEsEFZzrBCyaFIQbWFEa8PZ WfKPfbqBIUIro0Qn8DYDMCbyyfIJx1VptNzYUdJ8HJUoZKW3XPzzDsRiO8p1Pkcmti1d 0tFw== X-Forwarded-Encrypted: i=1; AJvYcCUKAO2CIIOV3HzPzdtmkB6a0dzNXkMvknrwVzfWA+hEat9EsT4HwlGInqrOhznKrViamWFaVxu55DxTrMCbsqwMTuM= X-Gm-Message-State: AOJu0YxGRl1oOPocP80zzfCT5Sni+oaOHYXKmkc6w29pWW/q1qS4zI56 pEmtlnf2UxAwSym2m6N7Q9gjh1NcbICfPp0CEGn/eQPXRnYYpcqK X-Google-Smtp-Source: AGHT+IHhJrxsiQjIDC0gM5a+V9NSj35vvKdB1iZjSZCjZsxnUYLqqKJffmY3UuQ2WLcDy4WDf0azHg== X-Received: by 2002:a5d:60cb:0:b0:343:44b9:af97 with SMTP id x11-20020a5d60cb000000b0034344b9af97mr4906878wrt.64.1712850662873; Thu, 11 Apr 2024 08:51:02 -0700 (PDT) Received: from localhost (cpc1-brnt4-2-0-cust862.4-2.cable.virginm.net. [86.9.131.95]) by smtp.gmail.com with ESMTPSA id s1-20020a5d4241000000b00343ac425497sm2059234wrr.46.2024.04.11.08.51.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 08:51:02 -0700 (PDT) Date: Thu, 11 Apr 2024 16:51:01 +0100 From: Stafford Horne To: Geert Uytterhoeven Cc: LKML , Jonas Bonn , Stefan Kristiansson , Eric Biederman , Kees Cook , linux-openrisc@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] openrisc: Add support for more module relocations Message-ID: References: <20240410205201.1885032-1-shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EDDD41A0016 X-Stat-Signature: n8abpgqbx4xy4zwzm7n6dr879e19f666 X-HE-Tag: 1712850664-222862 X-HE-Meta: U2FsdGVkX1/FqWAtfDEDo54UMLPshoY5iNTeEnI0NamEiHG4QRnbAcOGBmy0ajO0Hte9eYX/rffrL22eJXg3LO8WO0geN3mhpIqFXIXBkEPi2E0tnoDyD7q0//D58z3GnMsRyWF2K+VQ1/Gs+vtMsIPVGYD2LpYJE0WTPKJqwGzc46Lh+t7kcyAvKL71zaFEGMXh009Ab5OpM19BxRD1wX4bkofsXzDiW90BZtsZViGNSHCIvOQnJsTiq5pNtgN7n9suPaTV3FfV65g4SZwKivazGJ+Hq9tYk+yEBWxaIYxqgufH3q/PuRGGfVHOY8joQVF4Py8UUWpqhA4ARN2Rgz4w8aSJF16dy4CmMJ80yknh1Q3z9Em2GLPM/d7NpGWkWB/XuDH5Wsuh8HhU6tGIybFffczGx2mIy7ADCviIlWnM7Od4slfzSeXKlvnTox8ClWPmYLbflMvqneL7A9G38B9lF7jWi1H/E4eapt1/g0utEn7Lq4L8NWP5zvm/xpM7udvz33J+kQ93xLv5fZdvpibVQVaFnGZD09+DJ7TktStbf+rUok143xJOgNNAlTYILgiCzhc1sYxpIAb76+BXQl5gEtI9GmzfTgQHjZfpwKYQULlStE6y9aqXIgaR152mXqqh/OcCn7OAujiQU8NbJKrOYu5d/Lqq9E6UfAwcaTXTd9CbQtIOA7tOh2UknjbBa7LST3ehKKh5B8av4mSo3QZNZ6BarFjI+bUPUwOk+IFnAMRVOKOz9sQ9tqzg0ODPWft2tQEK1OG+gRUfX/TbFTDH4lAhNQmeYIsZU+qQ2JrbdU3FEh6Iyj+9rFGNZw7VhL9F5Kl+SlFIGOY+kbkRsTAcJAXKX9PgbsonZnGSKEVEDyTx2tgbG1OSqoLpczOjceJ6pHouFJg/ZEYp3eU0V/sjULDBMH+82R9JxDTZBTCeiAMOcvnUVcUvoyRTp1SvXu2b+R+z/BbT8hsQr6t LkVCY4QP qT7fc+SXFtfTvDHeALL4YT0WMNKVxtWtMj9vm1PtZ1aIcO4BHwnNTYBEVTlWYJIhKIn+JVyU5wqr3kWq0xlM7zEljc9AGtH1FST8EhzJV/f/s/KGijJC/kjqwWbjh9Fz5Ij8v2YPJdhDdK1vHbgCt2jwfuVVbFpQlg75kJ2zj6chcAs45xzu8tzrZYJExvktAvHeDTC854e8zGrKXDJbkxoAOHO3rca8KJpKpjAoVFEUsjWPH4ebn6+8iDulojobmgWPbW3cBljLGAKtq3+6qGZCFnl3TEGQlaZEH/kyfvTRp9CF+GCQOkBlIvOEiSrx73hQ1f37F9pAL+xP+TQI7rj9pCeiDtMB1IFHuEOdVEkU5uCjBhCV0EwPv7qpy3DCkB1MGTfNwuLOL4fY6aIGY1ZVEZqgEss/dJ6g3eld6fGC492HbdJoUxG1fmYjYNkUdczJoHIoAJUSwDCsqK8PV8yfU+zFcX/4uXhOj X-Bogosity: Ham, tests=bogofilter, spamicity=0.043708, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 11, 2024 at 02:12:59PM +0200, Geert Uytterhoeven wrote: > Hi Stafford, > > On Wed, Apr 10, 2024 at 10:52 PM Stafford Horne wrote: > > This patch adds the relocations. Note, we use the old naming R_OR32_* > > instead or the new naming R_OR1K_* to avoid change as this header is > > exported as a user api. > > > --- a/arch/openrisc/include/uapi/asm/elf.h > > +++ b/arch/openrisc/include/uapi/asm/elf.h > > @@ -43,6 +43,8 @@ > > #define R_OR32_JUMPTARG 6 > > #define R_OR32_VTINHERIT 7 > > #define R_OR32_VTENTRY 8 > > +#define R_OR32_AHI16 35 > > +#define R_OR32_SLO16 39 > > Would it make sense to switch to the new names, e.g. > > #define R_OR1K_NONE 0 > > and add definitions for backwards compatibility? > > #define R_OR32_NONE R_OR1K_NONE > Hi Geert, Actually I had a patch doing this and added all 38 or so relocation definitions. But I dropped it at the last moment in favor of simplicity. Let me rework it and add it back. -Stafford