From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1B4BC4345F for ; Thu, 11 Apr 2024 13:37:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FEDD6B0089; Thu, 11 Apr 2024 09:37:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AF1D6B0092; Thu, 11 Apr 2024 09:37:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14FB36B0093; Thu, 11 Apr 2024 09:37:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EA6326B0089 for ; Thu, 11 Apr 2024 09:37:41 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id ABEAF140A63 for ; Thu, 11 Apr 2024 13:37:41 +0000 (UTC) X-FDA: 81997353522.24.C91650B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 8B2AE140005 for ; Thu, 11 Apr 2024 13:37:39 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="F8/rA2RJ"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712842659; a=rsa-sha256; cv=none; b=Hd2FGpl2VPXTqYOaj5k/X63CdINmr5tX6PQbJGssdy8vVdZ9XuhQ/j1fR++JzrDT49ufuO tkILe6tr1BOcO95eIQgMsXxRKCqAjV3nwwGDHEfoKeFrUqJWU//aaTbHI2NyK7bFFE8NKX ytWmzij1F+MZxgofj6ZWl1Ep+2OiL1k= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="F8/rA2RJ"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712842659; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dERZePAMGY5Ogff4MXaSm74/ezvcT6trwfEdO0OfoQE=; b=YXsmOQDiks7wslouUwAxKQR/zrdq6biG6141zEn4URZce6yPCdGODiVpC6iFMcSBbCjjnj UdmvTbfjbbR7K+nT0wih+4JujSBUzQVsEzHl2vygm/spAQErhhtPzWN2EtVqOzoGn9t6ye LqrwazGH5X/J6tjotfdjus2n4imCHZ0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712842658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dERZePAMGY5Ogff4MXaSm74/ezvcT6trwfEdO0OfoQE=; b=F8/rA2RJfIC520HM7Mk4iJAkB59vcXmGUxxbwhszrnG0aOf3dKRZHwrDd1jzwlPFCnsNuc 2oLH996RMV6SDaTiIXXzSsu+GRIf01qSF5QKlsAFDsE16WOA06NexwVSlzjZnTDrpYCKPL 3ah6Tdp9/ils5OhmyqqhL1EXeE4O+NU= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-468-REY0TRmkMSm1HrHswJT_uQ-1; Thu, 11 Apr 2024 09:37:37 -0400 X-MC-Unique: REY0TRmkMSm1HrHswJT_uQ-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-69945bfdbfdso2030766d6.0 for ; Thu, 11 Apr 2024 06:37:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712842657; x=1713447457; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dERZePAMGY5Ogff4MXaSm74/ezvcT6trwfEdO0OfoQE=; b=CE0zH30SNBeiGCc6j0UWAfLbNURToo9WD4FubInT+YaKArTcvdSfM09P1FZoYDwGDk xYlogRilYv42k+ICNW67VR/4dX0LipVRk+NJ6wO/uD2Gr57RGxL4GR+3DBAad8MM2m2E otzkf/PZa8SsCjeqx/DqQBXEe5leAGSYifY/gndH3AskRSlDQ0cSr2kaOIHHZmm0iIVj 6ZAX7xYWWKX5+rN2ti0s9Z2wm7XwtWNEKBSmefQHhsa2/YnsU3biHfU67DsrRfNefvYO 8nlX9vchwsZ/Wrn1MYTeDtNtbMAeiMkHmPW3slm/uck+BtEkstThUguC0B8WrAACRzkM aeig== X-Forwarded-Encrypted: i=1; AJvYcCVc9r93wniLUp1UVoMMeynDRjIrSgfyhWw9XLUaKcskQjciudd1hLzlTCMbrmD+8hlk5q3JPszAmJzC68YnlCfpUiI= X-Gm-Message-State: AOJu0Yy/nyzGnA/pHta/TRzgeI1i4Xq98zFLbVGufQCXOA2HmYyKk2c5 GiM7D4pR2fy9Jvr1kq4sXh+Ba0l1ceS51NiI3bEeGD5u4ZAN6w05Y/cQ/+lxGZ2ISIuWOleXnc+ FO4ayi1dnn8/KoK+PhOMNaeJerLjFSspNItmCw7j0TWn0sW7P X-Received: by 2002:a05:6214:da1:b0:69b:1833:598e with SMTP id h1-20020a0562140da100b0069b1833598emr6052223qvh.6.1712842656851; Thu, 11 Apr 2024 06:37:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQ6y7GR0pZzFXXvPoL0L/gLuIw2bwjbZR6CEdv4NI7c2F2dzHLnZvnROzJ8bJwU9WvPh/HLg== X-Received: by 2002:a05:6214:da1:b0:69b:1833:598e with SMTP id h1-20020a0562140da100b0069b1833598emr6052197qvh.6.1712842656337; Thu, 11 Apr 2024 06:37:36 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id e7-20020a0cf747000000b0069943d0e5a3sm946973qvo.93.2024.04.11.06.37.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 06:37:35 -0700 (PDT) Date: Thu, 11 Apr 2024 09:37:33 -0400 From: Peter Xu To: Jason Gunthorpe Cc: Alistair Popple , linux-mm@kvack.org, david@fromorbit.com, dan.j.williams@intel.com, jhubbard@nvidia.com, rcampbell@nvidia.com, willy@infradead.org, linux-fsdevel@vger.kernel.org, jack@suse.cz, djwong@kernel.org, hch@lst.de, david@redhat.com, ruansy.fnst@fujitsu.com, nvdimm@lists.linux.dev, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, jglisse@redhat.com Subject: Re: [RFC 02/10] mm/hmm: Remove dead check for HugeTLB and FS DAX Message-ID: References: <20240411122530.GQ5383@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240411122530.GQ5383@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8B2AE140005 X-Stat-Signature: sjiaigs7gbkboajf88gbcocrtp6wb88c X-HE-Tag: 1712842659-321030 X-HE-Meta: U2FsdGVkX1/4QLSEn4Nvi1wJFbZx8tHWzLOATBlTjyuiaFZNOk7HCTNET0NyMNF/1d2lJMrt4sSNhwC1wViyO5ItilSnFD1KQxOt35hToi27vJmBF6AMibXsrIZnnpXsUu07FI0Ztlyx4BxEaYbyfYvphg2qf8z3K5IBK8Gpegdl7YzKz9kRskfw/E9yHCa3cR2Hez4MhMguBZL+l0MEZvRJhGV4VDu+vnEQ9IBbJULVvurfno5RBpO7B+eyw1uc/5C9Ti+mxu7zm2DO/AqrJEuO0p1nOTaLMgg2c8d/+4AG8+U1z/BuX6HthJq7FUIMzfHlyJzNEF04O8p2stNr7v0ROX1RtVlq+E/ovz5h84LGQWAsW77Ok7YGGAIRVm93sIB5bIyWQOP53wIILLSdNDVyl/j7bCwWaXdcB3lqvxgHKoKFgezykoo8GRWFou0Hi6/KPqmOch4cEk3J33XUAKB6GYHnDEe7loG5WyCHs9iQaem3kHl4Qs3QfoPrFb7iaZb9SzyurW1zmp7ufK5/VRMtQ6tjMrxpcUtLF/b+XcFA/eMkYKaJItNVomZPeUuht6eYeNqJTAE4NpQV6QqyJSEs+axM54Nm8LNqjRSpP+GaX4DC/Ti1R2hWJM5XqGd/t0bUp211whhSJzZUJBz9W8uT783D/66Fq/ISHny8cpV6z5wfQ5Ml3ucdQYcGcrElkOTCj+zauN6snLclvFDXCZ4/fnH4XTpMibVNiLiZTQX3l5nSNA+gtmaDLQ5AE5/1/sYH3RvrNiXb/oecqjZl2BloWfcQ+obczN3VbzIhxSws28lud61F0Pe9Yy637cFQvpULS8sfwZyRtxR3DpxWZTrxfYtVnJQ8zE32MnCI3fe9MqpEmWghDZdxmH1b53ZmUlGjezBBkt4dqtlQ0Wpqs8vejM3VdGqcJSIydsOIx/3yr/GUyq0JAHW29WhgZAq3MxIQwVj1pdY/g2qV6RS 10PF6gYx dtMUo55K8mPqAnZwICFA8LeTNA+RheEaKZzJvcZXPuHr4fJydIJ5auzD4thpW6wIRauVS8vjJcsEWBw3HgmRx45HnUZBwuV1RHDz99YdBwKMAiboxvVFA4GSzSau2jttiR3hp2vgmr83dTcZTIRuIAOPntNK8cBCakz9x6hUXyDPjfd9u4iN503i3IgdUmONnR4vUy/XjOXTsoa2bY4koB87gEAU1i9mjRgdBo/6Wd4IuQyjy4yV01EyoMh+Z25pcedS//X1fI+2V8BUAG9OAz2LxFKYA3666dYLMtiYruJP3vSLqsVq5JiQcLLey03xkvmKzC2+55tqqTx6TM5FQ3NgZnPqOJLOkq1rcVKalc/qVOb6A0xQks6yhTZgQ15BdSbKlk3ehsNcXuJVIRSLZR3R01m7ERnGqpfdrLhe3MYgS4NbNSvkBKYICWTijzLyHlfAN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000043, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 11, 2024 at 09:25:30AM -0300, Jason Gunthorpe wrote: > On Thu, Apr 11, 2024 at 10:57:23AM +1000, Alistair Popple wrote: > > pud_huge() returns true only for a HugeTLB page. pud_devmap() is only > > used by FS DAX pages. These two things are mutually exclusive so this > > code is dead code and can be removed. > > I'm not sure this is true.. pud_huge() is mostly a misspelling of pud_leaf().. > > > - if (pud_huge(pud) && pud_devmap(pud)) { > > I suspect this should be written as: > > if (pud_leaf(pud) && pud_devmap(pud)) { > > In line with Peter's work here: > > https://lore.kernel.org/linux-mm/20240321220802.679544-1-peterx@redhat.com/ Just to provide more information for Alistair, this patch already switched that over to a _leaf(): https://lore.kernel.org/r/20240318200404.448346-12-peterx@redhat.com That's in mm-unstable now, so should see that in a rebase. And btw it's great to see that pxx_devmap() can go away. Thanks, -- Peter Xu