From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6337CD128A for ; Thu, 11 Apr 2024 12:53:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A05B6B0099; Thu, 11 Apr 2024 08:53:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 751BE6B009A; Thu, 11 Apr 2024 08:53:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63EF86B009B; Thu, 11 Apr 2024 08:53:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 467726B0099 for ; Thu, 11 Apr 2024 08:53:19 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CB694A15A2 for ; Thu, 11 Apr 2024 12:53:18 +0000 (UTC) X-FDA: 81997241676.13.8686F09 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id A233540016 for ; Thu, 11 Apr 2024 12:53:13 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uyvIsNzM; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712839995; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6KEd/vOAcnw6j9QcgZoIhf9EMwJjW8sVx3QjpW3jwMk=; b=v8KbofAEEsD6of3jRuZ7oYeYJGLCFeMKSTo3lPShP/9ibUHb36fGksbjUNP7SBg1LPCTzC DSR1FOmMgaqUVrOBtG7CRfV+Un005g3/fUXEYQ7qgbJqFrrNjv7YNLNyaoiGDYYRmoyz+j pTmekwiTkrDP6mJPHyIiPwn7dsBUVuI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uyvIsNzM; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712839995; a=rsa-sha256; cv=none; b=BHh9YHipi99Gq5iZBIMmtOl2F/gfB92bZH4Ie/hl354wyzdRlw6y5iLeJQiFznFziHpteH lWkchkrcN0eOrE59usQlxXp0Wp22PoHXauv2o+SiS5yC8eX6m9fAvYGmoeOHaJ7GdXrgAq yLEbWsKd/hmFogW5wOe/LNAq9NMcNG4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6KEd/vOAcnw6j9QcgZoIhf9EMwJjW8sVx3QjpW3jwMk=; b=uyvIsNzMhAXWzrDoyj5T4dpAP/ 0SeFBWWeiGSPLT3p9o20AdPBhcPCrrbMbmaH9uE3ExBfFLp2e5IHbzGAMt1dcLXj0KcGmHewVzZGB TkcfGZE0QWernnPG9Gyi1glwfD1Q5K53KPPO4DP7HqVOLzePYUcNGuChw/tssudYkEHuA84AmuI45 PlfBI6Ewyq7B8e6Oz3npfNS4C9heKycsPFyXhfA90MZRfGc9z2q/CEKYAD9Kp+lALW1XWOUyfaCHY G+X1CsmbWHJS4YNE1DvUPr1jYWfpeKDYLfor4PjRSbrrWi1mwhF6VCoHO8EFxrr7o3UcLXTQXPbnD B9pnoTag==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rutvQ-00000006yoc-34oj; Thu, 11 Apr 2024 12:53:08 +0000 Date: Thu, 11 Apr 2024 13:53:08 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: move mm counter updating out of set_pte_range() Message-ID: References: <20240411130950.73512-1-wangkefeng.wang@huawei.com> <20240411130950.73512-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240411130950.73512-2-wangkefeng.wang@huawei.com> X-Rspam-User: X-Stat-Signature: qjbupfr4g7i64y78er881197gxfnyef6 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A233540016 X-HE-Tag: 1712839993-738638 X-HE-Meta: U2FsdGVkX1+MjDUa72za37ZkR3G1T/OyQCUzJMd2rAPQJ2EK3iZtoM9R+fbGH7Btcj9NKmvRiIWZTIv/BLzsgixuEZpVxPin2HDIXiRV+ds3oQ4svzWPbVJTnqX6svQpIRXZd8QkeZC0Eu6B3bSbkjo+fSLDhgh/id/qiGut8XKw1X+4iJibCV6n35Wh6/fBOs6B5Vcys2geq6XJOUcIBC7zJ4KPniKHXHXsMPen/9P3kABIQX09rK5RCeSoysxOmzbmCviVjHxH8Sdp6Hi2Moj5/vjLvqkmF7LVOckTltIk4ZV1AZ1qBksGQcAxmPJtPPmykhAKUH1TWPqEwG3Y/6oTUlO+Ap3KJPYlUD+jAfukpZrFW1tBisW24Mz8fcZJQ5JLanv/xOnWENGkkKoTp1CUq1fTQiY/8Moa1apOiAO/S0yzvbaC9VpCIF/TuOnzcpQkphtZedKZrG0X8IQuWBajJ0WrRurPqt615lCoiL2ixor4nhG31Ib63tk5bOR0MwuJ57UwELavvj/tAYsC22FuFXnx11aqBCrVN2iLW6FH9hBUAwNfVTDd11wNH+y173ChKzKQ2DwaMqK3e9TIrNA4UPVntTQiZleCRIHiCkH+VqYunVMJ6EV6FqVbtx14flqYK6/wEF4QueZHq8YNf02OAvM4+9nSyOqNu/ulGeqfzFSHBLauA0J/OHbdH4OpRd34zfaM9XoTmN4o5t+Ymn+5X6WTxvSlcNqKfBC7OInVohXyfD10gUbtpIgprp40kCYEWt1zwsAgfoC3LrGuYNHO++WNBefEyYOxLq6dJat+JEO3/RXmz3uNT3tzSmgD1s4+v9wK86iBZDTGHNWkadEOUM9eUo0wxfhJdPB9r/JwJBH8QIScs5y6832qes8Uu2s7FM1YI4vwZSsV4gRwtQelicPeg1PF23EVlWkYo5Anh9D3Al+xNy+hRyugSTUP6ZE1mqTQwkbl+k4Zlg7 pZJHlDAu Fw1GqPWqfWkSkVFGLvV2qHC2AfVcot/z64DpJDz8lKRlCvkjHnKd+yMH77tThwVu28VB1hT4TTVYYn8/zKjgjpzuEkupxeV8syJYapnv9AB89/OVRKRnL+P//HvTs23OacNsUF/hCcClO0mdInsBIiYgYS1v/b0COIh9uUb3+at/S14Xrtejf4WQdNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 11, 2024 at 09:09:49PM +0800, Kefeng Wang wrote: > In order to support batch mm counter updating in filemap_map_pages(), > make set_pte_range() return the type of MM_COUNTERS and move mm counter > updating out of set_pte_range(). I don't like this. You're making set_pte_range() harder to use. It's also rather overengineered; if you're calling set_pte_range() from filemap.c, you already know the folios are MM_FILEPAGES.