From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64B53CD128A for ; Thu, 11 Apr 2024 12:26:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F00686B0087; Thu, 11 Apr 2024 08:26:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAFEB6B0088; Thu, 11 Apr 2024 08:26:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D50676B0089; Thu, 11 Apr 2024 08:26:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B5C636B0087 for ; Thu, 11 Apr 2024 08:26:47 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 53AAFC0A1E for ; Thu, 11 Apr 2024 12:26:47 +0000 (UTC) X-FDA: 81997174854.05.26F3608 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf11.hostedemail.com (Postfix) with ESMTP id 6A2FD40027 for ; Thu, 11 Apr 2024 12:26:31 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=aI70pwew; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf11.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712838391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S5QeKmmUoyX5xyyZhHh7vdWOWq+vB95HSexOwbAxSU4=; b=XYYp3DqJDfyVzLCcAa/M3lnMox3HR6q2tab/Kj2PXCadU+idj3tuED3qdrzLt5Uwwj/rlV jF2SskVn322zCqGBvWCnt32vORjzOpJ+8em1RlwkVCPxqZrqcPBiOW3fijy7vqw7htiMmG LMz7UTlKuZQ6iRo6Y57+bBWogbcdMuA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=aI70pwew; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf11.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712838391; a=rsa-sha256; cv=none; b=xDN+wqqUVoJENxlr42CRIg2lY0uzeC3zxkFrgB/D3bGW6o6WgZaSHv1gayALnVdCEeRqKh 5VJ3SHLn2FcNecLZ8JHbePz/7agYkYjBr+x63lbpOlMURfhkWN9YoXX8PoNwbCNGmRbiEC j4xhijZVbjlZ58PCG7S8UG8jL+94lQ4= Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43BCBE53020993; Thu, 11 Apr 2024 12:26:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=S5QeKmmUoyX5xyyZhHh7vdWOWq+vB95HSexOwbAxSU4=; b=aI70pwew3Ptt4D9mUA/jBzfD6xITb3lu4gnGWLvmE2taiQVMsU2hMOOEHAnoqNJhNpkW p6wjw+uy1/NR9pGFXNu6F+RnxwyRzgOV5W4+hfHqXAmFTttcFLmtMmxvZzq0VRhEVVrs 0rtAxk4IQCtGoFDQf0qdYc2I6Y1iMaG0XYNA//NB7PXUrsEEOqO6yPUVjhU5sth/+jGP 4iZIVTS0zd9+PwXjXApCoOZTe9IXO8d+3Hb0cUByIifqtdo0vTfWekNWdj2lKU0UKRxj A9m/lKrlnRevjhmiy87BysbIpnDct3SLQThxcJfPeOppBdmK5UB7WhlRUcj7kD7IaG0R Ag== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xefh8019q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Apr 2024 12:26:30 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43BCQTt8009899; Thu, 11 Apr 2024 12:26:29 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xefh8019m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Apr 2024 12:26:29 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43BAluX6021511; Thu, 11 Apr 2024 12:26:29 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xbjxm2t8q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Apr 2024 12:26:28 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43BCQN4W50069998 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Apr 2024 12:26:25 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9435C2004B; Thu, 11 Apr 2024 12:26:23 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 413FC20040; Thu, 11 Apr 2024 12:26:23 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.155.204.135]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 11 Apr 2024 12:26:23 +0000 (GMT) Date: Thu, 11 Apr 2024 14:26:22 +0200 From: Alexander Gordeev To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Andrew Morton , Peter Xu , Sven Schnelle , Gerald Schaefer , Andrea Arcangeli , kvm@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/userfaultfd: don't place zeropages when zeropages are disallowed Message-ID: References: <20240327171737.919590-1-david@redhat.com> <20240327171737.919590-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327171737.919590-2-david@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 19erZIHPx_Nmi6mLSyQwNP8VzM7VBOk0 X-Proofpoint-ORIG-GUID: zulkTfLbj6WQeASqUSZ-sbV7sEDYxcvu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-11_05,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 suspectscore=0 clxscore=1011 impostorscore=0 spamscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 mlxscore=0 mlxlogscore=569 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404110088 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6A2FD40027 X-Stat-Signature: n4hjry6ydjtzjg95kiauwtdznj9j6xig X-HE-Tag: 1712838391-397952 X-HE-Meta: U2FsdGVkX1/oOicGnib88fqw3j3epYrNmC6sqSEDLyyUejiFGpQFWmjmaxY+Hi2tL8uN4roa2++E40tNZFUc8o4zaYbhvPhTJimZVa7CYI2MlrjLuoCgBbOzoF0CTekIzLMs0jP7Ky9XKCZtxO0DR3weIGEVXuuKPz3KxbTLZBT6/Hgfn+Pod1rYxq7Oe9juvKBjxSwxxnmJsoMlVyx1NtJoyggFev0YCjAuz5ved5U4vXcSNW8uweWbuZDnEifvlzcDbZtGf+dQD0tqWnR3tLmHxMNPcV9guWjc85B5Nb6kCOGnYRClWar3EsRWmM/PNEH1tWi+rnnJ0uQKeH0linSKoKWgTOw+fHvBes6yUBZSegx2KkmtZa5YhA2+APdrup+8X/mLly2Wvz5jYs7tvHN/5fiYb42dO2XipZu83FNcaDqAhljXXJyLOhuUR3p4j8CiFH9CaTNC9olMEQlg/RjnKTwgI8ZwsqLJz0K5252za17CCh92x/tVByFqOHQGB5jU4EmWkHGWZLthch5D1D47pGQK2AgBDaluRaqVRLSlQDmx/b+zuzxCXwkLPQPT0X3piuXJWLWBDVVYsJ7ZIbcpgiA0kKDS0fGiPop67t3QTRq5r7UubhGPwFCjYsk7p9JVqDm+oxIGIUTkZbHrdQfz8F29t0h882p6eBQ5nCUWAhyeVGtVt64oTuokPzEd5V57oCJUyM1z5YbXwHebGxFNA3gS/kLV8iZkRtZ4n3se6uY7RXVYjkkItUfTVri1abzbufYIz639A/Fo87Lut3FHGANsugl9IjiTUTnuqqICGhMmkntadz3yJl2jsRxeUMz8ubFf/PMWpFW64vWw6mW+iTmoXb1z1+E4MoUGgNBPP/6dVLvXKXJoWINFxpTCeEivytBXRKXGakI/oKp0EMAEC5kGJxAuk6jBK+lBl0PbUevIoKYVydq5PQN4xRgP3J0fYvjnT1boNCNUGj4 A3yywqR8 Y/CdRIcKd2lqERdHkOCrN1AvOk/OcPu8u0wtJBMSBIGMvYR7M7bfNSq1cr+DTcDGDbM5x/iggKbKFqxJTGW2qzH5SuDtb00JPjjGNznpN3VZrDYtCdCyMON57yFFN5O0jNOCDNdOyHva7KtrIophgMCmlZEn7/RbwkczM5S31kdOxJ6HQVIwfc5TIKKuPg46ee9rlstlWejAeXovDn2aUUps/UjryowkMs/5R X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 27, 2024 at 06:17:36PM +0100, David Hildenbrand wrote: Hi David, ... > static int mfill_atomic_pte_zeropage(pmd_t *dst_pmd, > struct vm_area_struct *dst_vma, > unsigned long dst_addr) > @@ -324,6 +355,9 @@ static int mfill_atomic_pte_zeropage(pmd_t *dst_pmd, > spinlock_t *ptl; > int ret; > > + if (mm_forbids_zeropage(dst_vma->mm)) I assume, you were going to pass dst_vma->vm_mm here? This patch does not compile otherwise. ... Thanks!