From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21D78CD128A for ; Wed, 10 Apr 2024 17:10:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6F556B008C; Wed, 10 Apr 2024 13:10:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F83F6B0092; Wed, 10 Apr 2024 13:10:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 899066B0093; Wed, 10 Apr 2024 13:10:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 64E5D6B008C for ; Wed, 10 Apr 2024 13:10:07 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 317E716089F for ; Wed, 10 Apr 2024 17:10:07 +0000 (UTC) X-FDA: 81994260054.22.095A190 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 1B1EF100031 for ; Wed, 10 Apr 2024 17:10:02 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a+xkYvV4; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712769003; a=rsa-sha256; cv=none; b=ziHQ6SvXKpHkphFLdUp6hZ0y/lNtmQd6QQzKbf0WArt4ph1hejzp8UB4obTdjkVrdPtEry Ba1/5FAsFFuBKR41pkgGBgYy6T7hleCuj9PD8vsHhDNEEPIv1QQk3ZjH3A/S5geeMeojrG qRFIFeSloS2OYexgVx3qAv6ScuXXNFI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a+xkYvV4; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712769003; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v0l1ynD0EW3Jmpq+Ulyaiq0nHLkeBnyCPceM9vs7ots=; b=DMXeGeWuvoB9aMLc6L4pGoyOewV7Nj3nHphOzjylV8HrqqV9bk31luw0HdW76u3gFUTFTT N+r0uF/IOVEJHRG6oNoJJpAkB0WWH7TANI3ktOZUvhomBZH8hv8lMjeayQXK6WcoF7LkUs Sq2UZJ4mb06K9Rh+BySJrYisSklA+kE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712769002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v0l1ynD0EW3Jmpq+Ulyaiq0nHLkeBnyCPceM9vs7ots=; b=a+xkYvV4inKFPfhDBqU28Em/3EVC3F2scfVFJQ1FBVA/KNC/ykqN3574yZvIYJioFtLUCU AMhDOZWK5BO/FxdANxR0186fMhqY+LAKgd+ymciNG5zJfiQozBtOcPV2M3ABWmWqU74y5P csz+9WnhyNLYRG3GuBDEi9Ungn/ZThs= Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-362-tGwL85kdOFCE03gTbof8Lg-1; Wed, 10 Apr 2024 13:10:01 -0400 X-MC-Unique: tGwL85kdOFCE03gTbof8Lg-1 Received: by mail-oo1-f70.google.com with SMTP id 006d021491bc7-5aa3afc55c6so1144298eaf.0 for ; Wed, 10 Apr 2024 10:10:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712769000; x=1713373800; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v0l1ynD0EW3Jmpq+Ulyaiq0nHLkeBnyCPceM9vs7ots=; b=N9NA0hL7zgUGXXANoMM3EC+h8NWadRxXqgSGSHhIvvF+AacrEC41RaJN8CURk1ZjI/ rglkJyz7EOp09XfURqq8MObQAH4CvaochV3+Ho3ruIY5MQR6VmBSHlW65MJjZxCAHto7 cv/ZwbhbyFsl6+cifRlXfREPR1R/s7FwX+rfAL2/dVzrP4SHstMUu7Eu2mCxnhqXErue 4PuH0pmwbkHaer0uavW9zIwSAfqgN3pGpK2P4JxOL03q2aIvp5+G8tazxFHRhqNh6pQO WcBZuJ3p2oHrL8OAxBhVlpQEdC32BL6YeJOqOOPx4aCoqzlYu7VZi6VgMaxhVHxF2Ae+ juVA== X-Forwarded-Encrypted: i=1; AJvYcCXKm+U8vE7zNR8tOfTI0tiI+vF2oFAybL9c0nfomg6+10FQ8B+pdny+hQLmVjfr8DvcdWrx8OWkLf2rhRDeHrgn8Ok= X-Gm-Message-State: AOJu0YzSgBZrbYoQ1S2DSIX41Cfy7sHZPpmRA+fKVRaaQI1ROahKHP2j GZlid4W7Wy80DqPGjrUvTcNQgXEvFXJaFkYhPSaR7Axs6IJiWeovC43f8aueCWBbuV8jXZdk4RB QadRINtmU/weK3g/h21jRqQTQV6GCEsZH3ZnlJ2pJe3ttOB5t X-Received: by 2002:a05:6870:f216:b0:22e:8800:b8bc with SMTP id t22-20020a056870f21600b0022e8800b8bcmr3433184oao.5.1712769000030; Wed, 10 Apr 2024 10:10:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGE/+7WQSnj/hTRuIBN88EVodJlSwEmPwY3FJlo7FEcAzIDxoZmRwfUFXXtj6Npb6mUKMjDdQ== X-Received: by 2002:a05:6870:f216:b0:22e:8800:b8bc with SMTP id t22-20020a056870f21600b0022e8800b8bcmr3433135oao.5.1712768999323; Wed, 10 Apr 2024 10:09:59 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id du47-20020a05620a47ef00b0078bc4cad726sm5455316qkb.72.2024.04.10.10.09.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 10:09:58 -0700 (PDT) Date: Wed, 10 Apr 2024 13:09:57 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: Matthew Wilcox , Lokesh Gidra , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com, aarcange@redhat.com, david@redhat.com, zhengqi.arch@bytedance.com, kaleshsingh@google.com, ngeoffray@google.com Subject: Re: [PATCH] userfaultfd: change src_folio after ensuring it's unpinned in UFFDIO_MOVE Message-ID: References: <20240404171726.2302435-1-lokeshgidra@google.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1B1EF100031 X-Stat-Signature: snbxoonmottgimbns889ajpamwar1kcu X-HE-Tag: 1712769002-995696 X-HE-Meta: U2FsdGVkX18JenPiu2KOY0z3P/V1IEY14QaOYbBzVFxCCse+Q5bblHPdhvB5oij+a+7vMBsBdEJVV/3hFOYGPVfUydQ2H6QV6TB9IOq1q99fr01dVE2rsSOI//qjScipwrMQqwk+I6Zqdk3q87fk+VxZ49Hb7ifXbLkp/i7aq8wCNcmLVh3NAAdthN2pijmouMwmHkp4AM4wHnAqXsJDr0w73al7Vt5M+dbqI4/fnG8DcX2qNdm1RgmsWEjD+mwcCoZwqjZBMTZhhJGbrT1WqSQLhp9nwuL5DeDxfCddgw0KWjHrLM2vUdK1I9w9eLMOc0M6UcZ23b2LVx1d/setnACavoK79wKgpQ+zaiTZUeLxsDYxomzDQeUpFYt1w1g+PK8SGfklE4u3dTrHe2qG/vK8+CpkpdB2XINmp9aFyIEzLPeaG2JJT2b6KrYr0g2akZhjKJ8MIvDztK/DgOUrk6HyDwSwjJyKsfD5WyM4oh+n7wVWWebn8i4yUTFKwgZqEKV5c+seuhToQMFTkdr+u68MaufB9Tv5044MB4VAjzQgKjZFPCgeKeDe8TkrGMBaFcQPCvzNfBlpmOtKT+VnfWigxFUqWp7TADZahhwX2Zdq7xxiSvO/VxB7/XMV3PDeexjYnReewMP8gtosR/joZb9zRsxZXx6Q7MM1cLLCp7wrGNcK/cRkomMXTe33UweAk7152mIfMYgnbc8JZE5zo2N4qixf31+HYyz83qqLuNg7MIyqF1QaDtrTtu1uu4ovuVOOOC5NFCYJL0D/9P2EIVm0jKIdKON73TYxdjWugvDCf3ND/UxTw+d8ME9U33vX60iU56jsc5cUPbpaSE1C9SOSV4Kp8+hHGz3uDCKP+is3TahTpNfb5Pki0pdbZGrIjN6/LbYm65ZDJnt8b03oNAIB9WM5kHN7cmjiibM5LjiU4qCdUrIp+3ttwxJumvJfvDes8UR0vAcvwkkEt5f hh28LfGr NcwxxKmGBzhs5jdjawRc70njBD7wUxBURFrwLsWUaLJ/0O0hwXloGGEBYdOtO88M+UbOt8XDcevSAuPJzHc74oSXmwd5tFEQNWZRQoKiF4DJevprY8beupyEklT5QA4rvEnzLDqTAXMe896CFW1hiBDL62Yyrn/ssP7OLVKG0RMLTZdFeNSv7Kpn5OMnKOmR+LG/TVM6QLcZDPQastirqftDgOijGk3DuMAyOY4cxY/gRFJZnJAA7hXYIXwBq7uYZzaeGaKRAEQ1olY3u2Ea94fhJnDL67V36U2lo8uI5qneMpvqnWx7YC1NZ7b3iwP9DmAS++SD9OqD8D9crK18ry6Y08XP+c1zXZsyd9f6y39F8zK/WmRDv0q0NDh+HcF2Qd2rEtynS104W3LbshOYsL9GNxxjX6CBHeFdW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 04, 2024 at 02:07:45PM -0700, Suren Baghdasaryan wrote: > Yes, I was typing my reply :) > This might have happened simply because lock_vma_under_rcu() was > originally developed to handle only anonymous page faults and then got > expanded to cover file-backed cases as well. Your suggestion seems > fine to me but I would feel much more comfortable after Matthew (who > added file-backed support) reviewed it. Thanks. Just in case this will fall through the cracks (while I still think we should do it..), I sent a formal patch just now with some more information in the commit log. Any further review comments welcomed there. -- Peter Xu